Investigate TabletModeWindowManagerTest failures in mash |
|||||||||
Issue descriptionA handful of these tests fail and need to be investigated.
,
Mar 7 2017
,
Oct 20 2017
,
Oct 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29417f906b3effe070a5e92ecab81c9cf8a318e9 commit 29417f906b3effe070a5e92ecab81c9cf8a318e9 Author: James Cook <jamescook@chromium.org> Date: Fri Oct 20 20:09:42 2017 cros: Re-enable TabletModeController ash_unittests for mash They seem to pass now. Bug: 698093 Test: ash_unittests --mash Change-Id: Ie313b33fe79df3422a7271eea773f67c4ec65b38 Reviewed-on: https://chromium-review.googlesource.com/730766 Reviewed-by: Elliot Glaysher <erg@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#510539} [modify] https://crrev.com/29417f906b3effe070a5e92ecab81c9cf8a318e9/testing/buildbot/filters/ash_unittests_mash.filter
,
Oct 20 2017
,
Nov 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8675cbb337440a11bf9afb10ea11bae42bb92cb commit f8675cbb337440a11bf9afb10ea11bae42bb92cb Author: James Cook <jamescook@chromium.org> Date: Fri Nov 03 17:59:35 2017 cros: Enable some tests in //ash/wm in ash_unittests --mash For the ones that fail, disable them via filter file instead of in the code, per our disablement policy. Bug: 698085, 695556, 698878 , 698888, 698093, 698894 Test: ash_unittests --mash Change-Id: Ic145ab6a95508968d6884d14fac2a3ca08888d26 Reviewed-on: https://chromium-review.googlesource.com/752423 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#513836} [modify] https://crrev.com/f8675cbb337440a11bf9afb10ea11bae42bb92cb/ash/wm/immersive_fullscreen_controller_unittest.cc [modify] https://crrev.com/f8675cbb337440a11bf9afb10ea11bae42bb92cb/ash/wm/overview/window_selector_unittest.cc [modify] https://crrev.com/f8675cbb337440a11bf9afb10ea11bae42bb92cb/ash/wm/panels/panel_layout_manager_unittest.cc [modify] https://crrev.com/f8675cbb337440a11bf9afb10ea11bae42bb92cb/ash/wm/panels/panel_window_resizer_unittest.cc [modify] https://crrev.com/f8675cbb337440a11bf9afb10ea11bae42bb92cb/ash/wm/system_modal_container_layout_manager_unittest.cc [modify] https://crrev.com/f8675cbb337440a11bf9afb10ea11bae42bb92cb/ash/wm/tablet_mode/tablet_mode_window_manager_unittest.cc [modify] https://crrev.com/f8675cbb337440a11bf9afb10ea11bae42bb92cb/ash/wm/toplevel_window_event_handler_unittest.cc [modify] https://crrev.com/f8675cbb337440a11bf9afb10ea11bae42bb92cb/ash/wm/window_cycle_controller_unittest.cc [modify] https://crrev.com/f8675cbb337440a11bf9afb10ea11bae42bb92cb/testing/buildbot/filters/ash_unittests_mash.filter
,
Nov 3 2017
Not all are fixed, the remainder need CreateTabletModeEventHandler() -TabletModeWindowManagerTest.ExitFullScreenWithEdgeSwipeFromBottom -TabletModeWindowManagerTest.ExitFullScreenWithEdgeSwipeFromTop -TabletModeWindowManagerTest.ExitFullScreenWithEdgeTouchAtBottom -TabletModeWindowManagerTest.ExitFullScreenWithEdgeTouchAtTop
,
Nov 3 2017
,
Jan 24 2018
,
Jan 24 2018
,
Apr 19 2018
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by bugdroid1@chromium.org
, Mar 3 2017