Issue metadata
Sign in to add a comment
|
DevTools: scripts reported to front-end have trailing newline |
||||||||||||||||||||||||
Issue descriptionChrome Version : 58.0.3029.0, Linux 1. Download both files and serve them locally from the same folder, e.g. at "localhost:8000" 2. Navigate to localhost:8000 3. Open devtools and check "foo.js" in sources panel Actual: foo.js has trailing new line Expected: foo.js shouldn't have trailing new line In fact, the trailing new line comes from V8 as a result to the script.requestContent() method.
,
Mar 2 2017
This file contains new line, we're cool enough to bring it through V8 for you and report it correctly back. :)
,
Mar 3 2017
Thank you so much!!! Chromium is my favorite browser.
,
Mar 3 2017
During debugging I found that we report source back correctly but lying in scriptParsed notification.
,
Mar 3 2017
,
Mar 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/77169d413d6a7cf5d4d4d1ee552c1cb5f87814a5 commit 77169d413d6a7cf5d4d4d1ee552c1cb5f87814a5 Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Fri Mar 03 03:05:04 2017 [DevTools] prepare tets for V8 roll V8 roll will fix endLine for scripts with empty end line at the end (most scripts). BUG= chromium:698077 , chromium:697334 TBR=lushnikov@chromium.org Review-Url: https://codereview.chromium.org/2727373002 Cr-Commit-Position: refs/heads/master@{#454487} [modify] https://crrev.com/77169d413d6a7cf5d4d4d1ee552c1cb5f87814a5/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/77169d413d6a7cf5d4d4d1ee552c1cb5f87814a5/third_party/WebKit/LayoutTests/inspector/sources/debugger/debug-inlined-scripts-expected.txt [modify] https://crrev.com/77169d413d6a7cf5d4d4d1ee552c1cb5f87814a5/third_party/WebKit/LayoutTests/inspector/sources/debugger/debug-inlined-scripts.html [modify] https://crrev.com/77169d413d6a7cf5d4d4d1ee552c1cb5f87814a5/third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-scripts-expected.txt [modify] https://crrev.com/77169d413d6a7cf5d4d4d1ee552c1cb5f87814a5/third_party/WebKit/LayoutTests/inspector/sources/debugger/live-edit.html
,
Mar 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/0832bae354f6001ba5b3647c42304bad1003bbaa commit 0832bae354f6001ba5b3647c42304bad1003bbaa Author: kozyatinskiy <kozyatinskiy@chromium.org> Date: Fri Mar 03 06:58:11 2017 [inspector] fixed endLine in Debugger.scriptParsed event BUG= chromium:698077 R=lushnikov@chromium.org,alph@chromium.org Review-Url: https://codereview.chromium.org/2730813002 Cr-Commit-Position: refs/heads/master@{#43567} [modify] https://crrev.com/0832bae354f6001ba5b3647c42304bad1003bbaa/src/inspector/v8-debugger-script.cc [add] https://crrev.com/0832bae354f6001ba5b3647c42304bad1003bbaa/test/inspector/debugger/script-end-location-expected.txt [add] https://crrev.com/0832bae354f6001ba5b3647c42304bad1003bbaa/test/inspector/debugger/script-end-location.js [modify] https://crrev.com/0832bae354f6001ba5b3647c42304bad1003bbaa/test/inspector/debugger/script-on-after-compile-expected.txt [modify] https://crrev.com/0832bae354f6001ba5b3647c42304bad1003bbaa/test/inspector/runtime/es6-module-expected.txt
,
May 16 2017
There are still NeedsManualRebaseline lines in TestExpectations associated with this bug -- I think this issue should be marked as Fixed when the relevant tests are manually rebaselined (with Tools/Scripts/webkit-patch rebaseline <testname>) and the lines are removed from TestExpectations.
,
Jun 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3849230c86df1bc057340a396106c7c8f3ebac15 commit 3849230c86df1bc057340a396106c7c8f3ebac15 Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org> Date: Wed Jun 14 16:48:34 2017 [DevTools] reenable debugger/debugger-scripts TBR=dgozman@chromium.org Bug: chromium:698077 Change-Id: I42c1a6442449e5a518cd74ede24adc9804891acd Reviewed-on: https://chromium-review.googlesource.com/535523 Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#479420} [modify] https://crrev.com/3849230c86df1bc057340a396106c7c8f3ebac15/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2fc42d7a65359cb03ee10aa45dd087c55768aef2 commit 2fc42d7a65359cb03ee10aa45dd087c55768aef2 Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org> Date: Thu Jun 15 12:08:31 2017 [DevTools] reenable live-edit.html TBR=dgozman@chromium.org Bug: chromium:733588 , chromium:698077 Change-Id: I0d8c43c41a5224486d7d06c6685bbebbe25d9cf4 Reviewed-on: https://chromium-review.googlesource.com/536893 Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#479673} [modify] https://crrev.com/2fc42d7a65359cb03ee10aa45dd087c55768aef2/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/2fc42d7a65359cb03ee10aa45dd087c55768aef2/third_party/WebKit/LayoutTests/inspector/sources/debugger/live-edit-expected.txt [modify] https://crrev.com/2fc42d7a65359cb03ee10aa45dd087c55768aef2/third_party/WebKit/LayoutTests/inspector/sources/debugger/live-edit.html
,
Jul 11 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by lushnikov@chromium.org
, Mar 2 2017