Regression: Fonts are squished in UI and menus when font scale factor is > 1
Reported by
matthews...@gmail.com,
Mar 2 2017
|
||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36 Steps to reproduce the problem: 1. Launch Chrome and observe font on tab strip, wrench menu and context menus. 2. Adjust system font DPI to 144 (or 1.5 if your OS uses a scale factor). 3. Now observe font size on tab strip, wrench menu and context menus. What is the expected behavior? The font should not be squished; it should render properly as it did in earlier versions of Chrome. What went wrong? The font is squished together and looks odd. I first thought I was missing a system font that was now required by Chrome, but then I discovered a similar bug when scale factor was less than 1. I managed to isolate the bug to the system scale factor. Did this work before? N/A Chrome version: 56.0.2924.87 Channel: stable OS Version: Flash Version: Shockwave Flash 24.0 r0 Adjusting the scale factor is necessary on systems with HiDPI displays. Without this adjustment, the UI elements are tiny and difficult to interact with. Web pages in Chrome render just fine; this is only an issue for UI elements.
,
Mar 14 2017
Can you tell me your font settings? You can check it using gnome-tweak-tool. (Select "Fonts", then let me know what you have for "Interface", "Hinting", "anti aliasing" and "Scaling Factor").
,
Mar 14 2017
I'm not running GNOME but I'll do my best to answer based on MATE font settings:
Interface: Sans 10
Hinting: none
Anti aliasing: unknown ("Smoothing" set to subpixel)
Scaling factor: N/A, but DPI set to 144 (which is 1.5)
xrandr also shows a DPI of 144, which I've set manually.
,
Mar 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bcf3cc76c4dd7e474e6c458fcd5a8d288a6000f4 commit bcf3cc76c4dd7e474e6c458fcd5a8d288a6000f4 Author: oshima <oshima@chromium.org> Date: Wed Mar 15 08:52:15 2017 Update the scale factor for font param before querying the default font. The very first time the default font is queried may use 1.0 when dsf isn't 1.0. BUG= 698075 TEST=manual. Review-Url: https://codereview.chromium.org/2745223003 Cr-Commit-Position: refs/heads/master@{#457036} [modify] https://crrev.com/bcf3cc76c4dd7e474e6c458fcd5a8d288a6000f4/chrome/browser/ui/libgtkui/gtk_ui.cc
,
Mar 15 2017
,
Mar 16 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/556a50b785d1e2a7b948ddcb6a8d449ea6e7fe01 commit 556a50b785d1e2a7b948ddcb6a8d449ea6e7fe01 Author: Mitsuru Oshima <oshima@chromium.org> Date: Fri Mar 17 21:21:41 2017 Update the scale factor for font param before querying the default font. The very first time the default font is queried may use 1.0 when dsf isn't 1.0. BUG= 698075 TEST=manual. Review-Url: https://codereview.chromium.org/2745223003 Cr-Commit-Position: refs/heads/master@{#457036} (cherry picked from commit bcf3cc76c4dd7e474e6c458fcd5a8d288a6000f4) Review-Url: https://codereview.chromium.org/2760713002 . Cr-Commit-Position: refs/branch-heads/3029@{#277} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/556a50b785d1e2a7b948ddcb6a8d449ea6e7fe01/chrome/browser/ui/libgtkui/gtk_ui.cc
,
Mar 17 2017
,
Mar 22 2017
Tested on ubuntu 14.04 using chrome M58 #58.0.3029.33 and observed that no fonts are squished and is rendering properly. Attached screencast for reference. @oshima-- Could you please check attached screencast and confirm us if this is the expected result or if any steps missed from our end to verify the issue. Thanks!
,
Mar 22 2017
Yes, that's expected and correct behavior. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by osh...@chromium.org
, Mar 3 2017Status: Assigned (was: Unconfirmed)