New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 698067 link

Starred by 3 users
Status: Fixed
Owner:
█ lgar...@chromium.org
Last visit > 30 days ago
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug


Participants' hotlists:
HSTS-Preload


Sign in to add a comment

Merge HSTS preload list removals from M58 to M57

Project Member Reported by lgar...@chromium.org, Mar 2 2017 
This has happened regularly before.
- M54 -> M53 ( Issue 641449 )
- M53 -> M52 ( Issue 624953 )
- M52 -> M51 ( Issue 613292 )
- M51 -> M50 ( Issue 601561 )

We ran into an issue with M55 ( Issue 655854 ), but for M58 it's a clean merge without those complications. [1]

[1] https://chromium.googlesource.com/chromium/src.git/+log/a739725e13c66cd34417847fb9f4a08854a5902f

Requesting a merge of https://chromium.googlesource.com/chromium/src.git/+/a739725e13c66cd34417847fb9f4a08854a5902f [1] to Chrome 57, assuming it bakes successfully next Canary.
Project Member

Comment 1 by sheriffbot@chromium.org, Mar 2 2017

Labels: -Merge-Request-57 Hotlist-Merge-Review Merge-Review-57
This bug requires manual review: We are only 11 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by candr...@chromium.org, Mar 3 2017 

Please add the OSs that this is applicable to.  Thanks!

Comment 3 by lgar...@chromium.org, Mar 3 2017

Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows

Comment 4 by gov...@chromium.org, Mar 3 2017 

Please update Canary result here once it is baked. If it looks good in Canary, I will approve the merge. Thank you.

Comment 5 by gov...@chromium.org, Mar 3 2017 

How is this change looking in Canary? 
Pls note merge has to happen latest before 5:00 PM PT, Monday (03/06) in order to make into th Desktop final build cut. Thank you.

Comment 6 by lgar...@chromium.org, Mar 4 2017 

Looking good! The relevant entries are successfully removed.
Screen Shot 2017-03-03 at 18.50.57.png
27.4 KB View Download

Comment 7 by gov...@chromium.org, Mar 4 2017

Labels: -Merge-Review-57 Merge-Approved-57
Approving merge to M57 branch 2987 based on comment #6. Please merge before 5:00 PM PT, Monday so we can take it in for next week M57 Stable RC cut for Desktop. Thank you.

Comment 8 by lgar...@chromium.org, Mar 6 2017

Status: Fixed (was: Assigned)
Merged at https://bugs.chromium.org/p/chromium/issues/detail?id=655854#c18

Comment 9 by gov...@chromium.org, Mar 6 2017

Labels: -Merge-Approved-57 merge-merged-2987
Per comment #8, this is already merged to M57.
►

Sign in to add a comment