New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 698046 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

TaskSchedulerWorkerPoolHistogramTest.NumTasksBeforeDetach is flaky

Project Member Reported by liaoyuke@chromium.org, Mar 2 2017

Issue description

Summary: TaskSchedulerWorkerPoolHistogramTest.NumTasksBeforeDetach is flaky (was: TaskSchedulerWorkerPoolHistogramTest.NumTasksBeforeDetach)
Owner: robliao@chromium.org
Status: Assigned (was: Untriaged)
Could https://codereview.chromium.org/2712003002 be related?
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 2 2017

Labels: ReleaseBlock-Beta M-58 OS-iOS
Labels: -ReleaseBlock-Beta
Given that this has been disabled, I'm going to go ahead and remove the RB-Beta Flag.
Rob, RBB was here to signify that the bug needs to be reenabled before we release a beta. At least it is our process in iOS.
If you don't want to block the beta release, we should then reenable the test although it is flaky. The thing we should avoid is a disabled test that goes unnoticed.
Cc: cma...@chromium.org
+cmasso regarding RBB process and tracking this.

I don't know if we can impose our iOS process on this bug, but we should at least make sure we do anything else that needs to happen on disabled tests.
Labels: -M-58 ReleaseBlock-Beta M-59
This bug will need to be re-enabled before M59 branch point since we are branching M58 today. As described by lpromero@, this is how things work on iOS. Thanks!
This code resides in base and not iOS specific code. Does the iOS process still make sense for this? For what it's worth, the fix is currently in flight.
Components: Internals>TaskScheduler
Labels: -OS-iOS OS-All
Status: Fixed (was: Assigned)
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/404de72480129c6549041267a171a9b0f1f8189f

commit 404de72480129c6549041267a171a9b0f1f8189f
Author: robliao <robliao@chromium.org>
Date: Tue Mar 14 00:30:45 2017

Fix TaskSchedulerWorkerPoolHistogramTest.NumTasksBeforeDetach

This fix passes the pointer for the PlatformThreadRef to the task for
comparisons and actually gets the PlatformThreadRef from
PlatformThread::CurrentRef().

Previously, the test would race and pass by value. This meant that
if the previous task did not complete in time, it would pass the empty
reference. Since we were accidentally comparing against that, then the
test succeeded. When code ran slowly enough to set the value before
the next PostTask, then we would have the correct PlatformThreadRef,
but incorrectly compare it to the empty PlatformThreadRef, correctly
failing the test.

It's amazing that the tests passed in the first place!

BUG= 697697 

Review-Url: https://codereview.chromium.org/2729573004
Cr-Commit-Position: refs/heads/master@{#456558}

[modify] https://crrev.com/404de72480129c6549041267a171a9b0f1f8189f/base/task_scheduler/scheduler_worker_pool_impl_unittest.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Mar 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbad1aa8a39929e5b58cb07dcdd09d62e88dc679

commit fbad1aa8a39929e5b58cb07dcdd09d62e88dc679
Author: robliao <robliao@chromium.org>
Date: Wed Mar 15 20:05:29 2017

Remove Obsolete Comment from https://codereview.chromium.org/2729573004/

BUG= 698046 

TBR=gab@chromium.org
NOTRY=true
Comment only change.

Review-Url: https://codereview.chromium.org/2750103004
Cr-Commit-Position: refs/heads/master@{#457180}

[modify] https://crrev.com/fbad1aa8a39929e5b58cb07dcdd09d62e88dc679/base/task_scheduler/scheduler_worker_pool_impl_unittest.cc

Components: Tests>Disabled
Labels: Test-Disabled

Sign in to add a comment