New issue
Advanced search Search tips

Issue 698043 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 693114
issue 696006



Sign in to add a comment

Port SetLayoutForCurrentDisplays() to mash

Project Member Reported by sky@chromium.org, Mar 2 2017

Issue description

A number of tests use this to change the display layout. We need to get this working in mash so that the tests can work there. For tests we need not go to mus, only change the internal displays.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eca38d4605fa46a7822ca5522db352415d97eed4

commit eca38d4605fa46a7822ca5522db352415d97eed4
Author: sky <sky@chromium.org>
Date: Fri Mar 03 05:21:56 2017

chromeos: moves more ash tests to run on mash

And pointers to bugs for those that aren't moved to common.

BUG= 631103 , 633782 , 634994 , 648733 , 695887 , 696752 ,696754, 698016 , 698024 ,698032,698033, 698043 , 698049 ,698060,698085, 698092 ,698093, 698129 
TEST=test only changes
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2732573002
Cr-Commit-Position: refs/heads/master@{#454514}

[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/BUILD.gn
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/focus_cycler_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/sticky_keys/sticky_keys_overlay_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/system/overview/overview_button_tray_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/system/toast/toast_manager_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/system/web_notification/web_notification_tray_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/tooltips/tooltip_controller_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/wm/dock/docked_window_layout_manager_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/wm/dock/docked_window_resizer_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/wm/immersive_fullscreen_controller_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/wm/lock_state_controller_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/wm/toplevel_window_event_handler_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/wm/workspace/workspace_window_resizer_unittest.cc

Comment 2 by sky@chromium.org, Mar 7 2017

Blocking: 693114

Comment 3 by sky@chromium.org, Mar 29 2017

Labels: -Pri-3 mustash-2 Pri-2
Labels: mustash-display

Comment 5 by sky@chromium.org, Mar 29 2017

Blocking: 696006
Cc: kylec...@chromium.org
Owner: ----
Status: Available (was: Untriaged)
Cc: steve...@chromium.org
Labels: -mustash-2
Owner: jamescook@chromium.org
Status: Started (was: Available)
I can take a look at this. Steven, let me know if you're already working in this area.

Sample failures:
-ImmersiveFullscreenControllerTest.MouseEventsVerticalDisplayLayout
-ToplevelWindowEventHandlerTest.DragSnappedWindowToExternalDisplay

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8ac82712ee493fb2f0a4f1a3a8639613130d81a

commit f8ac82712ee493fb2f0a4f1a3a8639613130d81a
Author: James Cook <jamescook@chromium.org>
Date: Fri Nov 03 23:58:52 2017

cros: Clean up ash_unittests using SetLayoutForCurrentDisplays in --mash

SetLayoutForCurrentDisplays() works under mash. Re-enable tests that use
it. For the ones that still fail, disable via filter file and update
comment.

Bug:  698043 ,  637853 
Test: ash_unittests --mash
Change-Id: I401204ffdb31796fb4aa97a3d551a96c34846602
Reviewed-on: https://chromium-review.googlesource.com/754282
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513973}
[modify] https://crrev.com/f8ac82712ee493fb2f0a4f1a3a8639613130d81a/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/f8ac82712ee493fb2f0a4f1a3a8639613130d81a/ash/wm/workspace/workspace_window_resizer_unittest.cc
[modify] https://crrev.com/f8ac82712ee493fb2f0a4f1a3a8639613130d81a/testing/buildbot/filters/ash_unittests_mash.filter

Status: Fixed (was: Started)

Comment 10 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 11 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment