New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 698027 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature



Sign in to add a comment

Implement frame-centric Application pane design

Project Member Reported by eostroukhov@chromium.org, Mar 2 2017

Issue description

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f7c3a1ade6b01cb90a8648d1e4dbfeab14bd8a5

commit 8f7c3a1ade6b01cb90a8648d1e4dbfeab14bd8a5
Author: eostroukhov <eostroukhov@chromium.org>
Date: Wed Mar 22 21:00:10 2017

[DevTools] Separate old Application tab code

This CL moves "old" application tab code into a new class so the new
codebase could be built in parallel, allowing us to run experiment and
to port features gradually.

BUG= 698027 

Review-Url: https://codereview.chromium.org/2747123008
Cr-Commit-Position: refs/heads/master@{#458873}

[modify] https://crrev.com/8f7c3a1ade6b01cb90a8648d1e4dbfeab14bd8a5/third_party/WebKit/LayoutTests/http/tests/inspector/appcache/appcache-test.js
[modify] https://crrev.com/8f7c3a1ade6b01cb90a8648d1e4dbfeab14bd8a5/third_party/WebKit/LayoutTests/http/tests/inspector/cache-storage/cache-storage-test.js
[modify] https://crrev.com/8f7c3a1ade6b01cb90a8648d1e4dbfeab14bd8a5/third_party/WebKit/LayoutTests/http/tests/inspector/indexeddb/indexeddb-test.js
[modify] https://crrev.com/8f7c3a1ade6b01cb90a8648d1e4dbfeab14bd8a5/third_party/WebKit/LayoutTests/http/tests/inspector/indexeddb/resources-panel.html
[modify] https://crrev.com/8f7c3a1ade6b01cb90a8648d1e4dbfeab14bd8a5/third_party/WebKit/LayoutTests/http/tests/inspector/resource-tree/resource-tree-test.js
[modify] https://crrev.com/8f7c3a1ade6b01cb90a8648d1e4dbfeab14bd8a5/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-force-update-on-page-load.html
[modify] https://crrev.com/8f7c3a1ade6b01cb90a8648d1e4dbfeab14bd8a5/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-view.html
[modify] https://crrev.com/8f7c3a1ade6b01cb90a8648d1e4dbfeab14bd8a5/third_party/WebKit/LayoutTests/inspector/extensions/extensions-panel.html
[modify] https://crrev.com/8f7c3a1ade6b01cb90a8648d1e4dbfeab14bd8a5/third_party/WebKit/LayoutTests/inspector/reveal-objects.html
[modify] https://crrev.com/8f7c3a1ade6b01cb90a8648d1e4dbfeab14bd8a5/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/source-frame.html
[modify] https://crrev.com/8f7c3a1ade6b01cb90a8648d1e4dbfeab14bd8a5/third_party/WebKit/LayoutTests/inspector/storage-panel-dom-storage-update.html
[modify] https://crrev.com/8f7c3a1ade6b01cb90a8648d1e4dbfeab14bd8a5/third_party/WebKit/LayoutTests/inspector/storage-panel-dom-storage.html
[modify] https://crrev.com/8f7c3a1ade6b01cb90a8648d1e4dbfeab14bd8a5/third_party/WebKit/Source/devtools/BUILD.gn
[add] https://crrev.com/8f7c3a1ade6b01cb90a8648d1e4dbfeab14bd8a5/third_party/WebKit/Source/devtools/front_end/resources/ApplicationPanelSidebar.js
[modify] https://crrev.com/8f7c3a1ade6b01cb90a8648d1e4dbfeab14bd8a5/third_party/WebKit/Source/devtools/front_end/resources/ClearStorageView.js
[modify] https://crrev.com/8f7c3a1ade6b01cb90a8648d1e4dbfeab14bd8a5/third_party/WebKit/Source/devtools/front_end/resources/CookieItemsView.js
[modify] https://crrev.com/8f7c3a1ade6b01cb90a8648d1e4dbfeab14bd8a5/third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js
[modify] https://crrev.com/8f7c3a1ade6b01cb90a8648d1e4dbfeab14bd8a5/third_party/WebKit/Source/devtools/front_end/resources/module.json

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76c041dbcc4de828135d0af8c39256c4861b1a01

commit 76c041dbcc4de828135d0af8c39256c4861b1a01
Author: eostroukhov <eostroukhov@chromium.org>
Date: Thu Mar 30 16:57:42 2017

[DevTools] Filtered list enhancements

Some enhancements that are needed for the frames menu but also seem
useful for other clients of the FilteredListWidget.
  1. Selection is preserved while the filter string is being updated.
  2. Items are highlighted on hover. Provider is notified when mouse
     moves over the item.
  3. It is now possible to set the selection.

BUG= 698027 

Review-Url: https://codereview.chromium.org/2781863003
Cr-Commit-Position: refs/heads/master@{#460799}

[modify] https://crrev.com/76c041dbcc4de828135d0af8c39256c4861b1a01/third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js
[modify] https://crrev.com/76c041dbcc4de828135d0af8c39256c4861b1a01/third_party/WebKit/Source/devtools/front_end/quick_open/filteredListWidget.css

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bf970e99a9672baf4de427eb35dc6f3b5d0b3cf

commit 6bf970e99a9672baf4de427eb35dc6f3b5d0b3cf
Author: pfeldman <pfeldman@chromium.org>
Date: Fri Mar 31 21:53:14 2017

Revert of [DevTools] Filtered list enhancements (patchset #4 id:60001 of https://codereview.chromium.org/2781863003/ )

Reason for revert:
Breaks selection, don't think was necessary at first place!

Original issue's description:
> [DevTools] Filtered list enhancements
>
> Some enhancements that are needed for the frames menu but also seem
> useful for other clients of the FilteredListWidget.
>   1. Selection is preserved while the filter string is being updated.
>   2. Items are highlighted on hover. Provider is notified when mouse
>      moves over the item.
>   3. It is now possible to set the selection.
>
> BUG= 698027 
>
> Review-Url: https://codereview.chromium.org/2781863003
> Cr-Commit-Position: refs/heads/master@{#460799}
> Committed: https://chromium.googlesource.com/chromium/src/+/76c041dbcc4de828135d0af8c39256c4861b1a01

TBR=dgozman@chromium.org,caseq@chromium.org,eostroukhov@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 698027 

Review-Url: https://codereview.chromium.org/2793483002
Cr-Commit-Position: refs/heads/master@{#461239}

[modify] https://crrev.com/6bf970e99a9672baf4de427eb35dc6f3b5d0b3cf/third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js
[modify] https://crrev.com/6bf970e99a9672baf4de427eb35dc6f3b5d0b3cf/third_party/WebKit/Source/devtools/front_end/quick_open/filteredListWidget.css

Status: WontFix (was: Assigned)
This redesign had been scrapped.

Sign in to add a comment