New issue
Advanced search Search tips

Issue 698024 link

Starred by 4 users

Issue metadata

Status: WontFix
Owner:
Closed: Aug 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Implement unified desktop mode for mus+ash

Project Member Reported by sky@chromium.org, Mar 2 2017

Issue description

mus+ash needs to support this given classic chromeos supports it.
This will undoubtedly touch both mus and ash code.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eca38d4605fa46a7822ca5522db352415d97eed4

commit eca38d4605fa46a7822ca5522db352415d97eed4
Author: sky <sky@chromium.org>
Date: Fri Mar 03 05:21:56 2017

chromeos: moves more ash tests to run on mash

And pointers to bugs for those that aren't moved to common.

BUG= 631103 , 633782 , 634994 , 648733 , 695887 , 696752 ,696754, 698016 , 698024 ,698032,698033, 698043 , 698049 ,698060,698085, 698092 ,698093, 698129 
TEST=test only changes
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2732573002
Cr-Commit-Position: refs/heads/master@{#454514}

[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/BUILD.gn
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/focus_cycler_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/sticky_keys/sticky_keys_overlay_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/system/overview/overview_button_tray_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/system/toast/toast_manager_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/system/web_notification/web_notification_tray_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/tooltips/tooltip_controller_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/wm/dock/docked_window_layout_manager_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/wm/dock/docked_window_resizer_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/wm/immersive_fullscreen_controller_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/wm/lock_state_controller_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/wm/toplevel_window_event_handler_unittest.cc
[modify] https://crrev.com/eca38d4605fa46a7822ca5522db352415d97eed4/ash/wm/workspace/workspace_window_resizer_unittest.cc

Comment 2 by sky@chromium.org, Mar 27 2017

Labels: mustash-2
Labels: -Pri-2 Pri-3
This is --mash only. Lowering priority.
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d61d0d6c3f841834c09993b8805381fa6103b750

commit d61d0d6c3f841834c09993b8805381fa6103b750
Author: Mike Wasserman <msw@chromium.org>
Date: Mon Oct 16 20:35:55 2017

mash: Enable functioning unified mode tests.

These tests pass as-is locally; remove early returns.

Bug:  581462 ,  698024 
Change-Id: I8a0ba522331b805aa4a44a41262e3a35b5d734a8
Reviewed-on: https://chromium-review.googlesource.com/721567
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509157}
[modify] https://crrev.com/d61d0d6c3f841834c09993b8805381fa6103b750/ash/root_window_controller_unittest.cc
[modify] https://crrev.com/d61d0d6c3f841834c09993b8805381fa6103b750/ash/screen_util_unittest.cc
[modify] https://crrev.com/d61d0d6c3f841834c09993b8805381fa6103b750/ash/shelf/shelf_layout_manager_unittest.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3d820eedf2a287f50f9b01ab6ecd5971b224763

commit d3d820eedf2a287f50f9b01ab6ecd5971b224763
Author: Mike Wasserman <msw@chromium.org>
Date: Tue Oct 17 01:11:57 2017

mash: Enable functioning ToastManager tests

These tests pass as-is locally; remove early returns.

Bug:  698016 ,  698024 
Change-Id: I134f138fe68442754b709981a8f40090c750b659
Reviewed-on: https://chromium-review.googlesource.com/721580
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509201}
[modify] https://crrev.com/d3d820eedf2a287f50f9b01ab6ecd5971b224763/ash/system/toast/toast_manager_unittest.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5

commit d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5
Author: James Cook <jamescook@chromium.org>
Date: Fri Dec 08 00:53:39 2017

cros: Clean up mash early-exits in ash_unittests --mash

Our policy for mash is to disable via filter file unless the test is
never expected to work under mash.

Also re-enable a bunch of tests that now pass under mash, likely due to
the display manager work done several months ago.

Bug: 695556,  696752 ,  698024 ,  696006 ,  581462 ,  698129 ,  726838 
Test: ash_unittests for classic, --mus and --mash
Change-Id: Ia192d77b107c2a9f93ab4e0416b2f4fdb63b3f8d
Reviewed-on: https://chromium-review.googlesource.com/815874
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522655}
[modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/app_list/app_list_presenter_delegate_unittest.cc
[modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/autoclick/autoclick_unittest.cc
[modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/display/display_configuration_controller_unittest.cc
[delete] https://crrev.com/ef9ad27b1a663fa6e434fb32a03ca3275ea79134/ash/mus/window_manager_unittest.cc
[modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/root_window_controller_unittest.cc
[modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/rotator/screen_rotation_animator_unittest.cc
[modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/screen_util_unittest.cc
[modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/shelf/shelf_window_watcher_unittest.cc
[modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/shell_unittest.cc
[modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/sticky_keys/sticky_keys_overlay_unittest.cc
[modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/system/overview/overview_button_tray_unittest.cc
[modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc
[modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/system/web_notification/web_notification_tray_unittest.cc
[modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/tooltips/tooltip_controller_unittest.cc
[modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/wallpaper/wallpaper_controller_unittest.cc
[modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/window_manager_common_unittests.cc
[modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/wm/panels/panel_layout_manager_unittest.cc
[modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/wm/window_manager_unittest.cc
[modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/wm/workspace/workspace_event_handler_unittest.cc
[modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/ash/wm/workspace/workspace_layout_manager_unittest.cc
[modify] https://crrev.com/d7ea4d3d17ed7caa15537e0fb80ae09fe6b2e4d5/testing/buildbot/filters/ash_unittests_mash.filter

Components: -Internals>MUS Internals>Services>WindowService
Components: -Internals>Services>WindowService Internals>Services>Ash
Labels: -Proj-Mustash-Mash
Labels: -Proj-Mustash-Mus Proj-Mustash
Migrating Proj-Mustash-Mus to components Internals>Services>WindowService and Internals>Services>Ash

Cc: msw@chromium.org
Labels: -Proj-Mustash -mustash-2 Proj-Mash-MultiProcess
+msw

Is this still an issue after the WS2 conversion?

Status: WontFix (was: Assigned)
We no longer have separate display management, so there isn't anything special to do here.

Sign in to add a comment