Issue 698020 link

Starred by 3 users

Issue metadata

Status:	Fixed
Owner:	█ dim...@chromium.org Last visit > 30 days ago
Closed:	Apr 2017
Cc:	fgor...@chromium.org dtrainor@chromium.org
Components:	UI>Browser>Downloads UI>Browser>Offline
EstimatedDays:	----
NextAction:	----
OS:	Android
Pri:	2
Type:	Bug
Hotlist-Merge-Approved M-58 merge-merged-3029

Blocking:
issue 699766

Download Notifications: When downloading offline page, the bytes loaded stuck at 0

Project Member Reported by dim...@chromium.org, Mar 2 2017

Issue description

Canary 58.0.3028.0
branch position 454140

See attached screenshot. In the Download Home, the indication of bytes loaded works fine.

If fix is simple, we need to merge to M58.

	Screenshot_20170302-111731.png 307 KB View Download

Comment 1 by dtrainor@chromium.org, Mar 7 2017

Cc: dtrainor@chromium.org fgor...@chromium.org
Owner: dim...@chromium.org
Status: Assigned (was: Untriaged)

dimich@ is this a duplicate?  Reassigning to you to triage.

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e2f6cb4e64a3d6c251e9aa782927cffb829a5d3

commit 0e2f6cb4e64a3d6c251e9aa782927cffb829a5d3
Author: dimich <dimich@chromium.org>
Date: Wed Mar 08 17:44:00 2017

Fix the Download Notifications for Offline Pages to indicate bytes loaded.

This wires the UpdateProgress call from PrerenderingOffliner via DownloadUIAdapter to the DownloadNotifyingObserver. As a result, the Android notifications about ongoing Offline Page downloads start to be updated with a real byte count.

BUG= 698020 

Review-Url: https://codereview.chromium.org/2736843002
Cr-Commit-Position: refs/heads/master@{#455486}

[modify] https://crrev.com/0e2f6cb4e64a3d6c251e9aa782927cffb829a5d3/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java
[modify] https://crrev.com/0e2f6cb4e64a3d6c251e9aa782927cffb829a5d3/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
[modify] https://crrev.com/0e2f6cb4e64a3d6c251e9aa782927cffb829a5d3/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageNotificationBridge.java
[modify] https://crrev.com/0e2f6cb4e64a3d6c251e9aa782927cffb829a5d3/chrome/browser/android/offline_pages/background_loader_offliner.cc
[modify] https://crrev.com/0e2f6cb4e64a3d6c251e9aa782927cffb829a5d3/chrome/browser/android/offline_pages/background_loader_offliner.h
[modify] https://crrev.com/0e2f6cb4e64a3d6c251e9aa782927cffb829a5d3/chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc
[modify] https://crrev.com/0e2f6cb4e64a3d6c251e9aa782927cffb829a5d3/chrome/browser/android/offline_pages/downloads/offline_page_notification_bridge.cc
[modify] https://crrev.com/0e2f6cb4e64a3d6c251e9aa782927cffb829a5d3/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc
[modify] https://crrev.com/0e2f6cb4e64a3d6c251e9aa782927cffb829a5d3/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.h
[modify] https://crrev.com/0e2f6cb4e64a3d6c251e9aa782927cffb829a5d3/chrome/browser/android/offline_pages/prerendering_offliner.cc
[modify] https://crrev.com/0e2f6cb4e64a3d6c251e9aa782927cffb829a5d3/chrome/browser/android/offline_pages/prerendering_offliner.h
[modify] https://crrev.com/0e2f6cb4e64a3d6c251e9aa782927cffb829a5d3/chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc
[modify] https://crrev.com/0e2f6cb4e64a3d6c251e9aa782927cffb829a5d3/components/offline_pages/core/background/cleanup_task_unittest.cc
[modify] https://crrev.com/0e2f6cb4e64a3d6c251e9aa782927cffb829a5d3/components/offline_pages/core/background/offliner.h
[modify] https://crrev.com/0e2f6cb4e64a3d6c251e9aa782927cffb829a5d3/components/offline_pages/core/background/offliner_stub.cc
[modify] https://crrev.com/0e2f6cb4e64a3d6c251e9aa782927cffb829a5d3/components/offline_pages/core/background/offliner_stub.h
[modify] https://crrev.com/0e2f6cb4e64a3d6c251e9aa782927cffb829a5d3/components/offline_pages/core/background/pick_request_task_unittest.cc
[modify] https://crrev.com/0e2f6cb4e64a3d6c251e9aa782927cffb829a5d3/components/offline_pages/core/background/request_coordinator.cc
[modify] https://crrev.com/0e2f6cb4e64a3d6c251e9aa782927cffb829a5d3/components/offline_pages/core/background/request_coordinator.h
[modify] https://crrev.com/0e2f6cb4e64a3d6c251e9aa782927cffb829a5d3/components/offline_pages/core/background/request_coordinator_unittest.cc
[modify] https://crrev.com/0e2f6cb4e64a3d6c251e9aa782927cffb829a5d3/components/offline_pages/core/background/request_notifier.h
[modify] https://crrev.com/0e2f6cb4e64a3d6c251e9aa782927cffb829a5d3/components/offline_pages/core/background/request_queue_unittest.cc
[modify] https://crrev.com/0e2f6cb4e64a3d6c251e9aa782927cffb829a5d3/components/offline_pages/core/downloads/download_notifying_observer.cc
[modify] https://crrev.com/0e2f6cb4e64a3d6c251e9aa782927cffb829a5d3/components/offline_pages/core/downloads/download_notifying_observer.h
[modify] https://crrev.com/0e2f6cb4e64a3d6c251e9aa782927cffb829a5d3/components/offline_pages/core/downloads/download_ui_adapter.cc
[modify] https://crrev.com/0e2f6cb4e64a3d6c251e9aa782927cffb829a5d3/components/offline_pages/core/downloads/download_ui_adapter.h
[modify] https://crrev.com/0e2f6cb4e64a3d6c251e9aa782927cffb829a5d3/components/offline_pages/core/downloads/download_ui_adapter_unittest.cc

Comment 3 by dim...@chromium.org, Mar 8 2017

Issue 697987 has been merged into this issue.

Comment 4 by dim...@chromium.org, Mar 9 2017

Blocking: 699766
Labels: Merge-Request-58

This is a fix for notifications and would probably block the M58 launch reviewed in bug 699766. Despite many files, the change is a adding a simple method to hook up the bytes update to existing UI, not risky. Requesting merge.

Project Member

Comment 5 by sheriffbot@chromium.org, Mar 9 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58

Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 10 2017

Labels: -merge-approved-58 merge-merged-3029

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5272c36578a4bca85626b8f27eeea4d790749383

commit 5272c36578a4bca85626b8f27eeea4d790749383
Author: Dmitry Titov <dimich@chromium.org>
Date: Fri Mar 10 00:21:58 2017

Fix the Download Notifications for Offline Pages to indicate bytes loaded.

This wires the UpdateProgress call from PrerenderingOffliner via DownloadUIAdapter to the DownloadNotifyingObserver. As a result, the Android notifications about ongoing Offline Page downloads start to be updated with a real byte count.

BUG= 698020 

Review-Url: https://codereview.chromium.org/2736843002
Cr-Commit-Position: refs/heads/master@{#455486}
(cherry picked from commit 0e2f6cb4e64a3d6c251e9aa782927cffb829a5d3)

Review-Url: https://codereview.chromium.org/2742833004 .
Cr-Commit-Position: refs/branch-heads/3029@{#101}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/5272c36578a4bca85626b8f27eeea4d790749383/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadItem.java
[modify] https://crrev.com/5272c36578a4bca85626b8f27eeea4d790749383/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
[modify] https://crrev.com/5272c36578a4bca85626b8f27eeea4d790749383/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageNotificationBridge.java
[modify] https://crrev.com/5272c36578a4bca85626b8f27eeea4d790749383/chrome/browser/android/offline_pages/background_loader_offliner.cc
[modify] https://crrev.com/5272c36578a4bca85626b8f27eeea4d790749383/chrome/browser/android/offline_pages/background_loader_offliner.h
[modify] https://crrev.com/5272c36578a4bca85626b8f27eeea4d790749383/chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc
[modify] https://crrev.com/5272c36578a4bca85626b8f27eeea4d790749383/chrome/browser/android/offline_pages/downloads/offline_page_notification_bridge.cc
[modify] https://crrev.com/5272c36578a4bca85626b8f27eeea4d790749383/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc
[modify] https://crrev.com/5272c36578a4bca85626b8f27eeea4d790749383/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.h
[modify] https://crrev.com/5272c36578a4bca85626b8f27eeea4d790749383/chrome/browser/android/offline_pages/prerendering_offliner.cc
[modify] https://crrev.com/5272c36578a4bca85626b8f27eeea4d790749383/chrome/browser/android/offline_pages/prerendering_offliner.h
[modify] https://crrev.com/5272c36578a4bca85626b8f27eeea4d790749383/chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc
[modify] https://crrev.com/5272c36578a4bca85626b8f27eeea4d790749383/components/offline_pages/core/background/cleanup_task_unittest.cc
[modify] https://crrev.com/5272c36578a4bca85626b8f27eeea4d790749383/components/offline_pages/core/background/offliner.h
[modify] https://crrev.com/5272c36578a4bca85626b8f27eeea4d790749383/components/offline_pages/core/background/offliner_stub.cc
[modify] https://crrev.com/5272c36578a4bca85626b8f27eeea4d790749383/components/offline_pages/core/background/offliner_stub.h
[modify] https://crrev.com/5272c36578a4bca85626b8f27eeea4d790749383/components/offline_pages/core/background/pick_request_task_unittest.cc
[modify] https://crrev.com/5272c36578a4bca85626b8f27eeea4d790749383/components/offline_pages/core/background/request_coordinator.cc
[modify] https://crrev.com/5272c36578a4bca85626b8f27eeea4d790749383/components/offline_pages/core/background/request_coordinator.h
[modify] https://crrev.com/5272c36578a4bca85626b8f27eeea4d790749383/components/offline_pages/core/background/request_coordinator_unittest.cc
[modify] https://crrev.com/5272c36578a4bca85626b8f27eeea4d790749383/components/offline_pages/core/background/request_notifier.h
[modify] https://crrev.com/5272c36578a4bca85626b8f27eeea4d790749383/components/offline_pages/core/background/request_queue_unittest.cc
[modify] https://crrev.com/5272c36578a4bca85626b8f27eeea4d790749383/components/offline_pages/core/downloads/download_notifying_observer.cc
[modify] https://crrev.com/5272c36578a4bca85626b8f27eeea4d790749383/components/offline_pages/core/downloads/download_notifying_observer.h
[modify] https://crrev.com/5272c36578a4bca85626b8f27eeea4d790749383/components/offline_pages/core/downloads/download_ui_adapter.cc
[modify] https://crrev.com/5272c36578a4bca85626b8f27eeea4d790749383/components/offline_pages/core/downloads/download_ui_adapter.h
[modify] https://crrev.com/5272c36578a4bca85626b8f27eeea4d790749383/components/offline_pages/core/downloads/download_ui_adapter_unittest.cc

Comment 7 by dtrainor@chromium.org, Mar 29 2017

Is this still open or can we close it out?  Looks like the main CL was merged?

Comment 8 by jiewu@chromium.org, Mar 29 2017

I verified and it is working now. 

I am OK to close this bug.

Comment 9 by dah...@chromium.org, Apr 6 2017

Status: Fixed (was: Assigned)

►

Issue 698020 link

Issue metadata

Download Notifications: When downloading offline page, the bytes loaded stuck at 0

Issue description

Comment 1 by dtrainor@chromium.org, Mar 7 2017

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Mar 8 2017

Comment 2 Deleted

Comment 3 by dim...@chromium.org, Mar 8 2017

Comment 3 Deleted

Comment 4 by dim...@chromium.org, Mar 9 2017

Comment 4 Deleted

Comment 5 by sheriffbot@chromium.org, Mar 9 2017

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Mar 10 2017

Comment 6 Deleted

Comment 7 by dtrainor@chromium.org, Mar 29 2017

Comment 7 Deleted

Comment 8 by jiewu@chromium.org, Mar 29 2017

Comment 8 Deleted

Comment 9 by dah...@chromium.org, Apr 6 2017

Comment 9 Deleted

Sign in to add a comment