New issue
Advanced search Search tips

Issue 698015 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: ----

Blocking:
issue 560466



Sign in to add a comment

Get rid of native functions in ChromeApplication

Project Member Reported by estevenson@chromium.org, Mar 2 2017

Issue description

They are:
  * nativeRemoveSessionCookies
  * nativeGetBrowserUserAgent
  * nativeFlushPersistentData

We should move their callers out of ChromeApplication as well.

 
Cc: estevenson@chromium.org
Owner: hua...@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e1e1bf996e46ad8b271b3b3ed063667c1d756bb

commit 0e1e1bf996e46ad8b271b3b3ed063667c1d756bb
Author: Samuel Huang <huangs@chromium.org>
Date: Fri Jul 28 23:07:43 2017

[Clank] Move nativeRemoveSessionCookies and nativeFlushPersistentData out of ChromeApplication.

This is part of the effort to remove ChromeApplication. Now
both functions are moved to a new class
org.chromium.chrome.browser.profiles.ProfileManagerUtils.

Bug:  698015 
Change-Id: I603f3a4bd83d440ff60b7eb850c0240315537da4
Reviewed-on: https://chromium-review.googlesource.com/591748
Commit-Queue: Samuel Huang <huangs@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490535}
[modify] https://crrev.com/0e1e1bf996e46ad8b271b3b3ed063667c1d756bb/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivitySessionTracker.java
[modify] https://crrev.com/0e1e1bf996e46ad8b271b3b3ed063667c1d756bb/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java
[modify] https://crrev.com/0e1e1bf996e46ad8b271b3b3ed063667c1d756bb/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java
[modify] https://crrev.com/0e1e1bf996e46ad8b271b3b3ed063667c1d756bb/chrome/android/java/src/org/chromium/chrome/browser/init/ProcessInitializationHandler.java
[modify] https://crrev.com/0e1e1bf996e46ad8b271b3b3ed063667c1d756bb/chrome/android/java/src/org/chromium/chrome/browser/preferences/Preferences.java
[add] https://crrev.com/0e1e1bf996e46ad8b271b3b3ed063667c1d756bb/chrome/android/java/src/org/chromium/chrome/browser/profiles/ProfileManagerUtils.java
[modify] https://crrev.com/0e1e1bf996e46ad8b271b3b3ed063667c1d756bb/chrome/android/java_sources.gni
[modify] https://crrev.com/0e1e1bf996e46ad8b271b3b3ed063667c1d756bb/chrome/browser/BUILD.gn
[modify] https://crrev.com/0e1e1bf996e46ad8b271b3b3ed063667c1d756bb/chrome/browser/android/chrome_application.cc
[add] https://crrev.com/0e1e1bf996e46ad8b271b3b3ed063667c1d756bb/chrome/browser/android/profiles/profile_manager_utils.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87ac6fa2690f3f61b5d4b8457738b1370590c5b0

commit 87ac6fa2690f3f61b5d4b8457738b1370590c5b0
Author: Samuel Huang <huangs@chromium.org>
Date: Mon Jul 31 18:09:15 2017

[Clank] Move nativeGetBrowserUserAgent() out of ChromeApplication.

This is part of the effort to remove ChromeApplication. Now
nativeGetBrowserUserAgent() is moved to a new class
org.chromium.chrome.browser.content.ContentUtils.

Bug:  698015 
Change-Id: I22d848f484d81bb13bc8ba065ff9bda2ed02d16d
Reviewed-on: https://chromium-review.googlesource.com/585630
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490784}
[modify] https://crrev.com/87ac6fa2690f3f61b5d4b8457738b1370590c5b0/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java
[add] https://crrev.com/87ac6fa2690f3f61b5d4b8457738b1370590c5b0/chrome/android/java/src/org/chromium/chrome/browser/content/ContentUtils.java
[modify] https://crrev.com/87ac6fa2690f3f61b5d4b8457738b1370590c5b0/chrome/android/java/src/org/chromium/chrome/browser/download/OMADownloadHandler.java
[modify] https://crrev.com/87ac6fa2690f3f61b5d4b8457738b1370590c5b0/chrome/android/java_sources.gni
[modify] https://crrev.com/87ac6fa2690f3f61b5d4b8457738b1370590c5b0/chrome/browser/BUILD.gn
[delete] https://crrev.com/32eb2f87e06ec377f34f706120617225078cfe64/chrome/browser/android/chrome_application.cc
[delete] https://crrev.com/32eb2f87e06ec377f34f706120617225078cfe64/chrome/browser/android/chrome_application.h
[add] https://crrev.com/87ac6fa2690f3f61b5d4b8457738b1370590c5b0/chrome/browser/android/content/content_utils.cc

Status: Fixed (was: Assigned)

Sign in to add a comment