New issue
Advanced search Search tips

Issue 698012 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocking:
issue 680153
issue 698011



Sign in to add a comment

Show unified build indication on the welcome screen

Project Member Reported by sjg@chromium.org, Mar 2 2017

Issue description

/etc/lsb_release should have some indication of the models supported by the build.
 

Comment 1 by sjg@chromium.org, Mar 2 2017

Blocking: 680153

Comment 2 by sjg@chromium.org, Mar 14 2017

Blocking: 698011
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/8d8e38b1145524ece55cbc49f088c41d98f8e094

commit 8d8e38b1145524ece55cbc49f088c41d98f8e094
Author: Simon Glass <sjg@chromium.org>
Date: Sat Apr 01 22:39:27 2017

cros_set_lsb_release: Show unified build information

With unified builds we want to record the supported models. Adjust the
script to support setting two variables: one to indicate whether this is
a unified build and one to list the models supported.

BUG= chromium:698012 
TEST=Manual:
~/cosarm/chromite/bin/cros_set_lsb_release  --board reef --sysroot ~/cosarm/chroot/build/reef --version 123
~/cosarm/chromite/bin/cros_set_lsb_release --models reef:pyro:snappy --board reef --sysroot ~/cosarm/chroot/build/reef --version 123
cat ~/cosarm/chroot/build/reef/etc/lsb-release

Signed-off-by: Simon Glass <sjg@chromium.org>

Change-Id: Iea758f93932d42fe0bb72235dccb3880ba2a3307
Reviewed-on: https://chromium-review.googlesource.com/448846
Commit-Ready: Simon Glass <sjg@chromium.org>
Tested-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/8d8e38b1145524ece55cbc49f088c41d98f8e094/scripts/cros_set_lsb_release.py

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosutils/+/973f6404bf95387e2828cf5e0f86c2e9a5889863

commit 973f6404bf95387e2828cf5e0f86c2e9a5889863
Author: Simon Glass <sjg@chromium.org>
Date: Wed Apr 12 23:07:57 2017

build_image: Include a list of models in unified builds

When unified builds we want to include a list of models for display on the
login screen if enabled. Update the

BUG= chromium:698012 
TEST=Manual:
USE=pcserial ./build_image --board=reef --noenable_rootfs_verification dev \
   --enable_serial ttyS0 dev
Boot it on reef in dev mode and see that the message is displayed on the
login screen.

Change-Id: I4017dd30092eca406985034235ce23ddd0907f44
Reviewed-on: https://chromium-review.googlesource.com/450783
Commit-Ready: Simon Glass <sjg@chromium.org>
Tested-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/973f6404bf95387e2828cf5e0f86c2e9a5889863/build_library/base_image_util.sh

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosutils/+/973f6404bf95387e2828cf5e0f86c2e9a5889863

commit 973f6404bf95387e2828cf5e0f86c2e9a5889863
Author: Simon Glass <sjg@chromium.org>
Date: Wed Apr 12 23:07:57 2017

build_image: Include a list of models in unified builds

When unified builds we want to include a list of models for display on the
login screen if enabled. Update the

BUG= chromium:698012 
TEST=Manual:
USE=pcserial ./build_image --board=reef --noenable_rootfs_verification dev \
   --enable_serial ttyS0 dev
Boot it on reef in dev mode and see that the message is displayed on the
login screen.

Change-Id: I4017dd30092eca406985034235ce23ddd0907f44
Reviewed-on: https://chromium-review.googlesource.com/450783
Commit-Ready: Simon Glass <sjg@chromium.org>
Tested-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/973f6404bf95387e2828cf5e0f86c2e9a5889863/build_library/base_image_util.sh

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosutils/+/973f6404bf95387e2828cf5e0f86c2e9a5889863

commit 973f6404bf95387e2828cf5e0f86c2e9a5889863
Author: Simon Glass <sjg@chromium.org>
Date: Wed Apr 12 23:07:57 2017

build_image: Include a list of models in unified builds

When unified builds we want to include a list of models for display on the
login screen if enabled. Update the

BUG= chromium:698012 
TEST=Manual:
USE=pcserial ./build_image --board=reef --noenable_rootfs_verification dev \
   --enable_serial ttyS0 dev
Boot it on reef in dev mode and see that the message is displayed on the
login screen.

Change-Id: I4017dd30092eca406985034235ce23ddd0907f44
Reviewed-on: https://chromium-review.googlesource.com/450783
Commit-Ready: Simon Glass <sjg@chromium.org>
Tested-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/973f6404bf95387e2828cf5e0f86c2e9a5889863/build_library/base_image_util.sh

Comment 7 by sjg@chromium.org, Apr 13 2017

Status: Started (was: Available)

Comment 8 by sjg@chromium.org, Apr 13 2017

Status: Fixed (was: Started)

Sign in to add a comment