New issue
Advanced search Search tips

Issue 698009 link

Starred by 2 users
Status: Fixed
Owner:
estevenson@chromium.org
Closed: Mar 2017
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: ----

Blocking:
issue 560466



Sign in to add a comment

Get rid of @CalledByNative functions in ChromeApplication

Project Member Reported by estevenson@chromium.org, Mar 2 2017 
@CalledByNative:
  * showAutofillSettings
  * showPasswordSettings
  * areParentalControlsEnabled
  * openClearBrowsingData

They pretty much just call a static method on another class - I'm assuming they were put in ChromeApplication in the first place because it was easier than creating the JNI bindings separately.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a85c276d44c938ac979097bc5c73bf4304a92951

commit a85c276d44c938ac979097bc5c73bf4304a92951
Author: estevenson <estevenson@chromium.org>
Date: Fri Mar 24 19:27:52 2017

Move showAutofillSettings to PreferencesLauncher.

As part of trimming ChromeApplication, this CL moves
showAutofillSettings to PreferencesLauncher and creates the necessary
native wrapper.

BUG= 698009 

Review-Url: https://codereview.chromium.org/2763133002
Cr-Commit-Position: refs/heads/master@{#459519}

[modify] https://crrev.com/a85c276d44c938ac979097bc5c73bf4304a92951/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java
[modify] https://crrev.com/a85c276d44c938ac979097bc5c73bf4304a92951/chrome/android/java/src/org/chromium/chrome/browser/preferences/PreferencesLauncher.java
[modify] https://crrev.com/a85c276d44c938ac979097bc5c73bf4304a92951/chrome/browser/BUILD.gn
[modify] https://crrev.com/a85c276d44c938ac979097bc5c73bf4304a92951/chrome/browser/android/chrome_application.cc
[modify] https://crrev.com/a85c276d44c938ac979097bc5c73bf4304a92951/chrome/browser/android/chrome_application.h
[add] https://crrev.com/a85c276d44c938ac979097bc5c73bf4304a92951/chrome/browser/android/preferences/preferences_launcher.cc
[add] https://crrev.com/a85c276d44c938ac979097bc5c73bf4304a92951/chrome/browser/android/preferences/preferences_launcher.h
[modify] https://crrev.com/a85c276d44c938ac979097bc5c73bf4304a92951/chrome/browser/ui/autofill/chrome_autofill_client.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb80fc5be2e9a107a6c1f47d3a6ccc0e4391a91a

commit cb80fc5be2e9a107a6c1f47d3a6ccc0e4391a91a
Author: estevenson <estevenson@chromium.org>
Date: Tue Mar 28 16:50:57 2017

Move remaining @CalledByNative methods out of ChromeApplication.

This CL moves showPasswordSettings, areParentalControlsEnabled, and
openClearBrowsingData into more fitting locations.

BUG= 698009 

Review-Url: https://codereview.chromium.org/2768023002
Cr-Commit-Position: refs/heads/master@{#460132}

[modify] https://crrev.com/cb80fc5be2e9a107a6c1f47d3a6ccc0e4391a91a/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java
[modify] https://crrev.com/cb80fc5be2e9a107a6c1f47d3a6ccc0e4391a91a/chrome/android/java/src/org/chromium/chrome/browser/partnercustomizations/PartnerBrowserCustomizations.java
[modify] https://crrev.com/cb80fc5be2e9a107a6c1f47d3a6ccc0e4391a91a/chrome/android/java/src/org/chromium/chrome/browser/preferences/PreferencesLauncher.java
[modify] https://crrev.com/cb80fc5be2e9a107a6c1f47d3a6ccc0e4391a91a/chrome/browser/BUILD.gn
[modify] https://crrev.com/cb80fc5be2e9a107a6c1f47d3a6ccc0e4391a91a/chrome/browser/android/chrome_application.cc
[modify] https://crrev.com/cb80fc5be2e9a107a6c1f47d3a6ccc0e4391a91a/chrome/browser/android/chrome_application.h
[add] https://crrev.com/cb80fc5be2e9a107a6c1f47d3a6ccc0e4391a91a/chrome/browser/android/partner_browser_customizations.cc
[add] https://crrev.com/cb80fc5be2e9a107a6c1f47d3a6ccc0e4391a91a/chrome/browser/android/partner_browser_customizations.h
[modify] https://crrev.com/cb80fc5be2e9a107a6c1f47d3a6ccc0e4391a91a/chrome/browser/android/preferences/preferences_launcher.cc
[modify] https://crrev.com/cb80fc5be2e9a107a6c1f47d3a6ccc0e4391a91a/chrome/browser/android/preferences/preferences_launcher.h
[modify] https://crrev.com/cb80fc5be2e9a107a6c1f47d3a6ccc0e4391a91a/chrome/browser/password_manager/generated_password_saved_infobar_delegate_android.cc
[modify] https://crrev.com/cb80fc5be2e9a107a6c1f47d3a6ccc0e4391a91a/chrome/browser/prefs/incognito_mode_prefs.cc
[modify] https://crrev.com/cb80fc5be2e9a107a6c1f47d3a6ccc0e4391a91a/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc
[modify] https://crrev.com/cb80fc5be2e9a107a6c1f47d3a6ccc0e4391a91a/chrome/browser/ui/webui/browsing_history_handler.cc
[modify] https://crrev.com/cb80fc5be2e9a107a6c1f47d3a6ccc0e4391a91a/chrome/test/android/unit_tests_apk/src/org/chromium/chrome/unit_tests_apk/ChromeNativeTestApplication.java

Comment 3 by estevenson@chromium.org, Mar 28 2017

Status: Fixed (was: Available)
►

Sign in to add a comment