MD Settings: Internet details: Manual proxy toggle misaligned |
||||
Issue descriptionAfter switching from checkboxes to toggbles the manual proxy toggle is misaligned. There may be other artifacts of the conversion, we need to audit the page UI.
,
Mar 2 2017
,
Mar 3 2017
yeah, i mentioned this to you while flipping checkboxes -> toggles, that this UI needed a touch up
,
Mar 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4fcf5f1ca0a74ac656f3db33c9073c8b4e4dd7fc commit 4fcf5f1ca0a74ac656f3db33c9073c8b4e4dd7fc Author: stevenjb <stevenjb@chromium.org> Date: Mon Mar 06 20:08:56 2017 MD Settings: Internet details: Fix proxy toggle and polish This CL: * Moves the 'Use same proxy for all protocols' into a separate settings-box and removes the custom formatting * Uses more standard vars for spacing BUG= 698008 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2723403004 Cr-Commit-Position: refs/heads/master@{#454931} [modify] https://crrev.com/4fcf5f1ca0a74ac656f3db33c9073c8b4e4dd7fc/chrome/browser/resources/settings/internet_page/internet_detail_page.html [modify] https://crrev.com/4fcf5f1ca0a74ac656f3db33c9073c8b4e4dd7fc/chrome/browser/resources/settings/internet_page/network_property_list.html [modify] https://crrev.com/4fcf5f1ca0a74ac656f3db33c9073c8b4e4dd7fc/chrome/browser/resources/settings/internet_page/network_proxy.html [modify] https://crrev.com/4fcf5f1ca0a74ac656f3db33c9073c8b4e4dd7fc/ui/webui/resources/cr_elements/policy/cr_policy_network_indicator.html
,
Mar 6 2017
,
May 9 2017
9460.30.0, 59.0.3071.41 |
||||
►
Sign in to add a comment |
||||
Comment 1 by steve...@chromium.org
, Mar 2 2017