Add ability to control keyboard backlight to backlight_dbus_tool
Reported by
nath...@lenovo.corp-partner.google.com,
Mar 2 2017
|
|||
Issue descriptionThe backlight_dbus_tool test tool is useful for controlling the screen backlight from the command line. It's trivial to add the ability to control the keyboard backlight too, and I needed the code, so I did it. What went wrong? Nothing. Everything's fine. How are you?
,
Mar 20 2017
Just for debugging. I made the change for testing purposes, so since I already made the code changes I figured I'd check them in just in case they were helpful for someone else.
,
Mar 20 2017
Thanks, sounds good!
,
Mar 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/64e02c32d884c258fa6c0bd116da8a04ac1cd245 commit 64e02c32d884c258fa6c0bd116da8a04ac1cd245 Author: Nathan Baker <nathanb@lenovo-chrome.com> Date: Tue Mar 21 15:50:10 2017 power: Modify dbus tool to control kb backlight BUG= chromium:697988 The backlight_dbus_tool is used to control the screen backlight intensity from the command line. As the keyboard backlight uses a similar methodology and I needed a command-line way to manipulate the keyboard backlight, it seemed like a reasonable place to add this functionality. TEST=Built and ran command-line tool Change-Id: Ib55983afb51eede4066a21c0e4de6a3084581a39 Reviewed-on: https://chromium-review.googlesource.com/448856 Commit-Ready: Nathan Baker <nathanb@lenovo-chrome.com> Tested-by: Nathan Baker <nathanb@lenovo-chrome.com> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/64e02c32d884c258fa6c0bd116da8a04ac1cd245/power_manager/tools/backlight_dbus_tool.cc
,
Mar 21 2017
,
May 19 2017
Verified in Chrome OS 9565.0.0;60.0.3102.0. |
|||
►
Sign in to add a comment |
|||
Comment 1 by derat@chromium.org
, Mar 20 2017Status: Started (was: Unconfirmed)