New issue
Advanced search Search tips

Issue 697978 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Dec 7
Cc:
Components:
EstimatedDays: 1
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 694911



Sign in to add a comment

Remove remote subcommand in recipes

Project Member Reported by no...@chromium.org, Mar 2 2017

Issue description

kitchen does not use the remote subcommand since https://chromium-review.googlesource.com/c/448157/

remote_run.py is being converted to kitchen. Once this is done, nothing will use this subcommand of recipes, and we should remove it to reduce complexity.
 
Description: Show this description
Status: Available (was: Untriaged)
Project Member

Comment 3 by sheriffbot@chromium.org, May 16 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by mar...@chromium.org, May 21 2018

Cc: -d...@chromium.org
Labels: -Pri-1 -Hotlist-Recharge-Cold Pri-2
Status: Available (was: Untriaged)
Clearly not P1.
Cc: -iannucci@chromium.org iannu...@google.com
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 7

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/recipes-py/+/7bf15aaea60841beb1973a1b0ec19f3be3ec53b2

commit 7bf15aaea60841beb1973a1b0ec19f3be3ec53b2
Author: Robert Iannucci <iannucci@chromium.org>
Date: Fri Dec 07 22:59:34 2018

[remote] Remove remote subcommand.

This is only used on buildbot, but that uses a pinned version of the
recipe engine:

https://cs.chromium.org/chromium/build/scripts/slave/remote_run.py?q=remote_run.py&sq=package:chromium&dr=C&l=122

(which is pinned to https://chromium.googlesource.com/infra/luci/recipes-py/+/6eaacf24833ebd2565177157d368da33780fced9)

R=jchinlee@chromium.org, martiniss@chromium.org, tandrii@chromium.org

Bug:  913102 ,  697978 
Change-Id: I0ac00cc147262672c412ad2844a3b5c1d9219513
Reviewed-on: https://chromium-review.googlesource.com/c/1368749
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/7bf15aaea60841beb1973a1b0ec19f3be3ec53b2/recipe_engine/unittests/test_test.py
[modify] https://crrev.com/7bf15aaea60841beb1973a1b0ec19f3be3ec53b2/recipe_engine/common_args.py
[delete] https://crrev.com/faa8db3ceb17f3bc13c4ead7e4603760a0532f99/unittests/remote_test.py
[modify] https://crrev.com/7bf15aaea60841beb1973a1b0ec19f3be3ec53b2/doc/user_guide.md
[modify] https://crrev.com/7bf15aaea60841beb1973a1b0ec19f3be3ec53b2/recipes.py
[delete] https://crrev.com/faa8db3ceb17f3bc13c4ead7e4603760a0532f99/recipe_engine/remote.py
[modify] https://crrev.com/7bf15aaea60841beb1973a1b0ec19f3be3ec53b2/recipe_engine/unittests/autoroll_test.py

Status: Fixed (was: Available)

Sign in to add a comment