New issue
Advanced search Search tips

Issue 697976 link

Starred by 1 user
Status: Fixed
Owner:
ctzsm@chromium.org
Closed: Mar 2017
Cc:
danakj@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove unnecessary dcheck

Project Member Reported by sgu...@chromium.org, Mar 2 2017 

please remove unnecessary DCHECK in layer_tree_host_impl.cc. This is unnecessary as we are moving away from resourceless software draw mode.

3-02 18:45:26.175 15287 15323 F chromium: [FATAL:layer_tree_host_impl.cc(1024)] Check failed: draw_mode != DRAW_MODE_RESOURCELESS_SOFTWARE || frame->render_passes.size() == 1u. 2

Comment 1 by danakj@chromium.org, Mar 2 2017 

Ah yes. We're not moving away from resourceless software (texture layers and such are still excluded, it's still a software-only draw), but we are allowing more than one render pass.

Comment 2 by danakj@chromium.org, Mar 2 2017

Status: Available (was: Untriaged)

Comment 3 by danakj@chromium.org, Mar 2 2017

Status: Assigned (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7647683e57f52c2dd80d14e9475df3763a226b64

commit 7647683e57f52c2dd80d14e9475df3763a226b64
Author: ctzsm <ctzsm@chromium.org>
Date: Tue Mar 07 17:55:55 2017

remove DCHECK for resourceless software allowing more than one render pass.

BUG= 697976 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2734983003
Cr-Commit-Position: refs/heads/master@{#455127}

[modify] https://crrev.com/7647683e57f52c2dd80d14e9475df3763a226b64/cc/trees/layer_tree_host_impl.cc

Comment 5 by ctzsm@chromium.org, Mar 8 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment