New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 697960 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

[sync] Implement skeleton TypedURLSyncBridge

Project Member Reported by gangwu@chromium.org, Mar 2 2017

Issue description

Implement a non-functional ModelTypeSyncBridge for the TYPED_URLS model type.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69ae3f7272abd5f3c8b5da163916396a3c2f83e4

commit 69ae3f7272abd5f3c8b5da163916396a3c2f83e4
Author: gangwu <gangwu@chromium.org>
Date: Tue Apr 04 23:46:46 2017

[sync] skeleton implementation of TypedURLSyncBridge

TypedURLSyncBridge is the USS(unified sync and storage) equivalent of
the TypedUrlSyncableService.

This CL is for adding TypedURLSyncBridge class but not implement any
function yet.
This CL is Also addressing missing parts for  bug 558320 . CL is
https://codereview.chromium.org/1647833006

BUG= 697960 

Review-Url: https://codereview.chromium.org/2723953002
Cr-Commit-Position: refs/heads/master@{#461901}

[modify] https://crrev.com/69ae3f7272abd5f3c8b5da163916396a3c2f83e4/chrome/browser/sync/chrome_sync_client.cc
[modify] https://crrev.com/69ae3f7272abd5f3c8b5da163916396a3c2f83e4/components/browser_sync/profile_sync_components_factory_impl.cc
[modify] https://crrev.com/69ae3f7272abd5f3c8b5da163916396a3c2f83e4/components/history/core/browser/BUILD.gn
[modify] https://crrev.com/69ae3f7272abd5f3c8b5da163916396a3c2f83e4/components/history/core/browser/history_backend.cc
[modify] https://crrev.com/69ae3f7272abd5f3c8b5da163916396a3c2f83e4/components/history/core/browser/history_backend.h
[modify] https://crrev.com/69ae3f7272abd5f3c8b5da163916396a3c2f83e4/components/history/core/browser/history_service.cc
[modify] https://crrev.com/69ae3f7272abd5f3c8b5da163916396a3c2f83e4/components/history/core/browser/history_service.h
[add] https://crrev.com/69ae3f7272abd5f3c8b5da163916396a3c2f83e4/components/history/core/browser/typed_url_sync_bridge.cc
[add] https://crrev.com/69ae3f7272abd5f3c8b5da163916396a3c2f83e4/components/history/core/browser/typed_url_sync_bridge.h
[modify] https://crrev.com/69ae3f7272abd5f3c8b5da163916396a3c2f83e4/components/sync/driver/sync_driver_switches.cc
[modify] https://crrev.com/69ae3f7272abd5f3c8b5da163916396a3c2f83e4/components/sync/driver/sync_driver_switches.h
[modify] https://crrev.com/69ae3f7272abd5f3c8b5da163916396a3c2f83e4/ios/chrome/browser/sync/ios_chrome_sync_client.mm

Status: Fixed (was: Assigned)

Sign in to add a comment