Issue metadata
Sign in to add a comment
|
2.5%-3.6% regression in thread_times.key_silk_cases at 453432:453545 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Mar 2 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8986211229905981728
,
Mar 3 2017
=== BISECT JOB RESULTS === Perf regression found but unable to narrow commit range Build failures prevented the bisect from narrowing the range further. Bisect Details Configuration: android_nexus6_perf_bisect Benchmark : thread_times.key_silk_cases Metric : thread_browser_cpu_time_per_frame/thread_browser_cpu_time_per_frame Suspected Commit Range 8 commits in range https://chromium.googlesource.com/chromium/src/+log/07bec82ec92e1047614b17192569f69260945d42..4041a2c69ea6849c3a7d7aee2079b24da0cb0c3f Revision Result N chromium@453431 1.74989 +- 0.0317803 6 good chromium@453432 --- --- build failure chromium@453433 --- --- build failure chromium@453434 --- --- build failure chromium@453435 --- --- build failure chromium@453436 --- --- build failure chromium@453437 --- --- build failure chromium@453438 --- --- build failure chromium@453439 1.81082 +- 0.0303381 6 bad chromium@453447 1.80751 +- 0.0164354 6 bad chromium@453462 1.81065 +- 0.042429 6 bad chromium@453493 1.78915 +- 0.011021 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests thread_times.key_silk_cases Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8986211229905981728 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=4942906407780352 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Mar 6 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8985835584221464288
,
Mar 7 2017
=== Auto-CCing suspected CL author yusufo@chromium.org === Hi yusufo@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : yusufo Commit : 9967d360b1bdd6c7317c3cbe1e1d9c2b3aea677e Date : Tue Feb 28 01:12:54 2017 Subject: Remove a superfluous optimization from ApiCompatibilityUtils Bisect Details Configuration: android_nexus6_perf_bisect Benchmark : thread_times.key_silk_cases Metric : thread_browser_cpu_time_per_frame/thread_browser_cpu_time_per_frame Revision Result N chromium@453431 1.74709 +- 0.0387595 9 good chromium@453432 1.75266 +- 0.0166623 5 good chromium@453433 1.79721 +- 0.023671 6 bad <-- chromium@453435 1.812 +- 0.0355481 6 bad chromium@453439 1.79345 +- 0.0127481 6 bad chromium@453447 1.77791 +- 0.128043 9 bad chromium@453462 1.79471 +- 0.0223248 6 bad chromium@453493 1.79289 +- 0.0289383 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests thread_times.key_silk_cases Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8985835584221464288 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5877015053336576 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Jul 27 2017
Explictly assigning. A CL you landed tripped one of the speed metrics we measure in the lab. If this is the first time this has happened to one of your CLs, or if it's been a while, please read: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/addressing_performance_regressions.md We're looking for one of the following: 1. Justification via explanation 2. Plan to revert or fix 3. Angry rage throwing of equipment at my head Just be aware that I'm trained in trumpet playing and First Aid and am not afraid to use it. Note: This was a bulk edit message and not very personal.
,
Jul 27 2017
Umm sorry that this hasn't been updated. I did revert that CL, but looks like entered the wrong bug number.
,
Aug 4 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8972189095403664656
,
Aug 4 2017
I think we can probably close this, most of the graphs have recovered and the few that didn't had a tiny impact anyway (could easily have been noise).
,
Aug 4 2017
=== BISECT JOB RESULTS === Perf regression found but unable to continue Bisect was stopped because a commit couldn't be classified as either good or bad. Bisect Details Configuration: android_nexus6_perf_bisect Benchmark : thread_times.simple_mobile_sites Metric : thread_renderer_compositor_cpu_time_per_frame/thread_renderer_compositor_cpu_time_per_frame To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests thread_times.simple_mobile_sites More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8972189095403664656 For feedback, file a bug with component Speed>Bisection |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by sullivan@chromium.org
, Mar 2 2017