Issue metadata
Sign in to add a comment
|
54.1%-298.8% regression in system_health.common_desktop at 453347:453585 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Mar 2 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8986211282223738192
,
Mar 2 2017
=== BISECT JOB RESULTS === NO Perf regression found Bisect Details Configuration: mac_pro_perf_bisect Benchmark : system_health.common_desktop Metric : timeToFirstContentfulPaint_avg/load_search/load_search_ebay Revision Result N chromium@453512 336.823 +- 510.595 21 good chromium@453569 333.119 +- 408.929 21 bad To Run This Test src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.search.ebay system_health.common_desktop Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8986211282223738192 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=6195251493994496 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Mar 2 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8986205989064493072
,
Mar 3 2017
=== Auto-CCing suspected CL author binji@chromium.org === Hi binji@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : binji Commit : 5a04f4fd68d1d35d704cdc0dee0719c5354a8094 Date : Mon Feb 27 22:26:27 2017 Subject: This is a speculative chain of reverts to improve a Chrome Bisect Details Configuration: android_webview_nexus6_aosp_perf_bisect Benchmark : page_cycler_v2.intl_ar_fa_he Metric : timeToFirstMeaningfulPaint_avg/pcv1-warm/http___ynet.co.il_ Change : 47.29% | 1903.19433333 -> 2803.26966667 Revision Result N chromium@453546 1903.19 +- 910.54 6 good chromium@453566 2061.76 +- 1170.88 6 good chromium@453567 1852.31 +- 955.446 9 good chromium@453567,v8@a2a2c1b9ee 1738.53 +- 82.0199 6 good chromium@453567,v8@5a04f4fd68 2612.88 +- 910.769 6 bad <-- chromium@453567,v8@2362f869a4 2807.29 +- 69.0616 6 bad chromium@453567,v8@6543519977 2686.7 +- 1030.34 14 bad chromium@453568 2817.58 +- 125.068 9 bad chromium@453569 2776.09 +- 112.692 9 bad chromium@453571 2769.62 +- 40.2009 6 bad chromium@453576 2776.55 +- 70.4868 6 bad chromium@453585 2803.27 +- 62.6333 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http...ynet.co.il. page_cycler_v2.intl_ar_fa_he Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8986205989064493072 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5874805460434944 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Mar 6 2017
I'm looking into reverting the revert to fix this and other regressions, see https://bugs.chromium.org/p/v8/issues/detail?id=6033.
,
Jul 27 2017
Explictly assigning. A CL you landed tripped one of the speed metrics we measure in the lab. If this is the first time this has happened to one of your CLs, or if it's been a while, please read: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/addressing_performance_regressions.md We're looking for one of the following: 1. Justification via explanation 2. Plan to revert or fix 3. Angry rage throwing of equipment at my head Just be aware that I'm trained in trumpet playing and First Aid and am not afraid to use it. Note: This was a bulk edit message and not very personal.
,
Aug 3 2017
This looks like it could be some kind of thresholding thing; the graph looks like it was pretty stable, then improved, then regressed (my change), then improved, then regressed back to the stable point (where it's stayed for a while).
,
Aug 3 2017
I agree the graph definitely seems to be bimodal. The problem later went away, then the test case was removed in July. Not worth investigating further. binji: sorry for the noise! |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by sullivan@chromium.org
, Mar 2 2017