New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 697944 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

add support for logging session_id and initial_url UKM fields

Project Member Reported by bmcquade@chromium.org, Mar 2 2017

Issue description

We're working on getting server-side support in place for these fields. We need to add client-side support as well.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7894b9acb1c4de15bf778042b826a72f3e358069

commit 7894b9acb1c4de15bf778042b826a72f3e358069
Author: bmcquade <bmcquade@chromium.org>
Date: Thu Mar 02 21:31:10 2017

Add UKM initial_url and session_id fields.

This change adds support for logging the following new fields in UKM:
1. initial_url: the initial URL of a source, in cases where the URL of a source
   changes
2. session_id: a counter that's incremented for each browsing session (similar
   to the UMA session_id field)

Logging of both of these fields is gated on field trial params, and is disabled
by default. We'll start logging once the server-side changes for these fields are
in place.

BUG= 697944 

Review-Url: https://codereview.chromium.org/2722983006
Cr-Commit-Position: refs/heads/master@{#454382}

[modify] https://crrev.com/7894b9acb1c4de15bf778042b826a72f3e358069/components/metrics/proto/ukm/report.proto
[modify] https://crrev.com/7894b9acb1c4de15bf778042b826a72f3e358069/components/metrics/proto/ukm/source.proto
[modify] https://crrev.com/7894b9acb1c4de15bf778042b826a72f3e358069/components/ukm/BUILD.gn
[modify] https://crrev.com/7894b9acb1c4de15bf778042b826a72f3e358069/components/ukm/test_ukm_service.cc
[modify] https://crrev.com/7894b9acb1c4de15bf778042b826a72f3e358069/components/ukm/ukm_pref_names.cc
[modify] https://crrev.com/7894b9acb1c4de15bf778042b826a72f3e358069/components/ukm/ukm_pref_names.h
[modify] https://crrev.com/7894b9acb1c4de15bf778042b826a72f3e358069/components/ukm/ukm_service.cc
[modify] https://crrev.com/7894b9acb1c4de15bf778042b826a72f3e358069/components/ukm/ukm_service.h
[modify] https://crrev.com/7894b9acb1c4de15bf778042b826a72f3e358069/components/ukm/ukm_service_unittest.cc
[modify] https://crrev.com/7894b9acb1c4de15bf778042b826a72f3e358069/components/ukm/ukm_source.cc
[modify] https://crrev.com/7894b9acb1c4de15bf778042b826a72f3e358069/components/ukm/ukm_source.h

Status: Fixed (was: Started)

Sign in to add a comment