New issue
Advanced search Search tips

Issue 697939 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Mar 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

views::Textfield won't update cursor (caret) color on text color change

Reported by mmarkow...@opera.com, Mar 2 2017

Issue description

Chrome Version       : 58.0.3029.0 (66956e6ee256c827808b4dc4a05c32ab077747d5)
URLs (if applicable) : N/A
Other browsers tested: N/A
have tested this issue: N/A

What steps will reproduce the problem?
(1) Call views::Textfield::SetTextColor

What is the expected result?
Cursor color is updated after the call.

What happens instead?
Cursor color stays the same. (Well, not until native theme change. Textfield::OnNativeThemeChanged will apply this new text color to the cursor.)
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/741bad136249946504139ca35420d78a312762f7

commit 741bad136249946504139ca35420d78a312762f7
Author: mmarkowicz <mmarkowicz@opera.com>
Date: Fri Mar 03 17:50:11 2017

Update views::Textfield cursor color on text color change

views::Textfield::SetTextColor should apply new color to the cursor as well.
Currently this will happen but only after Textfield::OnNativeThemeChanged
is triggered in some way.

BUG= 697939 

Review-Url: https://codereview.chromium.org/2730623003
Cr-Commit-Position: refs/heads/master@{#454616}

[modify] https://crrev.com/741bad136249946504139ca35420d78a312762f7/ui/views/controls/textfield/textfield.cc

Project Member

Comment 2 by sheriffbot@chromium.org, Mar 5 2018

Status: Archived (was: Unconfirmed)
Issue has not been modified or commented on in the last 365 days, please re-open or file a new bug if this is still an issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment