New issue
Advanced search Search tips

Issue 697931 link

Starred by 1 user
Status: Fixed
Owner:
bokan@chromium.org
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Add metric to track distribution of resize handlers

Project Member Reported by bokan@chromium.org, Mar 2 2017 
It'd be useful to know how long resize handlers typically are. This will help with decisions on various viewport APIs. For example, should we remove the `resize` event from the on screen keyboard appearing/disappearing?
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a52f5a31e5b6a2b3faba076efc944d55d6c4a58

commit 0a52f5a31e5b6a2b3faba076efc944d55d6c4a58
Author: bokan <bokan@chromium.org>
Date: Thu Mar 02 21:36:49 2017

Added histogram for resize listener duration.

Tracks how long it takes to execute event listeners on the main frame. Note
that this will track how long *all* listeners took to execute per-event.

Added since this will be useful for decisions around various viewport actions
and whether we need to add a new resize event for resizes from the URL bar and
keyboard which resize only the visual viewport.

BUG= 697931 

Review-Url: https://codereview.chromium.org/2727953002
Cr-Commit-Position: refs/heads/master@{#454383}

[modify] https://crrev.com/0a52f5a31e5b6a2b3faba076efc944d55d6c4a58/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
[modify] https://crrev.com/0a52f5a31e5b6a2b3faba076efc944d55d6c4a58/tools/metrics/histograms/histograms.xml

Comment 2 by bokan@chromium.org, Mar 6 2017

Status: Fixed (was: Started)

Comment 3 by bokan@chromium.org, Jan 16 2018 

The metric is being removed. For posterity, some of the collected data is attached.
ResizeDurations-AllAndroid.png
385 KB View Download
ResizeDurations-LowMemAndroid.png
407 KB View Download
►

Sign in to add a comment