New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 697929 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
not on Chrome anymore
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

gl_tests's DirectCompositionSurfaceTest.TestMakeCurrent fails on Win10 Release NVIDIA

Project Member Reported by cwallez@chromium.org, Mar 2 2017

Issue description

The first failing build is https://build.chromium.org/p/chromium.gpu.fyi/builders/Win10%20Release%20%28NVIDIA%29/builds/986

jbauman, can you take a look? The regression range contains "Use IDCompositionSurface to implement DirectCompositionSurfaceWin." that seems very related.

 
It is also failing on Win 10 Intel Release.

Comment 2 by kbr@chromium.org, Mar 2 2017

Components: Internals>GPU>Testing
Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3051724ad6cbc2e32743085786bd362bd1f06a61

commit 3051724ad6cbc2e32743085786bd362bd1f06a61
Author: jbauman <jbauman@chromium.org>
Date: Fri Mar 03 02:34:15 2017

Fix DirectCompositionSurfaceTest.TestMakeCurrent flakiness.

The tasks to delete the window owner threads could be posted to the main
thread after the main thread ran RunUntilIdle. This causes the window
owner threads and their MessagePumpForUI to outlive the main test, and
that causes a DCHECK when the test tries to get rid of the MessageWindow
class atom that the message pump is currently using.

BUG= 697929 
TBR=stanisc@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2729073002
Cr-Commit-Position: refs/heads/master@{#454475}

[modify] https://crrev.com/3051724ad6cbc2e32743085786bd362bd1f06a61/gpu/ipc/service/child_window_win.cc
[modify] https://crrev.com/3051724ad6cbc2e32743085786bd362bd1f06a61/gpu/ipc/service/child_window_win.h
[modify] https://crrev.com/3051724ad6cbc2e32743085786bd362bd1f06a61/gpu/ipc/service/direct_composition_surface_win.cc
[modify] https://crrev.com/3051724ad6cbc2e32743085786bd362bd1f06a61/gpu/ipc/service/direct_composition_surface_win.h
[modify] https://crrev.com/3051724ad6cbc2e32743085786bd362bd1f06a61/gpu/ipc/service/direct_composition_surface_win_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment