https://wicg.github.io/shape-detection-api/#text-detection-api see blocked bug. Uses https://developer.apple.com/reference/coreimage/cidetectortypetext
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de6e85f0f4d505692f11c7f2d1c39f043f702796 commit de6e85f0f4d505692f11c7f2d1c39f043f702796 Author: mcasas <mcasas@chromium.org> Date: Fri Mar 03 17:40:04 2017 ShapeDetection: add support for Text Detection in Mac This CL adds text detection for Mac in services/shape_detection, and also adds unittest for it, that will be run, like the other specific unittests, in the mac gpu bots. BUG= 697925 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel TEST= unittests that can be run anywhere like this: out/gn/service_unittests --gtest_filter=*TextDetection* --use-gpu-in-tests and demo page, e.g. ./out/gn/Chromium.app/Contents/MacOS/Chromium --enable-blink-features=ShapeDetection https://codepen.io/miguelao/full/ygxVqg Review-Url: https://codereview.chromium.org/2726843006 Cr-Commit-Position: refs/heads/master@{#454609} [modify] https://crrev.com/de6e85f0f4d505692f11c7f2d1c39f043f702796/base/mac/sdk_forward_declarations.h [modify] https://crrev.com/de6e85f0f4d505692f11c7f2d1c39f043f702796/base/mac/sdk_forward_declarations.mm [modify] https://crrev.com/de6e85f0f4d505692f11c7f2d1c39f043f702796/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/de6e85f0f4d505692f11c7f2d1c39f043f702796/content/public/app/mojo/content_browser_manifest.json [modify] https://crrev.com/de6e85f0f4d505692f11c7f2d1c39f043f702796/services/shape_detection/BUILD.gn [modify] https://crrev.com/de6e85f0f4d505692f11c7f2d1c39f043f702796/services/shape_detection/manifest.json [modify] https://crrev.com/de6e85f0f4d505692f11c7f2d1c39f043f702796/services/shape_detection/shape_detection_service.cc [add] https://crrev.com/de6e85f0f4d505692f11c7f2d1c39f043f702796/services/shape_detection/text_detection_impl.cc [add] https://crrev.com/de6e85f0f4d505692f11c7f2d1c39f043f702796/services/shape_detection/text_detection_impl.h [add] https://crrev.com/de6e85f0f4d505692f11c7f2d1c39f043f702796/services/shape_detection/text_detection_impl_mac.h [add] https://crrev.com/de6e85f0f4d505692f11c7f2d1c39f043f702796/services/shape_detection/text_detection_impl_mac.mm [add] https://crrev.com/de6e85f0f4d505692f11c7f2d1c39f043f702796/services/shape_detection/text_detection_impl_mac_unittest.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0832734083fedd1000e5e871071a78ff93b57a29 commit 0832734083fedd1000e5e871071a78ff93b57a29 Author: avi <avi@chromium.org> Date: Sun Mar 05 00:29:23 2017 Revert of ShapeDetection: add support for Text Detection in Mac (patchset #4 id:80001 of https://codereview.chromium.org/2726843006/ ) Reason for revert: ../../services/shape_detection/text_detection_impl_mac.mm:68:8: > error: 'CIRectangleFeature' is only available on macOS 10_10 or newer Original issue's description: > ShapeDetection: add support for Text Detection in Mac > > This CL adds text detection for Mac in services/shape_detection, > and also adds unittest for it, that will be run, like the > other specific unittests, in the mac gpu bots. > > BUG= 697925 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel > TEST= unittests that can be run anywhere like this: > out/gn/service_unittests --gtest_filter=*TextDetection* --use-gpu-in-tests > > and demo page, e.g. > ./out/gn/Chromium.app/Contents/MacOS/Chromium --enable-blink-features=ShapeDetection https://codepen.io/miguelao/full/ygxVqg > > Review-Url: https://codereview.chromium.org/2726843006 > Cr-Commit-Position: refs/heads/master@{#454609} > Committed: https://chromium.googlesource.com/chromium/src/+/de6e85f0f4d505692f11c7f2d1c39f043f702796 TBR=rockot@chromium.org,reillyg@chromium.org,tsepez@chromium.org,mcasas@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 697925 Review-Url: https://codereview.chromium.org/2728253003 Cr-Commit-Position: refs/heads/master@{#454785} [modify] https://crrev.com/0832734083fedd1000e5e871071a78ff93b57a29/base/mac/sdk_forward_declarations.h [modify] https://crrev.com/0832734083fedd1000e5e871071a78ff93b57a29/base/mac/sdk_forward_declarations.mm [modify] https://crrev.com/0832734083fedd1000e5e871071a78ff93b57a29/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/0832734083fedd1000e5e871071a78ff93b57a29/content/public/app/mojo/content_browser_manifest.json [modify] https://crrev.com/0832734083fedd1000e5e871071a78ff93b57a29/services/shape_detection/BUILD.gn [modify] https://crrev.com/0832734083fedd1000e5e871071a78ff93b57a29/services/shape_detection/manifest.json [modify] https://crrev.com/0832734083fedd1000e5e871071a78ff93b57a29/services/shape_detection/shape_detection_service.cc [delete] https://crrev.com/321e2120354336b873e63556893355f8116fcd63/services/shape_detection/text_detection_impl.cc [delete] https://crrev.com/321e2120354336b873e63556893355f8116fcd63/services/shape_detection/text_detection_impl.h [delete] https://crrev.com/321e2120354336b873e63556893355f8116fcd63/services/shape_detection/text_detection_impl_mac.h [delete] https://crrev.com/321e2120354336b873e63556893355f8116fcd63/services/shape_detection/text_detection_impl_mac.mm [delete] https://crrev.com/321e2120354336b873e63556893355f8116fcd63/services/shape_detection/text_detection_impl_mac_unittest.mm
Reopened bc of #3, relanding soon.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9eba8ffcc405012f235a5bfb5ce49485a746b379 commit 9eba8ffcc405012f235a5bfb5ce49485a746b379 Author: mcasas <mcasas@chromium.org> Date: Mon Mar 06 02:58:29 2017 RELAND: ShapeDetection: add support for Text Detection in Mac The original CL got reverted due to out-of-bots partial availability warnings such as : ../../services/shape_detection/text_detection_impl_mac.mm:68:8: > error: 'CIRectangleFeature' is only available on macOS 10_10 or newer (1st spotted in https://codereview.chromium.org/2726843006/#msg29) This CL adds forward-declaration of this class before 10.11. Incidentally, it's the same issue addressed in e.g. https://bugs.chromium.org/p/chromium/issues/detail?id=665150#c24 Original issue's description: > ShapeDetection: add support for Text Detection in Mac > > This CL adds text detection for Mac in services/shape_detection, > and also adds unittest for it, that will be run, like the > other specific unittests, in the mac gpu bots. > > BUG= 697925 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel > TEST= unittests that can be run anywhere like this: > out/gn/service_unittests --gtest_filter=*TextDetection* --use-gpu-in-tests > > and demo page, e.g. > ./out/gn/Chromium.app/Contents/MacOS/Chromium --enable-blink-features=ShapeDetection https://codepen.io/miguelao/full/ygxVqg > > Review-Url: https://codereview.chromium.org/2726843006 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel TBR=avi@chromium.org, rsesek@chromium.org since it's a trivial fwd-declaration. Review-Url: https://codereview.chromium.org/2734703002 Cr-Commit-Position: refs/heads/master@{#454816} [modify] https://crrev.com/9eba8ffcc405012f235a5bfb5ce49485a746b379/base/mac/sdk_forward_declarations.h [modify] https://crrev.com/9eba8ffcc405012f235a5bfb5ce49485a746b379/base/mac/sdk_forward_declarations.mm [modify] https://crrev.com/9eba8ffcc405012f235a5bfb5ce49485a746b379/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/9eba8ffcc405012f235a5bfb5ce49485a746b379/content/public/app/mojo/content_browser_manifest.json [modify] https://crrev.com/9eba8ffcc405012f235a5bfb5ce49485a746b379/services/shape_detection/BUILD.gn [modify] https://crrev.com/9eba8ffcc405012f235a5bfb5ce49485a746b379/services/shape_detection/manifest.json [modify] https://crrev.com/9eba8ffcc405012f235a5bfb5ce49485a746b379/services/shape_detection/shape_detection_service.cc [add] https://crrev.com/9eba8ffcc405012f235a5bfb5ce49485a746b379/services/shape_detection/text_detection_impl.cc [add] https://crrev.com/9eba8ffcc405012f235a5bfb5ce49485a746b379/services/shape_detection/text_detection_impl.h [add] https://crrev.com/9eba8ffcc405012f235a5bfb5ce49485a746b379/services/shape_detection/text_detection_impl_mac.h [add] https://crrev.com/9eba8ffcc405012f235a5bfb5ce49485a746b379/services/shape_detection/text_detection_impl_mac.mm [add] https://crrev.com/9eba8ffcc405012f235a5bfb5ce49485a746b379/services/shape_detection/text_detection_impl_mac_unittest.mm
Comment 1 by bugdroid1@chromium.org
, Mar 3 2017