New issue
Advanced search Search tips

Issue 697922 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: ----



Sign in to add a comment

Lollipop Tablet Tester has failed the last 18 builds, not displayed in sheriff-o-matic

Project Member Reported by twelling...@chromium.org, Mar 2 2017

Issue description

The Lollipop Tablet Tester is failing tests but it's not displayed by default in sheriff-o-matic. It's hidden behind the "Show infra failures" checkbox even though the bot is red (only 1 purple in the last 18).

Link to bot: https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20Tablet%20Tester
 
I'm also not seeing Android Tests (dbg) in sheriff-o-matic even though it failed its last run and has been intermittently failing content_shell_tests since early this morning. What's the policy for when bots show up in sheriff-o-matic?

https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests%20(dbg)
Another example -- a CL landed 3 days ago that's been causing base_unittests to failure on multiple bots and none of the failures were are listed in sheriff-o-matic.

https://codereview.chromium.org/2698843006

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=base_unittests&tests=TaskSchedulerSingleThreadTaskRunnerManagerTest.PrioritySetCorrectly
TaskSchedulerSingleThreadTaskRunnerManagerTest.png
23.1 KB View Download
Sheriff-O-Matic.png
129 KB View Download
I don't see Lollipop Tablet Tester being red; it looks all purple to me (see screenshot).

The builders that should show up on SOM are defined here: https://cs.chromium.org/chromium/build/scripts/slave/gatekeeper_trees.json?l=41

That lists masters. To see which builders a master cares about, look at https://cs.chromium.org/chromium/build/scripts/slave/gatekeeper.json?q=gatekeeper.json+package:%5Echromium$&l=22
download.png
69.3 KB View Download
Re #3 - download.png appears to be empty. Here's what I see on the bot page:

LollipopTabletTester.png
217 KB View Download
Ah ok, I was looking at the wrong builder. My bad.

Ok, I ran alerts dispatcher locally, and it didn't have any alerts either. Looking into this.
Owner: martiniss@chromium.org
Status: Assigned (was: Untriaged)
Looks like there was a bug in the failure detection logic. I'm trying to upload a CL.
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/366033b52d4a7d5231b4bce1a70bfedf47072eb3

commit 366033b52d4a7d5231b4bce1a70bfedf47072eb3
Author: Stephen Martinis <martiniss@google.com>
Date: Thu Mar 02 22:22:13 2017

AD: Fix analyze logic

It currently is using incorrect logic to decide which builds to analyze.

Also adds a test

BUG= 697922 

Change-Id: I401ca5133f602c6a4bf8c438bab2a994285dfce1
Reviewed-on: https://chromium-review.googlesource.com/448650
Reviewed-by: Sean McCullough <seanmccullough@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/366033b52d4a7d5231b4bce1a70bfedf47072eb3/go/src/infra/monitoring/analyzer/analyzer_test.go
[modify] https://crrev.com/366033b52d4a7d5231b4bce1a70bfedf47072eb3/go/src/infra/monitoring/analyzer/analyzer.go

Project Member

Comment 9 by bugdroid1@chromium.org, Mar 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/366033b52d4a7d5231b4bce1a70bfedf47072eb3

commit 366033b52d4a7d5231b4bce1a70bfedf47072eb3
Author: Stephen Martinis <martiniss@google.com>
Date: Thu Mar 02 22:22:13 2017

AD: Fix analyze logic

It currently is using incorrect logic to decide which builds to analyze.

Also adds a test

BUG= 697922 

Change-Id: I401ca5133f602c6a4bf8c438bab2a994285dfce1
Reviewed-on: https://chromium-review.googlesource.com/448650
Reviewed-by: Sean McCullough <seanmccullough@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/366033b52d4a7d5231b4bce1a70bfedf47072eb3/go/src/infra/monitoring/analyzer/analyzer_test.go
[modify] https://crrev.com/366033b52d4a7d5231b4bce1a70bfedf47072eb3/go/src/infra/monitoring/analyzer/analyzer.go

Labels: Milestone-Clank
Status: Fixed (was: Assigned)

Sign in to add a comment