New issue
Advanced search Search tips

Issue 697921 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Payment Request dialog content should be scrollable

Project Member Reported by anthonyvd@chromium.org, Mar 2 2017

Issue description

When the content of the PaymentRequest dialog is too tall, a scrollbar should be displayed to make it possible to see all elements.

The scroll bar should only be on the content, with the header and footer clamped to the top/bottom of the view respectively.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44461dddebd225d5be35ef3e86c4c04cf061fe50

commit 44461dddebd225d5be35ef3e86c4c04cf061fe50
Author: anthonyvd <anthonyvd@chromium.org>
Date: Fri Mar 03 17:45:17 2017

[Web Payments] Wrap each sheet's content view in a scrollable view.

This change wraps the content of each sheet in a ScrollView so that a
scroll bar is displayed when that content is too tall to fit between
the dialog header and footer.

BUG= 697921 

Review-Url: https://codereview.chromium.org/2722183005
Cr-Commit-Position: refs/heads/master@{#454613}

[modify] https://crrev.com/44461dddebd225d5be35ef3e86c4c04cf061fe50/chrome/browser/ui/views/payments/payment_request_sheet_controller.cc
[modify] https://crrev.com/44461dddebd225d5be35ef3e86c4c04cf061fe50/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc

Status: Fixed (was: Assigned)
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment