Issue metadata
Sign in to add a comment
|
26.6%-535.8% regression in scheduler.tough_scheduling_cases at 453116:453373 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Mar 2 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8986224382968432464
,
Mar 2 2017
Note there are android input latency regressions in same revision range, tracking those in bug 697873 .
,
Mar 2 2017
Cc-ing tdresser since this is a pretty widespread input latency regression.
,
Mar 2 2017
=== Auto-CCing suspected CL author dtapuska@chromium.org === Hi dtapuska@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : dtapuska Commit : 53f9f4ee5790ce47bf43eee521fdd3536cd1763a Date : Mon Feb 27 01:14:26 2017 Subject: Add a passthrough touch event queue. Bisect Details Configuration: winx64_zen_perf_bisect Benchmark : smoothness.top_25_smooth Metric : mean_input_event_latency/https___www.google.com_calendar_ Change : 536.06% | 2.91666666667 -> 18.5518333333 Revision Result N chromium@453128 2.91667 +- 0.212935 6 good chromium@453131 2.932 +- 0.221955 6 good chromium@453132 2.95233 +- 0.20784 6 good chromium@453133 18.4887 +- 0.400806 6 bad <-- chromium@453138 18.5943 +- 0.195533 6 bad chromium@453147 18.5282 +- 0.184821 6 bad chromium@453165 18.5518 +- 0.290329 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=https...www.google.com.calendar. smoothness.top_25_smooth Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8986224382968432464 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=4851167584059392 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Mar 2 2017
I believe this is because of the way the mean_input_latency is calculated. We have moved the coalescing of events from the browser process into the renderer process with the change stated here. And I wonder if the greater number of ACKs being returned by the renderer is thus causing the mean to change. I've started a bisect with tracing. Hopefully that will show us the different calculations. tdresser@ is going to check the mean latency info code.
,
Mar 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/abf462cdff2f095ab1ab69beb78c8b658bfb634a commit abf462cdff2f095ab1ab69beb78c8b658bfb634a Author: dtapuska <dtapuska@chromium.org> Date: Fri Mar 03 03:46:57 2017 Disable the passthrough touch event queue for now. Due to perf regressions disable the passthrough touch event queue it causes GestureScrollUpdate events to take more time. BUG= 697871 , 642368 Review-Url: https://codereview.chromium.org/2722113007 Cr-Commit-Position: refs/heads/master@{#454504} [modify] https://crrev.com/abf462cdff2f095ab1ab69beb78c8b658bfb634a/content/browser/renderer_host/input/input_router_impl.cc [modify] https://crrev.com/abf462cdff2f095ab1ab69beb78c8b658bfb634a/content/browser/renderer_host/input/input_router_impl_unittest.cc
,
Mar 6 2017
,
Mar 6 2017
,
Mar 6 2017
,
Mar 6 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e69ab6bfafc78b6037ee64329e6af6974e3afb6 commit 6e69ab6bfafc78b6037ee64329e6af6974e3afb6 Author: Dave Tapuska <dtapuska@chromium.org> Date: Mon Mar 06 15:23:26 2017 Disable the passthrough touch event queue for now. Due to perf regressions disable the passthrough touch event queue it causes GestureScrollUpdate events to take more time. BUG= 697871 , 642368 Review-Url: https://codereview.chromium.org/2722113007 Cr-Commit-Position: refs/heads/master@{#454504} (cherry picked from commit abf462cdff2f095ab1ab69beb78c8b658bfb634a) Review-Url: https://codereview.chromium.org/2731213003 . Cr-Commit-Position: refs/branch-heads/3029@{#20} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/6e69ab6bfafc78b6037ee64329e6af6974e3afb6/content/browser/renderer_host/input/input_router_impl.cc [modify] https://crrev.com/6e69ab6bfafc78b6037ee64329e6af6974e3afb6/content/browser/renderer_host/input/input_router_impl_unittest.cc
,
Mar 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/48123136ee6788085fc91bf856bf5e05f97da590 commit 48123136ee6788085fc91bf856bf5e05f97da590 Author: dtapuska <dtapuska@chromium.org> Date: Mon Mar 06 22:28:30 2017 Re-enable passthrough touch event queue. Async touchmoves were going to the main thread to be ack'd by the compositor but this was useless and causing a regression in the mean input event latency. Ack async touch moves right away just like the LegacyTouchEventQueue did. BUG= 697871 , 642368 Review-Url: https://codereview.chromium.org/2734563002 Cr-Commit-Position: refs/heads/master@{#454977} [modify] https://crrev.com/48123136ee6788085fc91bf856bf5e05f97da590/content/browser/renderer_host/input/input_router_impl.cc [modify] https://crrev.com/48123136ee6788085fc91bf856bf5e05f97da590/content/browser/renderer_host/input/input_router_impl.h [modify] https://crrev.com/48123136ee6788085fc91bf856bf5e05f97da590/content/browser/renderer_host/input/input_router_impl_perftest.cc [modify] https://crrev.com/48123136ee6788085fc91bf856bf5e05f97da590/content/browser/renderer_host/input/input_router_impl_unittest.cc [modify] https://crrev.com/48123136ee6788085fc91bf856bf5e05f97da590/content/renderer/input/input_event_filter_unittest.cc [modify] https://crrev.com/48123136ee6788085fc91bf856bf5e05f97da590/content/renderer/render_widget_unittest.cc [modify] https://crrev.com/48123136ee6788085fc91bf856bf5e05f97da590/ui/events/blink/web_input_event_traits.cc [modify] https://crrev.com/48123136ee6788085fc91bf856bf5e05f97da590/ui/events/blink/web_input_event_traits.h |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by sullivan@chromium.org
, Mar 2 2017