New issue
Advanced search Search tips

Issue 697870 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

V8 correctness failure in configs: x64,ignition:x64,ignition_turbo_opt

Project Member Reported by ClusterFuzz, Mar 2 2017

Issue description

Owner: machenb...@chromium.org
Status: Assigned (was: Untriaged)
// Only repros with a time delay in the harness. Simple repro:

print(new Date())
print((new Date())["constructor"]());

// The second line circumvents the proxy.
// We need to properly mock out all these cases:
print(Date())
print(new Date())
print(new (new Date())["constructor"]());
print((new Date())["constructor"]());

print(Date(10))
print(new Date(10))
print(new (new Date(10))["constructor"]());
print((new Date(10))["constructor"]());

print(new (new Date())["constructor"](10));
print((new Date())["constructor"](10));
print(new (new Date(10))["constructor"](10));
print((new Date(10))["constructor"](10));
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/bf84d924c36e85e61020288cc339a7d9829ac419

commit bf84d924c36e85e61020288cc339a7d9829ac419
Author: Michael Achenbach <machenbach@chromium.org>
Date: Fri Mar 03 07:56:35 2017

[foozzie] Properly mock out Date

The old proxy only mocked out constructor calls and didn't intercept function application. It also kept the original constructor property, through which non-mocked dates could be constructed again.

BUG= chromium:697870 
NOTRY=true
R=mstarzinger@chromium.org,yangguo@chromium.org

Change-Id: Icb4ef22342424f95463a7a9c57fa0bb8d910ac19
Reviewed-on: https://chromium-review.googlesource.com/448564
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#43569}
[modify] https://crrev.com/bf84d924c36e85e61020288cc339a7d9829ac419/tools/foozzie/v8_mock.js

Status: Fixed (was: Assigned)

Sign in to add a comment