https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp?l=974 This does not match the current spec. The IDL type is "double" (in Chromium and spec) for .line but the settings parser still parses into an integer. Spec: http://w3c.github.io/webvtt/#parse-the-webvtt-cue-settings web-platform-tests: /webvtt/parsing/file-parsing/tests/settings-line.html in https://github.com/w3c/web-platform-tests/pull/5032 Fail settings, line assert_equals: Failed with cue 7 expected 4294967296 but got 2147483648 (Gecko passes except for the "line:5." test: https://bugzilla.mozilla.org/show_bug.cgi?id=1343794 )
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c2c0ae635af66f017c084641684d054863802a8 commit 8c2c0ae635af66f017c084641684d054863802a8 Author: fs <fs@opera.com> Date: Fri Mar 03 15:37:32 2017 The WebVTT 'line' settings should be parsed as a float Per https://w3c.github.io/webvtt/#parse-the-webvtt-cue-settings . Negative zero is transformed to positive zero. Also make valid percentages outside of [0, 100] fail quicker. BUG= 697869 Review-Url: https://codereview.chromium.org/2725313002 Cr-Commit-Position: refs/heads/master@{#454587} [modify] https://crrev.com/8c2c0ae635af66f017c084641684d054863802a8/third_party/WebKit/LayoutTests/media/track/captions-webvtt/tc017-line-position-bad.vtt [add] https://crrev.com/8c2c0ae635af66f017c084641684d054863802a8/third_party/WebKit/LayoutTests/media/track/opera/track/webvtt/parsing/001-expected.txt [modify] https://crrev.com/8c2c0ae635af66f017c084641684d054863802a8/third_party/WebKit/LayoutTests/media/track/opera/track/webvtt/parsing/support/settings-line.vtt [modify] https://crrev.com/8c2c0ae635af66f017c084641684d054863802a8/third_party/WebKit/LayoutTests/media/track/track-webvtt-tc017-line-position.html [modify] https://crrev.com/8c2c0ae635af66f017c084641684d054863802a8/third_party/WebKit/Source/core/html/track/vtt/VTTCue.cpp
Comment 1 by f...@opera.com
, Mar 2 2017Owner: f...@opera.com
Status: Assigned (was: Untriaged)