New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 697853 link

Starred by 1 user
Status: WontFix
Owner:
vitaliii@chromium.org
Closed: Jul 2017
Cc:
dewittj@chromium.org
█ dim...@chromium.org
ntp-dev+bugs@chromium.org
carlosk@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 659205



Sign in to add a comment

Open tab suggestions disappear after opened.

Project Member Reported by vitaliii@chromium.org, Mar 2 2017 
Chrome Version: 58.0.3027.0
OS: Android

What steps will reproduce the problem?
(1) Open some URL.
(2) Wait.
(3) Open NTP.
(4) Observe an open tab suggestion.
(5) Tap on it.
(6) Through tab switch go back to that NTP.

What is the expected result?
The suggestion stays there.

What happens instead?
It goes away.

They do reappear in new NTPs.
If I open all open tabs suggestions like this, they reappear on the same NTP.

Comment 1 by vitaliii@chromium.org, Mar 2 2017 

After some investigation I observe that opening a tab causes its offline page to be removed (probably, because a new snapshot is created). 

===== LOG STARTS ======

<I go to tab with https://amp.cnn.com/cnn/2017/03/01/politics/jeff-sessions-russian-ambassador-meetings/index.html via tab switcher>

<I go back to the NTP via tab switcher>

03-02 17:10:42.033 I/chromium(30716): [INFO:download_ui_adapter.cc(123)] MYMYMY OfflinePageDeleted client_id.id 18
03-02 17:10:42.033 I/chromium(30716): [INFO:recent_tab_suggestions_provider.cc(204)] MYMYMY ItemDeleted guid 18
03-02 17:10:42.033 I/chromium(30716): [INFO:recent_tab_suggestions_provider.cc(308)] MYMYMY InvalidateSuggestion guid 18
03-02 17:10:42.086 I/chromium(30716): [INFO:download_ui_adapter.cc(110)] MYMYMY OfflinePageAdded url https://amp.cnn.com/cnn/2017/03/01/politics/jeff-sessions-russian-ambassador-meetings/index.html; client_id 18
03-02 17:10:42.086 I/chromium(30716): [INFO:recent_tab_suggestions_provider.cc(191)] MYMYMY ItemAdded url https://amp.cnn.com/cnn/2017/03/01/politics/jeff-sessions-russian-ambassador-meetings/index.html, guid 18
03-02 17:10:42.086 I/chromium(30716): [INFO:recent_tab_suggestions_provider.cc(222)] MYMYMY FetchRecentTabs sz 1
03-02 17:10:42.086 I/chromium(30716): [INFO:recent_tab_suggestions_provider.cc(226)] MYMYMY        https://amp.cnn.com/cnn/2017/03/01/politics/jeff-sessions-russian-ambassador-meetings/index.html 18
03-02 17:10:42.086 I/chromium(30716): [INFO:recent_tab_suggestions_provider.cc(302)] MYMYMY OnNewSuggestions gets sz 1

===== LOG ENDS ======

Comment 2 by vitaliii@chromium.org, Mar 2 2017 

Here is the video of the bug (all the action starts at 35th second).
video_watch_from_35_s.mp4
26.5 MB Download

Comment 3 by vitaliii@chromium.org, Mar 2 2017 

Shorter video and on slower device with 3g wifi (better illustrates the problem).
on_moto_e_with_3g.mp4
3.4 MB View Download

Comment 4 by dewittj@chromium.org, Mar 2 2017

Cc: dewittj@chromium.org carlosk@chromium.org dim...@chromium.org
Components: UI>Browser>Offline

Comment 5 by dewittj@chromium.org, Mar 2 2017 

The disappearing tabs are due to us re-saving each time a tab is hidden, which is a fix to https://bugs.chromium.org/p/chromium/issues/detail?id=691506.  The right solution here seems to be adding a Replace/Update functionality to the offline page model.

Comment 6 by vitaliii@chromium.org, Mar 6 2017

Labels: -M-58 M-59

Comment 7 by fi...@chromium.org, Mar 14 2017

Labels: zine-triaged

Comment 8 by vitaliii@chromium.org, Jul 7 2017

Status: WontFix (was: Assigned)
►

Sign in to add a comment