Delete file in WebRtcAudioDebugRecordingsBrowserTest.CallWithAudioDebugRecordings fails on Win |
||||
Issue descriptionAfter https://chromium.googlesource.com/chromium/src/+/086a4113b499025bdd7db2c19a10bd8cd34a5997 WebRtcAudioDebugRecordingsBrowserTest.CallWithAudioDebugRecordings fails on https://build.chromium.org/p/chromium.webrtc/builders/Win10%20Tester/: e:\b\c\b\win_builder\src\content\browser\webrtc\webrtc_audio_debug_recordings_browsertest.cc(156): error: Value of: base::DeleteFile(file_path, false) Actual: false Expected: true e:\b\c\b\win_builder\src\content\browser\webrtc\webrtc_audio_debug_recordings_browsertest.cc(164): error: Value of: base::DeleteFile(file_path, false) Actual: false Expected: true e:\b\c\b\win_builder\src\content\browser\webrtc\webrtc_audio_debug_recordings_browsertest.cc(175): error: Value of: base::DeleteFile(file_path, false) Actual: false Expected: true e:\b\c\b\win_builder\src\content\browser\webrtc\webrtc_audio_debug_recordings_browsertest.cc(175): error: Value of: base::DeleteFile(file_path, false) Actual: false Expected: true e:\b\c\b\win_builder\src\content\browser\webrtc\webrtc_audio_debug_recordings_browsertest.cc(179): error: Value of: base::IsDirectoryEmpty(temp_dir_path) Actual: false Expected: true e:\b\c\b\win_builder\src\content\browser\webrtc\webrtc_audio_debug_recordings_browsertest.cc(180): error: Value of: base::DeleteFile(temp_dir_path, false) Actual: false Expected: true It's only that Win 10 bot. The ordinary Chromium bot is perfectly fine: https://chromegw.corp.google.com/i/chromium.win/builders/Win10%20Tests%20x64/builds/8808 The reason is the added expectation on base::DeleteFile() return value (i.e. success) in the CL. Short-term fix is to revert to not expect anything to get the bot green. It should be investigated why it happens. Is it a code issue? Bot issue? Test issue?
,
Mar 2 2017
OK, it's all Win bots in the WebRTC/Chromium waterfall. Maybe this test isn't run in the ordinary Chromium waterfall? Bots should go green now anyway.
,
Mar 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/66956e6ee256c827808b4dc4a05c32ab077747d5 commit 66956e6ee256c827808b4dc4a05c32ab077747d5 Author: grunell <grunell@chromium.org> Date: Thu Mar 02 15:00:29 2017 Fix WebRtcAudioDebugRecordingsBrowserTest (part 2). Missed one line in the original fix (https://codereview.chromium.org/2730713002). BUG= 697845 TBR=olka@chromium.org,guidou@chromium.org Review-Url: https://codereview.chromium.org/2726813004 Cr-Commit-Position: refs/heads/master@{#454257} [modify] https://crrev.com/66956e6ee256c827808b4dc4a05c32ab077747d5/content/browser/webrtc/webrtc_audio_debug_recordings_browsertest.cc
,
Mar 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f17dba87c0ba2b00022f524489987f209f90af7 commit 9f17dba87c0ba2b00022f524489987f209f90af7 Author: grunell <grunell@chromium.org> Date: Tue Mar 14 10:36:12 2017 Explicitly disable audio debug recordings in its browser test. This could perhaps fix one or both of the bugs. Regardless, this is a reasonable change to do anyway. BUG= 697845 ,700859 TBR=guidou@chromium.org Review-Url: https://codereview.chromium.org/2752513003 Cr-Commit-Position: refs/heads/master@{#456667} [modify] https://crrev.com/9f17dba87c0ba2b00022f524489987f209f90af7/content/browser/webrtc/webrtc_audio_debug_recordings_browsertest.cc
,
Mar 14 2017
This also fails on Mac, see https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/65966/steps/content_browsertests/logs/stdio.
,
Mar 17 2017
Re comment #5: that's another failure, tracked in issue 700859.
,
Mar 20 2017
I could repro this locally. I noticed that after ExecuteJavascriptAndWaitForOK(), the call is still running, hence files can't be deleted since already open. In my local test environment, the explicit disable added in revision 456667 closes the input and output files, but not the AEC dump file, in time. The AEC dump is in the render process so it takes longer before getting there. However, all files are subject of timing when closing. If navigating away (to same url) after disabling, I can't repro. Edward: Is there a function to stop a call? I couldn't find that looking in peerconnection-call.html.
,
Mar 20 2017
Doesn't look like there is. I think you could do something like the hangup() function in https://github.com/webrtc/samples/blob/gh-pages/src/content/peerconnection/constraints/js/main.js
,
Mar 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/558e1295655666d3e80365af85de9b27b912eb6d commit 558e1295655666d3e80365af85de9b27b912eb6d Author: grunell <grunell@chromium.org> Date: Tue Mar 21 11:56:33 2017 Hangup call in WebRtcAudioDebugRecordingsBrowserTest. This ensures files are released and can be deleted, thus re-adding expectations on file delete success. Added hangup() function to peerconnection-call.html. BUG= 697845 Review-Url: https://codereview.chromium.org/2764843002 Cr-Commit-Position: refs/heads/master@{#458375} [modify] https://crrev.com/558e1295655666d3e80365af85de9b27b912eb6d/content/browser/webrtc/webrtc_audio_debug_recordings_browsertest.cc [modify] https://crrev.com/558e1295655666d3e80365af85de9b27b912eb6d/content/test/data/media/peerconnection-call.html
,
Mar 21 2017
I'll wait for the bots to run this before closing.
,
Mar 22 2017
Looking good. |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Mar 2 2017