chromium-58 depends on unreleased libvpx API (VPXD_GET_LAST_QUANTIZER) |
|||||||
Issue descriptionThis is similar to earlier issue 575651 , issue 494939 , issue 347823 and issue 174287 , all of which have eventually been fixed. In file included from /usr/include/vpx/vpx_encoder.h:32:0, from ../../third_party/webrtc/modules/video_coding/codecs/vp8/vp8_impl.h:21, from ../../third_party/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:11: ../../third_party/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc: In member function ‘virtual int webrtc::VP8DecoderImpl::Decode(const webrtc::EncodedImage&, bool, const webrtc::RTPFragmentationHeader*, const webrtc::CodecSpecificInfo*, int64_t)’: ../../third_party/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:1150:35: error: ‘VPXD_GET_LAST_QUANTIZER’ was not declared in this scope vpx_codec_control(decoder_, VPXD_GET_LAST_QUANTIZER, &qp); ^ ../../third_party/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc:1150:7: error: ‘vpx_codec_control_VPXD_GET_LAST_QUANTIZER’ was not declared in this scope vpx_codec_control(decoder_, VPXD_GET_LAST_QUANTIZER, &qp); ^ This is with system libvpx-1.6.1.
,
Mar 6 2017
,
Mar 9 2017
sakal - can you check if this is still an issue?
,
Mar 10 2017
Unfortunately, this feature indeed is not included in libvpx 1.6.1 and is used by WebRTC. If we have to support libvpx 1.6.1, I guess we could drop support for QP sum on decoded streams for now. I could look into if there is a way to check the libvpx version at compile time and exclude this feature if it is an old version?
,
Mar 10 2017
Historically the way to go was to make a libvpx release that chromium can compile against. I don't think compile-time checks would be worth it. We already have a workaround of using bundled libvpx.
,
Mar 10 2017
Who would be the appropriate person to handle making this release?
,
Mar 14 2017
Johann, can you look into this?
,
Mar 14 2017
We have a number of potential API changes being looked at right now, including a new threading model. Until those stabilize, we do not anticipate making a new release. My guess at a target date would be around June.
,
Mar 15 2017
magnus - can you take a look?
,
Mar 15 2017
phajdan.jr@ - Is it ok to wait until June to solve this issue by making a new release? We use VPXD_GET_LAST_QUANTIZER to get QP stats in WebRTC, and that's import for us, so we want to keep it.
,
Apr 24 2017
Bumping to M60. Please correct if that's wrong.
,
Oct 24
Has this been fixed now? |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by guidou@chromium.org
, Mar 6 2017