Image chose screen: Camera selection disappear when clicked on it |
|||||||||
Issue descriptionChrome Version: (58.0.3029.0) What steps will reproduce the problem? (1) Login with the user which causes Image chose screen (2) Click on Camera option (the most left, up one (3) It disappear
,
Mar 3 2017
The first problem is that https://codereview.chromium.org/2666893002 adds "hasGaiaAccount" only for user image screen. (I reverted it though). Then, it looks like we have problem with camera access control: NavigatorUserMediaError . I look into it.
,
Mar 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ed71ca7437db67890fdc2848ff4edea9aa2b0cca commit ed71ca7437db67890fdc2848ff4edea9aa2b0cca Author: alemate <alemate@chromium.org> Date: Fri Mar 03 06:04:16 2017 Revert of Delete "Google Profile photo" for the Active Directory (patchset #2 id:20001 of https://codereview.chromium.org/2666893002/ ) Reason for revert: First, this has a race: CONTEXT_KEY_HAS_GAIA_ACCOUNT can (and actually does) come after CONTEXT_KEY_PROFILE_PICTURE_DATA_URL thus triggering exception: login.js:1208 Uncaught TypeError: Cannot read property 'title' of undefined at HTMLUnknownElement.updateItem (login.js:1208) at Array.<anonymous> (login.js:9504) at ScreenContext.applyChanges (login.js:538) at HTMLDivElement.contextChanged_ (login.js:329) at Object.api.contextChanged (login.js:424) at <anonymous>:1:23 Second, it breaks supervised user creation screen (and probably other screens that share user-image-grid object). BUG= 697842 , 682236 Original issue's description: > Delete "Google Profile photo" for the Active Directory > > Delete "Google Profile photo" choice from the image choice screen for > the Active Directory users. > > BUG= 682236 > TEST=manual > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Review-Url: https://codereview.chromium.org/2666893002 > Cr-Commit-Position: refs/heads/master@{#447513} > Committed: https://chromium.googlesource.com/chromium/src/+/33f901b2ff76e1d08d80e3ba5d1d079178cb4978 TBR=achuith@chromium.org,rsorokin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 682236 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2727953004 Cr-Commit-Position: refs/heads/master@{#454525} [modify] https://crrev.com/ed71ca7437db67890fdc2848ff4edea9aa2b0cca/chrome/browser/chromeos/login/screens/user_image_screen.cc [modify] https://crrev.com/ed71ca7437db67890fdc2848ff4edea9aa2b0cca/chrome/browser/resources/chromeos/login/oobe_screen_user_image.js
,
Mar 6 2017
Requesting merge for revert: ommit ed71ca7437db67890fdc2848ff4edea9aa2b0cca Author: alemate <alemate@chromium.org> Date: Fri Mar 03 06:04:16 2017 Revert of Delete "Google Profile photo" for the Active Directory (patchset #2 id:20001 of https://codereview.chromium.org/2666893002/ ) ... (See #3).
,
Mar 6 2017
This bug requires manual review: Reverts referenced in bugdroid comments after merge request. Please contact the milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 28 2017
Marking this as fixed. There is another Cl pending in an issue 701700 .
,
Mar 29 2017
Consider this approved for 58 if it is still necessary.
,
Mar 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/716621dd4c92357b9b93ae44603fbe53204e5bfd commit 716621dd4c92357b9b93ae44603fbe53204e5bfd Author: Alexander Alekseev <alemate@chromium.org> Date: Wed Mar 29 01:03:10 2017 Revert of Delete "Google Profile photo" for the Active Directory (patchset #2 id:20001 of https://codereview.chromium.org/2666893002/ ) Reason for revert: First, this has a race: CONTEXT_KEY_HAS_GAIA_ACCOUNT can (and actually does) come after CONTEXT_KEY_PROFILE_PICTURE_DATA_URL thus triggering exception: login.js:1208 Uncaught TypeError: Cannot read property 'title' of undefined at HTMLUnknownElement.updateItem (login.js:1208) at Array.<anonymous> (login.js:9504) at ScreenContext.applyChanges (login.js:538) at HTMLDivElement.contextChanged_ (login.js:329) at Object.api.contextChanged (login.js:424) at <anonymous>:1:23 Second, it breaks supervised user creation screen (and probably other screens that share user-image-grid object). BUG= 697842 , 682236 Original issue's description: > Delete "Google Profile photo" for the Active Directory > > Delete "Google Profile photo" choice from the image choice screen for > the Active Directory users. > > BUG= 682236 > TEST=manual > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Review-Url: https://codereview.chromium.org/2666893002 > Cr-Commit-Position: refs/heads/master@{#447513} > Committed: https://chromium.googlesource.com/chromium/src/+/33f901b2ff76e1d08d80e3ba5d1d079178cb4978 TBR=achuith@chromium.org,rsorokin@chromium.org BUG= 682236 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2727953004 Cr-Commit-Position: refs/heads/master@{#454525} (cherry picked from commit ed71ca7437db67890fdc2848ff4edea9aa2b0cca) Review-Url: https://codereview.chromium.org/2785593002 . Cr-Commit-Position: refs/branch-heads/3029@{#466} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/716621dd4c92357b9b93ae44603fbe53204e5bfd/chrome/browser/chromeos/login/screens/user_image_screen.cc [modify] https://crrev.com/716621dd4c92357b9b93ae44603fbe53204e5bfd/chrome/browser/resources/chromeos/login/oobe_screen_user_image.js
,
Apr 13 2017
9334.42.0, 58.0.3029.68)
,
May 24 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by achuith@chromium.org
, Mar 2 2017Owner: alemate@chromium.org