New issue
Advanced search Search tips

Issue 697837 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Menu icon is not displayed for the text in Reading list screen when the device is in landscape mode.

Project Member Reported by pmadalla@chromium.org, Mar 2 2017

Issue description

App Version: 58.0.3026.0 canary
iOS Version: 9.3.5,iOS 10
Device : iPhone 7+,6+,6s+ only

Steps to reproduce:
1. Install and launch chrome in landscape mode.
2. Tap on Menu > Reading list.

Observed results:
Menu icon is not displayed for the text in landscape mode.
 
Expected results:
Menu Icon should be displayed for the text in reading list screen.
Text displayed in reading list should be same in portrait and landscape mode.

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: NA
Bug reproducible on Dolphin/Safari/Firefox: Safari : NA
Bug reproducible on current stable build (App Version, iOS Version): No,new UI
Bug reproducible on the current beta channel build (App Version, iOS Version): Yes in M57

Link to Video :
https://drive.google.com/a/google.com/file/d/0B--UpU2GW2EpVjRSMEk0RUFOTms/view?usp=sharing

 
Labels: -found-in-M57 found-in-m58
Components: UI>Browser>ReaderMode
Owner: gambard@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70079b5955de2a047669c39938839851fb107b44

commit 70079b5955de2a047669c39938839851fb107b44
Author: gambard <gambard@chromium.org>
Date: Mon Mar 06 13:37:16 2017

Display menu icon in iPhone X+ in landscape

BUG= 697837 ,  698726 

Review-Url: https://codereview.chromium.org/2732993002
Cr-Commit-Position: refs/heads/master@{#454861}

[modify] https://crrev.com/70079b5955de2a047669c39938839851fb107b44/ios/chrome/browser/ui/reading_list/reading_list_empty_collection_background.mm

Status: Fixed (was: Assigned)
Cc: olivierrobin@chromium.org
Labels: M-58 Merge-Request-58
Project Member

Comment 6 by sheriffbot@chromium.org, Mar 7 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 7 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71e8c8e8d90be82630097c95d17e18d41c91be3a

commit 71e8c8e8d90be82630097c95d17e18d41c91be3a
Author: gambard <gambard@chromium.org>
Date: Tue Mar 07 09:11:15 2017

Display menu icon in iPhone X+ in landscape

BUG= 697837 ,  698726 

Review-Url: https://codereview.chromium.org/2732993002
Cr-Commit-Position: refs/heads/master@{#454861}
(cherry picked from commit 70079b5955de2a047669c39938839851fb107b44)

Review-Url: https://codereview.chromium.org/2736893002 .
Cr-Commit-Position: refs/branch-heads/3029@{#39}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/71e8c8e8d90be82630097c95d17e18d41c91be3a/ios/chrome/browser/ui/reading_list/reading_list_empty_collection_background.mm

Status: Verified (was: Fixed)
Verified the issue on the beta 58.0.3029.19 tested on iPhone7+(iOS 10).
Menu icon is displayed in reading list in landscape mode,looks good.
Verified the issue on the 59.0.3047.0 Canary, tested on iPhone6+(iOS 10).
Menu icon in reading list is displaying fine in landscape mode.

Sign in to add a comment