New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 697830 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

!frame || BindingSecurity::shouldAllowAccessToFrame( toDOMWindow(function->Creat

Project Member Reported by ClusterFuzz, Mar 2 2017

Issue description

Cc: msrchandra@chromium.org
Labels: Test-Predator-Wrong M-58
Owner: jochen@chromium.org
Status: Assigned (was: Untriaged)
Predator did not find any possible suspects.
Assigning to the concern owner from CL --
https://chromium.googlesource.com/chromium/src/+log/25a3df81a5b7b5a8684e7f5c423fb86d0776d986..695f49f69873b3678a1233e42349f70882adaf47?pretty=fuller

Suspecting Commit#
https://chromium.googlesource.com/chromium/src/+/5cde67543e5c89f1f9da84e1ae860c30283dee3c

@jochen -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.
Cc: haraken@chromium.org jochen@chromium.org
Components: Blink>XML
Owner: adithyas@chromium.org
any idea who owns the XML tree viewer?

in https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp?rcl=f193ee6d21e6548ed425746ec80fb71faa7998a5&l=1549 we turn an XML document without a stylesheet into viewer mode, but don't clear script references to it. Setting viewer mode makes the security origin "opaque", i.e., it should not be accessible to other origins anymore. The clusterfuzz issue demonstrates that this is not the case
I don't think anyone is currently working on XML tree viewer.

adithyas@: Would you mind taking a look at this?

I think there are two possible solutions

- if the XML tree viewer indeed modifies the DOM, we'll need to scrape the document (as if it was a navigation) to make sure all ties are cut

- if the XML tree viewer is a pure UI thing, and the parsed XML tree is supposed to be still accessible by outside script, we'll have to ensure that the security origin isn't replaced with an opaque one
Cc: dcheng@chromium.org
> - if the XML tree viewer is a pure UI thing, and the parsed XML tree is supposed to be still accessible by outside script, we'll have to ensure that the security origin isn't replaced with an opaque one

I think this makes more sense.

dcheng@: Any thoughts on this?

Cc: creis@chromium.org japhet@chromium.org
Wow... it seems kind of insane that we just switch over to view-source mode if we don't see any XSLT, etc.

https://chromium.googlesource.com/chromium/src/+/c92a57f13f7b09b68e5c0534129f23eba148ac5c is the commit that put view-source documents in an opaque origin. I guess we could skip the opaque origin if scripts aren't disabled...?
Is anyone still able to access the clusterfuzz test case? I keep getting a "file does not exist"

Comment 8 by jochen@chromium.org, Mar 14 2017

it works for me - can you ping aarya@ and ask for help?
Project Member

Comment 10 by ClusterFuzz, Mar 18 2017

ClusterFuzz has detected this issue as fixed in range 456626:457730.

Detailed report: https://clusterfuzz.com/testcase?key=6654154803249152

Fuzzer: inferno_layout_test_unmodified
Job Type: linux_debug_content_shell_drt
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  !frame || BindingSecurity::shouldAllowAccessToFrame( toDOMWindow(function->Creat
  blink::V8ScriptRunner::callFunction
  blink::V8EventListener::callListenerFunction
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_debug_content_shell_drt&range=451616:451629
Fixed: https://clusterfuzz.com/revisions?job=linux_debug_content_shell_drt&range=456626:457730

Reproducer Testcase: https://clusterfuzz.com/download/AMIfv978sk_EpkKqIH8f_OS83lUEDBOQyFpEYHPUUKV7WAQi84QQubtg6qM5oa9sOhtcSlb8yUOcSkVXoCnKyBI3Einx2r-yu0iyQEPL0Do9DBtIBW91vtZsSlzOnjMlQdw-IgQROe6AzDb05PFCJjOQTplQjvCk0FFMoSrTLQ9gTC7GatqkvatxMvcc200xUiY9bKI-t3hdAz-zNUwSmlYLorzNMx1Vva7Rjus6AoaDUFlvWzFbkY7ehzz9kxtzrV4nKDYbZ_BLmF_7EqGDJ8ZL3YkHWMw58VqjpMScZEnIm_bc2m8PO8zGW_Yil5R6-LZi7MVyNMX9diEpL-fnjsJ0hai02Vz_il3puFBbkm390LI_AVa0xmYLOcKvzbl3a4aqer8uC4m9k4b24CgSXptMqPlVOA6Cow?testcase_id=6654154803249152


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 11 by ClusterFuzz, Mar 18 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6654154803249152 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment