Issue metadata
Sign in to add a comment
|
DCHECK failure in PermissionUmaUtil::PermissionRequested() |
||||||||||||||||||||||||
Issue description[32973:32973:0302/171511.550967:FATAL:permission_uma_util.cc(131)] Check failed: success. #0 0x7f18d21072b7 base::debug::StackTrace::StackTrace() #1 0x7f18d212b65b logging::LogMessage::~LogMessage() #2 0x7f18d3087b5b PermissionUmaUtil::PermissionRequested() #3 0x7f18d30809ae PermissionManager::RequestPermissions() #4 0x7f18d3081172 PermissionManager::RequestPermission() #5 0x7f18cfab402d content::PermissionServiceImpl::RequestPermission() #6 0x7f18cf69ede3 blink::mojom::PermissionServiceStubDispatch::AcceptWithResponder() #7 0x7f18d26782da mojo::InterfaceEndpointClient::HandleValidatedMessage() #8 0x7f18d2677a16 mojo::FilterChain::Accept() #9 0x7f18d267954e mojo::InterfaceEndpointClient::HandleIncomingMessage() #10 0x7f18d268203b mojo::internal::MultiplexRouter::ProcessIncomingMessage() #11 0x7f18d268190f mojo::internal::MultiplexRouter::Accept() #12 0x7f18d2677a16 mojo::FilterChain::Accept() #13 0x7f18d2673ca2 mojo::Connector::ReadSingleMessage() #14 0x7f18d2674331 mojo::Connector::OnHandleReadyInternal() #15 0x7f18d26587d2 mojo::Watcher::OnHandleReady() #16 0x7f18d2658934 _ZN4base8internal13FunctorTraitsIMN4mojo7WatcherEFvjEvE6InvokeIRKNS_7WeakPtrIS3_EEJRKjEEEvS5_OT_DpOT0_ #17 0x7f18d2107d99 base::debug::TaskAnnotator::RunTask() #18 0x7f18d2138aed base::MessageLoop::RunTask() #19 0x7f18d21391d6 base::MessageLoop::DoWork() #20 0x7f18d213b3fa base::(anonymous namespace)::WorkSourceDispatch() #21 0x7f18cb190e04 g_main_context_dispatch #22 0x7f18cb191048 <unknown> #23 0x7f18cb1910ec g_main_context_iteration #24 0x7f18d213b156 base::MessagePumpGlib::Run() #25 0x7f18d213883e base::MessageLoop::RunHandler() #26 0x7f18d216d39c base::RunLoop::Run() #27 0x7f18d3334c3a ChromeBrowserMainParts::MainMessageLoopRun() #28 0x7f18cf82aee9 content::BrowserMainLoop::RunMainMessageLoopParts() #29 0x7f18cf82ed87 content::BrowserMainRunnerImpl::Run() #30 0x7f18cf8260ae content::BrowserMain() #31 0x7f18d00470a3 content::RunNamedProcessTypeMain() #32 0x7f18d00479b6 content::ContentMainRunnerImpl::Run() #33 0x7f18d00462d0 content::ContentMain() #34 0x7f18d2c32e81 ChromeMain #35 0x7f18c879cf45 __libc_start_main #36 0x7f18d2c32d19 <unknown> ---- How to repro: launch chrome and visit yuri.twintail.org/chrome/midi/midi.html I guess Web MIDI permission is not handled correctly here.
,
Mar 2 2017
,
Mar 2 2017
This is just becase PermissionUtil::GetPermissionType does not handle the MIDI. I can send a fix for review.
,
Mar 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b0d271768d0a592227d753f4cf60399c4dd2af4f commit b0d271768d0a592227d753f4cf60399c4dd2af4f Author: toyoshim <toyoshim@chromium.org> Date: Thu Mar 02 11:02:55 2017 PermissionUtil::GetPermissionType needs to handle MIDI After the recent PermissionManager's change, it calls GetPermissionType even for CONTENT_SETTING_TYPE_MIDI. BUG= 697771 Review-Url: https://codereview.chromium.org/2730693002 Cr-Commit-Position: refs/heads/master@{#454231} [modify] https://crrev.com/b0d271768d0a592227d753f4cf60399c4dd2af4f/chrome/browser/permissions/permission_util.cc
,
Mar 3 2017
ok, this seems to be submitted before the branch cut :) |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by toyoshim@chromium.org
, Mar 2 2017Components: Blink>WebMIDI Internals>Permissions
Labels: -Pri-3 M-58 OS-All Pri-2
Owner: timloh@chromium.org
Status: Assigned (was: Untriaged)