New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 697751 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 21
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-04-10
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Scroll Bar appears behind the contents of chrome://settings page after resizing browser.

Reported by lpa...@etouch.net, Mar 2 2017

Issue description

Chrome Version: 58.0.3028.0 (Official Build) c49428ef69cfd173c5d7eaeb39982f44ca68da78-refs/heads/master@{#454140} (32/64 Bit)

OS:  Windows(7,8,8.1,10).

Steps to reproduce:
1. Launch Chrome, resize the window, open chrome://settings from Wrench Icon.
2. Observe the scroll bar.

Actual Result: Scroll Bar appears behind the contents of chrome://settings page after resizing browser.
Expected Result: Scroll Bar should appear properly.

This is regression issue broken in 'M 58' and will soon update the bisect info:

Manual Bisect Info: 
Good Build: 58.0.3027.0
Bad Build: 58.0.3028.0

Note: Will soon update Linux and Mac OS status once build 58.0.3028.0 is available.
 
Actual Result.mp4
733 KB View Download
Expected Result.mp4
747 KB View Download

Comment 1 by lpa...@etouch.net, Mar 2 2017

Cc: nyerramilli@chromium.org
Labels: -Pri-2 hasbisect-per-revision ReleaseBlock-Stable Pri-1
Owner: szager@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce this issue on Mac OS 10.12 and Ubuntu 14.04 as well.

Bisect Information:
---------------------
Using the per-revision bisect providing the bisect results,

You are probably looking for a change made after 454104 (known good), but no later than 454105 (first known bad).

CHANGE-LOG URL:
-----------------
https://chromium.googlesource.com/chromium/src/+log/d25c0f20455f2a7399ffa9e097b0c14f25e18d40..5a729d1bc790d94120ec942a4566bb85f969cdb1

From the CL above, assigning the issue to the concern owner
Review-Url: https://codereview.chromium.org/2725763002

szager@ Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!

Comment 3 by lpa...@etouch.net, Mar 2 2017

Labels: OS-Linux OS-Mac
Issue also reproducible on Mac(10.11.6, 10.12.1, 10.12) and Linux(14.04 LTS) OS in build #58.0.3028.0.
Cc: durga.behera@chromium.org szager@chromium.org rbasuvula@chromium.org ajha@chromium.org kavvaru@chromium.org brajkumar@chromium.org
 Issue 698170  has been merged into this issue.
Labels: Needs-triage-Mobile
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ab46eae8507137607e258543118ef8fb04984de

commit 7ab46eae8507137607e258543118ef8fb04984de
Author: szager <szager@chromium.org>
Date: Wed Mar 15 23:04:45 2017

Fix overflow:overlay scrollbar width for paint.

This CL went too far:

https://codereview.chromium.org/2725763002

Some callers to verticalScrollbarWidth -- in particular, the paint
code -- need the old behavior, where overflow:overlay scrollbars
are subtracted from the overflow clip rect.

BUG= 697751 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2730343003
Cr-Commit-Position: refs/heads/master@{#457251}

[modify] https://crrev.com/7ab46eae8507137607e258543118ef8fb04984de/third_party/WebKit/LayoutTests/platform/linux/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt
[modify] https://crrev.com/7ab46eae8507137607e258543118ef8fb04984de/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt
[modify] https://crrev.com/7ab46eae8507137607e258543118ef8fb04984de/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt
[modify] https://crrev.com/7ab46eae8507137607e258543118ef8fb04984de/third_party/WebKit/LayoutTests/platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt
[modify] https://crrev.com/7ab46eae8507137607e258543118ef8fb04984de/third_party/WebKit/LayoutTests/platform/win/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt
[modify] https://crrev.com/7ab46eae8507137607e258543118ef8fb04984de/third_party/WebKit/LayoutTests/virtual/prefer_compositing_to_lcd_text/compositing/overflow/overflow-overlay-with-touch-expected.txt
[modify] https://crrev.com/7ab46eae8507137607e258543118ef8fb04984de/third_party/WebKit/Source/core/frame/RootFrameViewport.h
[modify] https://crrev.com/7ab46eae8507137607e258543118ef8fb04984de/third_party/WebKit/Source/core/layout/LayoutBox.h
[modify] https://crrev.com/7ab46eae8507137607e258543118ef8fb04984de/third_party/WebKit/Source/core/layout/LayoutTable.h
[modify] https://crrev.com/7ab46eae8507137607e258543118ef8fb04984de/third_party/WebKit/Source/core/layout/LayoutView.h
[modify] https://crrev.com/7ab46eae8507137607e258543118ef8fb04984de/third_party/WebKit/Source/core/layout/api/LayoutBoxItem.h
[modify] https://crrev.com/7ab46eae8507137607e258543118ef8fb04984de/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/7ab46eae8507137607e258543118ef8fb04984de/third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp
[modify] https://crrev.com/7ab46eae8507137607e258543118ef8fb04984de/third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.h
[modify] https://crrev.com/7ab46eae8507137607e258543118ef8fb04984de/third_party/WebKit/Source/core/paint/ClipRectsCache.h
[modify] https://crrev.com/7ab46eae8507137607e258543118ef8fb04984de/third_party/WebKit/Source/core/paint/PaintLayer.h
[modify] https://crrev.com/7ab46eae8507137607e258543118ef8fb04984de/third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp
[modify] https://crrev.com/7ab46eae8507137607e258543118ef8fb04984de/third_party/WebKit/Source/core/paint/PaintLayerClipper.h
[modify] https://crrev.com/7ab46eae8507137607e258543118ef8fb04984de/third_party/WebKit/Source/core/paint/PaintLayerClipperTest.cpp
[modify] https://crrev.com/7ab46eae8507137607e258543118ef8fb04984de/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
[modify] https://crrev.com/7ab46eae8507137607e258543118ef8fb04984de/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/7ab46eae8507137607e258543118ef8fb04984de/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h
[modify] https://crrev.com/7ab46eae8507137607e258543118ef8fb04984de/third_party/WebKit/Source/platform/scroll/ScrollTypes.h
[modify] https://crrev.com/7ab46eae8507137607e258543118ef8fb04984de/third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp
[modify] https://crrev.com/7ab46eae8507137607e258543118ef8fb04984de/third_party/WebKit/Source/platform/scroll/ScrollableArea.h

Project Member

Comment 7 by bugdroid1@chromium.org, Mar 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/939b298311ed40bf5752b47db5e7a2b2d9db3431

commit 939b298311ed40bf5752b47db5e7a2b2d9db3431
Author: tzik <tzik@chromium.org>
Date: Thu Mar 16 02:29:20 2017

Revert of Fix overflow:overlay scrollbar width for paint. (patchset #6 id:100001 of https://codereview.chromium.org/2730343003/ )

Reason for revert:
A layout test gets red after this CL due to the mismatched test expectation.

The error log is:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28retina%29/builds/13521
fast/overflow/scroll-nested-positioned-layer-in-overflow.html

Original issue's description:
> Fix overflow:overlay scrollbar width for paint.
>
> This CL went too far:
>
> https://codereview.chromium.org/2725763002
>
> Some callers to verticalScrollbarWidth -- in particular, the paint
> code -- need the old behavior, where overflow:overlay scrollbars
> are subtracted from the overflow clip rect.
>
> BUG= 697751 
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Review-Url: https://codereview.chromium.org/2730343003
> Cr-Commit-Position: refs/heads/master@{#457251}
> Committed: https://chromium.googlesource.com/chromium/src/+/7ab46eae8507137607e258543118ef8fb04984de

TBR=pdr@chromium.org,skobes@chromium.org,szager@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 697751 

Review-Url: https://codereview.chromium.org/2749863006
Cr-Commit-Position: refs/heads/master@{#457322}

[modify] https://crrev.com/939b298311ed40bf5752b47db5e7a2b2d9db3431/third_party/WebKit/LayoutTests/platform/linux/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt
[modify] https://crrev.com/939b298311ed40bf5752b47db5e7a2b2d9db3431/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt
[modify] https://crrev.com/939b298311ed40bf5752b47db5e7a2b2d9db3431/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt
[modify] https://crrev.com/939b298311ed40bf5752b47db5e7a2b2d9db3431/third_party/WebKit/LayoutTests/platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt
[modify] https://crrev.com/939b298311ed40bf5752b47db5e7a2b2d9db3431/third_party/WebKit/LayoutTests/platform/win/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt
[modify] https://crrev.com/939b298311ed40bf5752b47db5e7a2b2d9db3431/third_party/WebKit/LayoutTests/virtual/prefer_compositing_to_lcd_text/compositing/overflow/overflow-overlay-with-touch-expected.txt
[modify] https://crrev.com/939b298311ed40bf5752b47db5e7a2b2d9db3431/third_party/WebKit/Source/core/frame/RootFrameViewport.h
[modify] https://crrev.com/939b298311ed40bf5752b47db5e7a2b2d9db3431/third_party/WebKit/Source/core/layout/LayoutBox.h
[modify] https://crrev.com/939b298311ed40bf5752b47db5e7a2b2d9db3431/third_party/WebKit/Source/core/layout/LayoutTable.h
[modify] https://crrev.com/939b298311ed40bf5752b47db5e7a2b2d9db3431/third_party/WebKit/Source/core/layout/LayoutView.h
[modify] https://crrev.com/939b298311ed40bf5752b47db5e7a2b2d9db3431/third_party/WebKit/Source/core/layout/api/LayoutBoxItem.h
[modify] https://crrev.com/939b298311ed40bf5752b47db5e7a2b2d9db3431/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/939b298311ed40bf5752b47db5e7a2b2d9db3431/third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp
[modify] https://crrev.com/939b298311ed40bf5752b47db5e7a2b2d9db3431/third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.h
[modify] https://crrev.com/939b298311ed40bf5752b47db5e7a2b2d9db3431/third_party/WebKit/Source/core/paint/ClipRectsCache.h
[modify] https://crrev.com/939b298311ed40bf5752b47db5e7a2b2d9db3431/third_party/WebKit/Source/core/paint/PaintLayer.h
[modify] https://crrev.com/939b298311ed40bf5752b47db5e7a2b2d9db3431/third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp
[modify] https://crrev.com/939b298311ed40bf5752b47db5e7a2b2d9db3431/third_party/WebKit/Source/core/paint/PaintLayerClipper.h
[modify] https://crrev.com/939b298311ed40bf5752b47db5e7a2b2d9db3431/third_party/WebKit/Source/core/paint/PaintLayerClipperTest.cpp
[modify] https://crrev.com/939b298311ed40bf5752b47db5e7a2b2d9db3431/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
[modify] https://crrev.com/939b298311ed40bf5752b47db5e7a2b2d9db3431/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/939b298311ed40bf5752b47db5e7a2b2d9db3431/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h
[modify] https://crrev.com/939b298311ed40bf5752b47db5e7a2b2d9db3431/third_party/WebKit/Source/platform/scroll/ScrollTypes.h
[modify] https://crrev.com/939b298311ed40bf5752b47db5e7a2b2d9db3431/third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp
[modify] https://crrev.com/939b298311ed40bf5752b47db5e7a2b2d9db3431/third_party/WebKit/Source/platform/scroll/ScrollableArea.h

Project Member

Comment 8 by bugdroid1@chromium.org, Mar 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b9f74d82a9b9dd130ec4eb0357859fc8cbaa439

commit 2b9f74d82a9b9dd130ec4eb0357859fc8cbaa439
Author: szager <szager@chromium.org>
Date: Thu Mar 16 04:51:11 2017

Fix overflow:overlay scrollbar width for paint.

Re-landing this change:

https://codereview.chromium.org/2730343003/

... along with the missing test expectations.

TBR=tzik@chromium.org
BUG= 697751 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2757533002
Cr-Commit-Position: refs/heads/master@{#457353}

[modify] https://crrev.com/2b9f74d82a9b9dd130ec4eb0357859fc8cbaa439/third_party/WebKit/LayoutTests/platform/linux/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt
[modify] https://crrev.com/2b9f74d82a9b9dd130ec4eb0357859fc8cbaa439/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt
[modify] https://crrev.com/2b9f74d82a9b9dd130ec4eb0357859fc8cbaa439/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt
[modify] https://crrev.com/2b9f74d82a9b9dd130ec4eb0357859fc8cbaa439/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt
[modify] https://crrev.com/2b9f74d82a9b9dd130ec4eb0357859fc8cbaa439/third_party/WebKit/LayoutTests/platform/mac-retina/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt
[modify] https://crrev.com/2b9f74d82a9b9dd130ec4eb0357859fc8cbaa439/third_party/WebKit/LayoutTests/platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt
[modify] https://crrev.com/2b9f74d82a9b9dd130ec4eb0357859fc8cbaa439/third_party/WebKit/LayoutTests/platform/win/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt
[modify] https://crrev.com/2b9f74d82a9b9dd130ec4eb0357859fc8cbaa439/third_party/WebKit/LayoutTests/virtual/prefer_compositing_to_lcd_text/compositing/overflow/overflow-overlay-with-touch-expected.txt
[modify] https://crrev.com/2b9f74d82a9b9dd130ec4eb0357859fc8cbaa439/third_party/WebKit/Source/core/frame/RootFrameViewport.h
[modify] https://crrev.com/2b9f74d82a9b9dd130ec4eb0357859fc8cbaa439/third_party/WebKit/Source/core/layout/LayoutBox.h
[modify] https://crrev.com/2b9f74d82a9b9dd130ec4eb0357859fc8cbaa439/third_party/WebKit/Source/core/layout/LayoutTable.h
[modify] https://crrev.com/2b9f74d82a9b9dd130ec4eb0357859fc8cbaa439/third_party/WebKit/Source/core/layout/LayoutView.h
[modify] https://crrev.com/2b9f74d82a9b9dd130ec4eb0357859fc8cbaa439/third_party/WebKit/Source/core/layout/api/LayoutBoxItem.h
[modify] https://crrev.com/2b9f74d82a9b9dd130ec4eb0357859fc8cbaa439/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/2b9f74d82a9b9dd130ec4eb0357859fc8cbaa439/third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp
[modify] https://crrev.com/2b9f74d82a9b9dd130ec4eb0357859fc8cbaa439/third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.h
[modify] https://crrev.com/2b9f74d82a9b9dd130ec4eb0357859fc8cbaa439/third_party/WebKit/Source/core/paint/ClipRectsCache.h
[modify] https://crrev.com/2b9f74d82a9b9dd130ec4eb0357859fc8cbaa439/third_party/WebKit/Source/core/paint/PaintLayer.h
[modify] https://crrev.com/2b9f74d82a9b9dd130ec4eb0357859fc8cbaa439/third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp
[modify] https://crrev.com/2b9f74d82a9b9dd130ec4eb0357859fc8cbaa439/third_party/WebKit/Source/core/paint/PaintLayerClipper.h
[modify] https://crrev.com/2b9f74d82a9b9dd130ec4eb0357859fc8cbaa439/third_party/WebKit/Source/core/paint/PaintLayerClipperTest.cpp
[modify] https://crrev.com/2b9f74d82a9b9dd130ec4eb0357859fc8cbaa439/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
[modify] https://crrev.com/2b9f74d82a9b9dd130ec4eb0357859fc8cbaa439/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/2b9f74d82a9b9dd130ec4eb0357859fc8cbaa439/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h
[modify] https://crrev.com/2b9f74d82a9b9dd130ec4eb0357859fc8cbaa439/third_party/WebKit/Source/platform/scroll/ScrollTypes.h
[modify] https://crrev.com/2b9f74d82a9b9dd130ec4eb0357859fc8cbaa439/third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp
[modify] https://crrev.com/2b9f74d82a9b9dd130ec4eb0357859fc8cbaa439/third_party/WebKit/Source/platform/scroll/ScrollableArea.h

Labels: TE-Verified-M59 TE-verified-59.0.3046.0
Verified the above issue on Windows(7,8,8.1,10),Mac(10.11.6, 10.12.1, 10.12) and Linux(14.04 LTS) OS on #59.0.3046.0 The issue has been fixed and is working as intended.
 Issue 701285  has been merged into this issue.
This is fixed in M59.  It's probably not a good candidate to merge into M58.
 Issue 692076  has been merged into this issue.
I can still reproduce  Issue 692076  on Canary 59 on macOS.
With respect to the label added: Needs-triage-Mobile, triaged the issue and below are the observations.

Chrome Version# 58.0.3029.21
OS: Android 7.1.1; Nexus 5X/Build: N4F260

Issue cannot be tested on Mobile as chrome://md-settings or chrome://settings are different in Mobile Chrome Browser.

Note: Re-sizing of browser(MultiWindow option) can be done in devices with Android version above or equal to Nougat version.
Thank You.

Can  Issue 692076  be opened again? This issue is about your specific settings page, you can fix it without actually fixing the underlying issue (that's what you actually did I think).

My issue is about the real rendering issue and is still there.
As you see in the clip, the bug is still there.

Codepen to reproduce it:
https://codepen.io/FezVrasta/pen/pRGxrx
bug.gif
167 KB View Download
Able to reproduce the issue mentioned in  Issue 692076  in Mac 10.12.3 using latest canary #59.0.3061.0.

 Issue 692076  seems to be a different issue compared to Issue id: 697751.

As per comment #16, could you please have a look into this issue.

Thanks...!!
szager@ - As per comment #16, could you please have a look into this issue.

Thanks...!!
NextAction: 2017-04-10
A friendly reminder that M58 Stable launch is coming soon! Your bug is labelled as Stable ReleaseBlock, please make sure to land the fix, verified in trunk and get it merged into the release branch ASAP.
A friendly reminder that M58 Stable is launch is coming soon (less than 2 weeks)! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP so it gets enough baking time in Beta (before Stable promotion). Thank you!
@Szager-- Could you please provide us an update on the issue as per comment #16.
Labels: -ReleaseBlock-Stable
I am unable to reproduce the original issue in #0 and the testcase in #16 in both canary- 59.0.3070.0  and Beta- 58.0.3029.68.

Removing RBS.
I am still able to reproduce it.

It's lame that I have to test this bug on each comment from the Chromium contributors because someone will wrongly mark it as resolved for some reason.
bug.gif
227 KB View Download
I can't reproduce the original issue (#0), but as I said few posts before, it was probably fixed thanks to some CSS or markup change.

To me it's okay to reopen  Issue 692076  to track the real bug, and use this one to track the layout problem of the settings page.

Labels: -Needs-triage-Mobile
Status: Fixed (was: Assigned)

Sign in to add a comment