New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 697747 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Compat



Sign in to add a comment

Text doesn't get selected after tapping on select all option in "Pocket app".

Reported by pshi...@etouch.net, Mar 2 2017

Issue description

Device name: Pixel XL/NOF26V,Nexus 5X/N4F26O,Htc Desire 630/MMB29M,Samsung Galaxy J5/MMB29M,Gionee F103/LRX21M
WebView version: 58.0.3026.5
Application: Pocket 
Application version: 6.4.8.4

URLs : https://play.google.com/store/apps/details?id=com.ideashower.readitlater.pro&hl=en

Bisect Information :

Per-Version bisect information:
Good build: 58.0.3018.0
Bad build:  58.0.3019.0
Regression range: https://chromium.googlesource.com/chromium/src/+log/58.0.3018.0..58.0.3019.0?pretty=fuller&n=10000

Steps to reproduce:
(1)Launch 'Pocket' app,sign in with valid credentials
(2)Open any article,Long tap for text selection and tap on select all
(3)Observe

Expected result: Text selection should be done properly after tapping on select all option.

Actual result:   Text doesn't get selected at all after tapping on select all option.



 
Labels: -Pri-3 M-58 Pri-1 Type-Bug-Regression
Status: Available (was: Unconfirmed)
Please find the Video & Logcat @ go/chrome-androidlogs1/6/697747
Owner: tkent@chromium.org
Status: Assigned (was: Available)
Per-CL bisect information:
Good commit:451580
Bad commit:451581

Culprit CL:
https://chromium.googlesource.com/chromium/src/+/552ceb6deed19e86f89eb32b8fb3923217cefd7e

tkent@  It looks like this issue is related to your change. please look into once, if its not related to your change please reassign to me. 
Thanks
Labels: ReleaseBlock-Stable

Comment 4 by tkent@chromium.org, Mar 2 2017

Cc: tkent@chromium.org
Labels: -ReleaseBlock-Stable -M-58 Needs-Evangelism
Owner: ----
Status: Available (was: Assigned)
> https://chromium.googlesource.com/chromium/src/+/552ceb6deed19e86f89eb32b8fb3923217cefd7e

This is an intentional change.  Can we contact a developer of Pocket app?

Comment 5 by aluo@chromium.org, Mar 3 2017

what does the change do?  It may affect many apps, how does the app developer fix the problem?  Usually we don't want to break existing apps.

Comment 6 by tkent@chromium.org, Mar 3 2017

An application needs to call Selection.removeAllRanges() before Selection.addRange().

I don't think the addRange() behavior change will break many applications.  Applications rarely implement their own text selection features.

Comment 7 by ti...@chromium.org, Mar 13 2017

Cc: -tkent@chromium.org sgu...@chromium.org yochen@chromium.org
Owner: tkent@chromium.org
A message from WebView bugcop: it seems there is an agreement in the  Issue 353069  that this change is needed, yet this particular app does seem broken.
tkent@, may I ask you to contact the app author and explain the rationale and what they need to do?

Comment 8 by ti...@chromium.org, Mar 13 2017

Cc: -yochen@chromium.org yosin@chromium.org

Comment 9 by tkent@chromium.org, Mar 13 2017

Labels: -Restrict-View-Google -Pri-1 -Type-Bug-Regression Pri-3 Type-Compat
Status: Started (was: Available)
ok, I'll try to contact.

Thanks for letting us know about this. Seems like an easy fix. Is there an easy way for us to test this? Some way to test our app on this new version?

Comment 11 by tkent@chromium.org, Mar 16 2017

#10,
Please follow https://www.chromium.org/developers/androidwebview/android-webview-beta .
I think we'll push WebView beta based on Chromium M58 soon.

Comment 12 by tkent@chromium.org, May 29 2017

Status: ExternalDependency (was: Started)
Status: Verified (was: ExternalDependency)
Issue doesn't repro on latest M60: 60.0.3112.72.
Thanks!

Sign in to add a comment