New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 697741 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 685393



Sign in to add a comment

Remove --arc-availability=installed-only-kiosk-supported option

Project Member Reported by elijahtaylor@chromium.org, Mar 2 2017

Issue description

ARC kiosk mode can be enabled when ARC support is built into a particular board.  We do not need an additional state of --arc-availability to control this, which would then require additional plumbing from Chrome OS via a USE flag.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67e99111e67ac5aeae011a14154e054160bf98c4

commit 67e99111e67ac5aeae011a14154e054160bf98c4
Author: elijahtaylor <elijahtaylor@chromium.org>
Date: Thu Mar 02 20:13:42 2017

Enable ARC kiosk mode always when ARC is available

This removes 'installed-only-kiosk-supported' from arc-availability

BUG= 697741 
TEST=./unit_tests --gtest_filter="ChromeArcUtilTest.*"
TEST=./components_unittests --gtest_filter="ArcUtilTest.*"

Review-Url: https://codereview.chromium.org/2725113002
Cr-Commit-Position: refs/heads/master@{#454360}

[modify] https://crrev.com/67e99111e67ac5aeae011a14154e054160bf98c4/chrome/browser/chromeos/arc/arc_util_unittest.cc
[modify] https://crrev.com/67e99111e67ac5aeae011a14154e054160bf98c4/chromeos/chromeos_switches.cc
[modify] https://crrev.com/67e99111e67ac5aeae011a14154e054160bf98c4/components/arc/arc_util.cc
[modify] https://crrev.com/67e99111e67ac5aeae011a14154e054160bf98c4/components/arc/arc_util_unittest.cc

Labels: Merge-Request-57
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 3 2017

Labels: -Merge-Request-57 Hotlist-Merge-Review Merge-Review-57
This bug requires manual review: We are only 10 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: keta...@chromium.org
Ketaki,

This is a small change related to issue 685393 which was already merged.  We need this to enable ARC kiosk mode for M57 (the alternative was to change USE flags on Chrome OS side, but that is higher complexity).

Here is the proposed merge CL: https://codereview.chromium.org/2730003002 (note this was pretty manual because of a large refactor in M-58, but the change is very small)


Comment 5 by ketakid@google.com, Mar 4 2017

Labels: -Merge-Review-57 Merge-Approved-57
Approving merge to M57 Chrome OS.
Project Member

Comment 6 by sheriffbot@chromium.org, Mar 7 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 7 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92f2f530433fba0aa27d87690d517325d900f11e

commit 92f2f530433fba0aa27d87690d517325d900f11e
Author: Elijah Taylor <elijahtaylor@google.com>
Date: Tue Mar 07 20:59:56 2017

[M57] Enable ARC kiosk mode always when ARC is available

This removes --enable-arc-kiosk flag and instead uses --arc-available
to make this decision.

BUG= 697741 
TEST=./unit_tests --gtest_filter="ChromeArcUtilTest.*"
TEST=./components_unittests --gtest_filter="ArcUtilTest.*"

(cherry-picked from 67e99111e67ac5aeae011a14154e054160bf98c4)

R=achuith@chromium.org, hidehiko@chromium.org

Review-Url: https://codereview.chromium.org/2730003002 .
Cr-Commit-Position: refs/branch-heads/2987@{#789}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/92f2f530433fba0aa27d87690d517325d900f11e/chrome/browser/chromeos/app_mode/arc/arc_kiosk_app_manager_browsertest.cc
[modify] https://crrev.com/92f2f530433fba0aa27d87690d517325d900f11e/chrome/browser/chromeos/login/chrome_restart_request.cc
[modify] https://crrev.com/92f2f530433fba0aa27d87690d517325d900f11e/chromeos/chromeos_switches.cc
[modify] https://crrev.com/92f2f530433fba0aa27d87690d517325d900f11e/chromeos/chromeos_switches.h
[modify] https://crrev.com/92f2f530433fba0aa27d87690d517325d900f11e/components/arc/arc_bridge_service.cc

Status: Fixed (was: Started)
Blocking: 685393
Components: -Platform>ARC UI>Shell>Kiosk>ARC

Comment 11 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment