New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 697733 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Enable logs for video autotests

Project Member Reported by wuchengli@chromium.org, Mar 2 2017

Issue description

1) Change a small number of DVLOGs in VDAs/VEAs/JDAs/V4L2IP and key video code to VLOGs

2) before each video test, have the test enable them using vmodule and disable after the test.

3) before each video test, have the test echo higher level to debug module parameter in sysfs for appropriate driver and disable immediately afterwards


(a)
The default vmodule flags in autotest is here. https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/cros_browser_backend.py?q=cros_browser_backend.py+package:%5Echromium$&l=59

video_ChromeRTCHWDecodeUsed has an example of passing chrome flags in autotest. third_party/autotest/files/client/site_tests/video_ChromeRTCHWDecodeUsed/video_ChromeRTCHWDecodeUsed.py


(b)
for videobuf2,
echo 5 > /sys/module/videobuf2_*/parameters/debug
for v4l2 core,
echo 5 > /sys/class/video4linux/videoX/debug
when videoX needs actual number for x

(c)
To enable driver logs for elm/oak:
echo 8 > /proc/sys/kernel/printk

Enable some logs:
echo 2 > /sys/module/mtk_vcodec_dec/parameters/mtk_v4l2_dbg_level

Enable all logs
echo 3 > /sys/module/mtk_vcodec_enc/parameters/mtk_v4l2_dbg_level
echo Y > /sys/module/mtk_vcodec_enc/parameters/mtk_vcodec_dbg

(d)
To enable driver logs on exynos:
echo 5 > /sys/module/s5p_mfc/parameters/debug


How to enable driver logs on rk3288/rk3399?
 
We should verify we are not setting too high of a level for each driver, in order not to slow things too much for the tests.
Re #1: Yes.
Owner: jcliang@chromium.org
Status: Assigned (was: Available)
Load balancing. Rikcy. Please help with this.
Friendly ping.
Owner: hiroh@chromium.org
We also get:

"SYS_ioctl: VIDIOC_ENUM_FMT(2): fd=X, ret=-1, errno=2"

messages in the logs. These normally are not errors if we are at the end of enumeration loop and we get the final EINVAL return value to stop us from enumerating more (see https://www.linuxtv.org/downloads/v4l-dvb-apis-new/uapi/v4l/vidioc-enum-fmt.html?highlight=vidioc_enum_fmt).

We should try to not print out these messages of failing VIDIOC_ENUM_FMT in such cases.
Labels: -Pri-2 Pri-1
Hiro. (b) should be the easiest. You can start with (b).

(b)
for videobuf2,
echo 5 > /sys/module/videobuf2_*/parameters/debug
for v4l2 core,
echo 5 > /sys/class/video4linux/videoX/debug
when videoX needs actual number for x

"1) Change a small number of DVLOGs in VDAs/VEAs/JDAs/V4L2IP and key video code to VLOGs" ==> This is branched to https://bugs.chromium.org/p/chromium/issues/detail?id=718334.
Project Member

Comment 10 by bugdroid1@chromium.org, May 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/92bb409ba93356d341fbc25735d2ec9fe114514e

commit 92bb409ba93356d341fbc25735d2ec9fe114514e
Author: Hirokazu Honda <hiroh@chromium.org>
Date: Wed May 24 09:06:36 2017

Enable logs for video autotests

Make verbose video logs enable before each video autotest and make them
diable after the test.
The function to enable verbose printk log for elm/oak is not implemented yet.

BUG= chromium:697733 
TEST=video autotests on exynos and an intel device.

Change-Id: I2a89076b66c541467699cbdad56e19cac41ad07d
Reviewed-on: https://chromium-review.googlesource.com/499827
Commit-Ready: Hirokazu Honda <hiroh@chromium.org>
Tested-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Kuang-che Wu <kcwu@chromium.org>

[modify] https://crrev.com/92bb409ba93356d341fbc25735d2ec9fe114514e/client/site_tests/video_MultiplePlayback/video_MultiplePlayback.py
[modify] https://crrev.com/92bb409ba93356d341fbc25735d2ec9fe114514e/client/site_tests/video_VideoSeek/video_VideoSeek.py
[modify] https://crrev.com/92bb409ba93356d341fbc25735d2ec9fe114514e/client/site_tests/video_WebRtcSanity/video_WebRtcSanity.py
[modify] https://crrev.com/92bb409ba93356d341fbc25735d2ec9fe114514e/client/site_tests/video_VDASanity/video_VDASanity.py
[modify] https://crrev.com/92bb409ba93356d341fbc25735d2ec9fe114514e/client/site_tests/video_WebRtcCamera/video_WebRtcCamera.py
[modify] https://crrev.com/92bb409ba93356d341fbc25735d2ec9fe114514e/client/site_tests/video_ChromeRTCHWEncodeUsed/video_ChromeRTCHWEncodeUsed.py
[modify] https://crrev.com/92bb409ba93356d341fbc25735d2ec9fe114514e/client/site_tests/video_GlitchDetection/video_GlitchDetection.py
[modify] https://crrev.com/92bb409ba93356d341fbc25735d2ec9fe114514e/client/site_tests/video_PlaybackPerf/video_PlaybackPerf.py
[modify] https://crrev.com/92bb409ba93356d341fbc25735d2ec9fe114514e/client/site_tests/video_ChromeVidResChangeHWDecode/video_ChromeVidResChangeHWDecode.py
[modify] https://crrev.com/92bb409ba93356d341fbc25735d2ec9fe114514e/client/site_tests/video_YouTubeHTML5/video_YouTubeHTML5.py
[modify] https://crrev.com/92bb409ba93356d341fbc25735d2ec9fe114514e/client/site_tests/video_WebRtcPerf/video_WebRtcPerf.py
[modify] https://crrev.com/92bb409ba93356d341fbc25735d2ec9fe114514e/client/site_tests/video_VimeoVideo/video_VimeoVideo.py
[modify] https://crrev.com/92bb409ba93356d341fbc25735d2ec9fe114514e/client/site_tests/video_HangoutHardwarePerf/video_HangoutHardwarePerf.py
[modify] https://crrev.com/92bb409ba93356d341fbc25735d2ec9fe114514e/client/site_tests/video_WebRtcMediaRecorder/video_WebRtcMediaRecorder.py
[modify] https://crrev.com/92bb409ba93356d341fbc25735d2ec9fe114514e/client/site_tests/video_YouTubeMseEme/video_YouTubeMseEme.py
[modify] https://crrev.com/92bb409ba93356d341fbc25735d2ec9fe114514e/client/site_tests/video_ChromeHWDecodeUsed/video_ChromeHWDecodeUsed.py
[modify] https://crrev.com/92bb409ba93356d341fbc25735d2ec9fe114514e/client/site_tests/video_WebRtcPeerConnectionWithCamera/video_WebRtcPeerConnectionWithCamera.py
[add] https://crrev.com/92bb409ba93356d341fbc25735d2ec9fe114514e/client/cros/video/helper_logger.py
[modify] https://crrev.com/92bb409ba93356d341fbc25735d2ec9fe114514e/client/site_tests/video_VDAPerf/video_VDAPerf.py
[modify] https://crrev.com/92bb409ba93356d341fbc25735d2ec9fe114514e/client/site_tests/video_VideoDecodeAccelerator/video_VideoDecodeAccelerator.py
[modify] https://crrev.com/92bb409ba93356d341fbc25735d2ec9fe114514e/client/site_tests/video_VideoEncodeAccelerator/video_VideoEncodeAccelerator.py
[modify] https://crrev.com/92bb409ba93356d341fbc25735d2ec9fe114514e/client/site_tests/video_VideoDecodeMemoryUsage/video_VideoDecodeMemoryUsage.py
[modify] https://crrev.com/92bb409ba93356d341fbc25735d2ec9fe114514e/client/site_tests/video_VideoSanity/video_VideoSanity.py
[modify] https://crrev.com/92bb409ba93356d341fbc25735d2ec9fe114514e/client/site_tests/video_VideoReload/video_VideoReload.py
[modify] https://crrev.com/92bb409ba93356d341fbc25735d2ec9fe114514e/client/site_tests/video_VEAPerf/video_VEAPerf.py
[modify] https://crrev.com/92bb409ba93356d341fbc25735d2ec9fe114514e/client/site_tests/video_YouTubePage/video_YouTubePage.py
[modify] https://crrev.com/92bb409ba93356d341fbc25735d2ec9fe114514e/client/site_tests/video_JpegDecodeAccelerator/video_JpegDecodeAccelerator.py
[modify] https://crrev.com/92bb409ba93356d341fbc25735d2ec9fe114514e/client/site_tests/video_ChromeRTCHWDecodeUsed/video_ChromeRTCHWDecodeUsed.py
[modify] https://crrev.com/92bb409ba93356d341fbc25735d2ec9fe114514e/client/site_tests/video_VideoCorruption/video_VideoCorruption.py

Comment 11 by hiroh@chromium.org, May 25 2017

Status: Fixed (was: Assigned)

Comment 12 by hiroh@chromium.org, May 25 2017

Status: Started (was: Fixed)

Comment 13 Deleted

Comment 14 by hiroh@chromium.org, May 30 2017

I conclude no chromeOS CL is necessary for (c) and abandon this CL(https://chromium-review.googlesource.com/c/516683/).
The default log level for printk is 7. This is enough to enable prr_err.
In the present kernel implementation, no mtk driver log is enabled.
If they are enabled and their log level is set to 2 or 3, there are too many logs.
Because a driver error message should be shown, I distinguished them from other debug messages.
A driver error message are shown as a default, and any other messages are not shown.

Apart from this, I changed the log level of some videobuf2 debug message so as not to flood logs.

I submitted two CLs to do above things to the linux project.
Cc: avkodipelli@chromium.org

Comment 16 by kcwu@chromium.org, Jun 2 2017

video_VDAPerf started to fail due to mistake in CL mentioned in comment 10.
  File "/usr/local/autotest/tests/video_VDAPerf/video_VDAPerf.py", line 264, in _run_test_case
    cmd_line = ' '.jon(cmd_line_list)
AttributeError: 'str' object has no attribute 'jon'

Hiro. Let's lower the level of both kernel vb2 log and mfc log by 1. The logs are too many on peach.

2017-06-01T18:00:59.293208-07:00 DEBUG kernel: [  281.718751] vb2: qbuf of buffer 1 succeeded
2017-06-01T18:00:59.293230-07:00 DEBUG kernel: [  281.720022] vb2: qbuf of buffer 0 succeeded
2017-06-01T18:00:59.298204-07:00 DEBUG kernel: [  281.724095] vb2: qbuf of buffer 0 succeeded
2017-06-01T18:00:59.298222-07:00 DEBUG kernel: [  281.724122] vb2: Nonblocking and no buffers to dequeue, will not wait
2017-06-01T18:00:59.298229-07:00 DEBUG kernel: [  281.724133] vb2: Nonblocking and no buffers to dequeue, will not wait
2017-06-01T18:00:59.308319-07:00 DEBUG kernel: [  281.731723] s5p_mfc_ctx_ready:747: src=0, dst=1, state=102
2017-06-01T18:00:59.308337-07:00 DEBUG kernel: [  281.731731] s5p_mfc_ctx_ready:776: ctx is not ready
2017-06-01T18:00:59.308344-07:00 DEBUG kernel: [  281.731740] s5p_mfc_try_once:180: Try run dev: ee82d818
2017-06-01T18:00:59.308349-07:00 DEBUG kernel: [  281.731748] s5p_mfc_get_new_ctx:155: No ctx is scheduled to be run
2017-06-01T18:00:59.308385-07:00 DEBUG kernel: [  281.731881] check_vb_with_fmt:1959: index: 0, plane[0] cookie: 0x20200000
2017-06-01T18:00:59.308392-07:00 DEBUG kernel: [  281.731893] s5p_mfc_buf_prepare:2081: plane size: 2097152, dst size: 2097152
2017-06-01T18:00:59.308397-07:00 DEBUG kernel: [  281.731905] s5p_mfc_ctx_ready:747: src=0, dst=2, state=102
2017-06-01T18:00:59.308402-07:00 DEBUG kernel: [  281.731913] s5p_mfc_ctx_ready:776: ctx is not ready
2017-06-01T18:00:59.308407-07:00 DEBUG kernel: [  281.731922] s5p_mfc_try_once:180: Try run dev: ee82d818
2017-06-01T18:00:59.308413-07:00 DEBUG kernel: [  281.731932] s5p_mfc_get_new_ctx:155: No ctx is scheduled to be run
2017-06-01T18:00:59.308418-07:00 DEBUG kernel: [  281.731942] vb2: qbuf of buffer 0 succeeded
2017-06-01T18:00:59.308423-07:00 DEBUG kernel: [  281.732047] vb2: Nonblocking and no buffers to dequeue, will not wait
2017-06-01T18:00:59.308428-07:00 DEBUG kernel: [  281.732784] vb2: dqbuf of buffer 1, with state 0
2017-06-01T18:00:59.308434-07:00 DEBUG kernel: [  281.732796] vb2: Nonblocking and no buffers to dequeue, will not wait
2017-06-01T18:00:59.308439-07:00 DEBUG kernel: [  281.732807] vb2: dqbuf of buffer 1, with state 0
2017-06-01T18:00:59.308444-07:00 DEBUG kernel: [  281.732847] vb2: Nonblocking and no buffers to dequeue, will not wait
2017-06-01T18:00:59.308449-07:00 DEBUG kernel: [  281.732938] vb2: qbuf: buffer for plane 0 changed
2017-06-01T18:00:59.308455-07:00 DEBUG kernel: [  281.732949] vb2: qbuf: buffer for plane 1 changed
2017-06-01T18:00:59.308460-07:00 DEBUG kernel: [  281.733837] check_vb_with_fmt:1959: index: 3, plane[0] cookie: 0x20800000
2017-06-01T18:00:59.308465-07:00 DEBUG kernel: [  281.733844] check_vb_with_fmt:1959: index: 3, plane[1] cookie: 0x20600000
2017-06-01T18:00:59.308470-07:00 DEBUG kernel: [  281.733851] check_vb_with_fmt:1959: index: 3, plane[0] cookie: 0x20800000
2017-06-01T18:00:59.308475-07:00 DEBUG kernel: [  281.733857] check_vb_with_fmt:1959: index: 3, plane[1] cookie: 0x20600000
2017-06-01T18:00:59.308480-07:00 DEBUG kernel: [  281.733864] s5p_mfc_buf_prepare:2091: plane size: 2121728, luma size: 2089216
2017-06-01T18:00:59.308486-07:00 DEBUG kernel: [  281.733870] s5p_mfc_buf_prepare:2093: plane size: 1060864, chroma size: 1044608
2017-06-01T18:00:59.308491-07:00 DEBUG kernel: [  281.733877] vb2: qbuf of buffer 3 succeeded
2017-06-01T18:00:59.308496-07:00 DEBUG kernel: [  281.733897] s5p_mfc_ctx_ready:747: src=1, dst=2, state=102
2017-06-01T18:00:59.308501-07:00 DEBUG kernel: [  281.733904] s5p_mfc_try_once:180: Try run dev: ee82d818
2017-06-01T18:00:59.308506-07:00 DEBUG kernel: [  281.733911] s5p_mfc_try_once:191: New context: eeb02000
2017-06-01T18:00:59.308963-07:00 DEBUG kernel: [  281.733917] s5p_mfc_try_once:192: Seting new context to eeb02000
2017-06-01T18:00:59.308971-07:00 DEBUG kernel: [  281.733924] s5p_mfc_try_once:195: ctx->dst_queue_cnt=2 ctx->dpb_count=4 ctx->src_queue_cnt=1
2017-06-01T18:00:59.308976-07:00 DEBUG kernel: [  281.733930] s5p_mfc_try_once:196: ctx->state=102
2017-06-01T18:00:59.308982-07:00 DEBUG kernel: [  281.733944] s5p_mfc_set_enc_ref_buffer_v6:522: Buf1: 22000000 (25783040)
2017-06-01T18:00:59.308987-07:00 DEBUG kernel: [  281.733961] s5p_mfc_set_enc_ref_buffer_v6:547: Buf1: 596208384, buf_size1: 0 (ref frames 4)
2017-06-01T18:00:59.308993-07:00 DEBUG kernel: [  281.733967] s5p_mfc_cmd_host2risc_v6:23: Issue the command: 4
2017-06-01T18:00:59.308998-07:00 DEBUG kernel: [  281.733976] s5p_mfc_try_once:180: Try run dev: ee82d818
2017-06-01T18:00:59.309004-07:00 DEBUG kernel: [  281.733982] s5p_mfc_get_new_ctx:161: Couldn't lock HW
2017-06-01T18:00:59.309009-07:00 DEBUG kernel: [  281.734016] vb2: Nonblocking and no buffers to dequeue, will not wait
2017-06-01T18:00:59.309015-07:00 DEBUG kernel: [  281.734031] s5p_mfc_irq:366: Int reason: 4 (err: 00000000)
2017-06-01T18:00:59.309021-07:00 DEBUG kernel: [  281.734039] s5p_mfc_ctx_ready:747: src=1, dst=2, state=103
2017-06-01T18:00:59.309027-07:00 DEBUG kernel: [  281.734051] s5p_mfc_try_once:180: Try run dev: ee82d818
2017-06-01T18:00:59.309033-07:00 DEBUG kernel: [  281.734058] s5p_mfc_try_once:191: New context: eeb02000
2017-06-01T18:00:59.309038-07:00 DEBUG kernel: [  281.734064] s5p_mfc_try_once:192: Seting new context to eeb02000
2017-06-01T18:00:59.309044-07:00 DEBUG kernel: [  281.734071] s5p_mfc_try_once:195: ctx->dst_queue_cnt=2 ctx->dpb_count=4 ctx->src_queue_cnt=1
2017-06-01T18:00:59.309050-07:00 DEBUG kernel: [  281.734077] s5p_mfc_try_once:196: ctx->state=103
120829918-chromeos-test%2Fchromeos6-row2-rack10-host17%2Fcrashinfo.txt
221 KB View Download
The kernel log on elm during autotest.

2017-06-02T14:34:36.793005-07:00 INFO kernel: [  276.113270] vb2: vb2_internal_dqbuf: dqbuf of buffer 3, with state 0
2017-06-02T14:34:36.793021-07:00 INFO kernel: [  276.113278] vb2: __vb2_wait_for_done_vb: nonblocking and no buffers to dequeue, will not wait
2017-06-02T14:34:36.793023-07:00 INFO kernel: [  276.113285] vb2: __vb2_wait_for_done_vb: nonblocking and no buffers to dequeue, will not wait
2017-06-02T14:34:36.793026-07:00 INFO kernel: [  276.113311] vb2: __vb2_wait_for_done_vb: nonblocking and no buffers to dequeue, will not wait
2017-06-02T14:34:36.793027-07:00 INFO kernel: [  276.113317] vb2: __vb2_wait_for_done_vb: nonblocking and no buffers to dequeue, will not wait
2017-06-02T14:34:36.793029-07:00 INFO kernel: [  276.113332] vb2: __vb2_wait_for_done_vb: nonblocking and no buffers to dequeue, will not wait
2017-06-02T14:34:36.793031-07:00 INFO kernel: [  276.113339] vb2: __vb2_wait_for_done_vb: nonblocking and no buffers to dequeue, will not wait
2017-06-02T14:34:36.793033-07:00 INFO kernel: [  276.113411] vb2: vb2_internal_qbuf: qbuf of buffer 3 succeeded
2017-06-02T14:34:36.793035-07:00 INFO kernel: [  276.113426] vb2: __vb2_wait_for_done_vb: nonblocking and no buffers to dequeue, will not wait
2017-06-02T14:34:36.793037-07:00 INFO kernel: [  276.113433] vb2: __vb2_wait_for_done_vb: nonblocking and no buffers to dequeue, will not wait
2017-06-02T14:34:36.793039-07:00 INFO kernel: [  276.113444] vb2: __vb2_wait_for_done_vb: nonblocking and no buffers to dequeue, will not wait
2017-06-02T14:34:36.793041-07:00 INFO kernel: [  276.113450] vb2: __vb2_wait_for_done_vb: nonblocking and no buffers to dequeue, will not wait
2017-06-02T14:34:36.793042-07:00 INFO kernel: [  276.113461] vb2: __vb2_wait_for_done_vb: nonblocking and no buffers to dequeue, will not wait
2017-06-02T14:34:36.793044-07:00 INFO kernel: [  276.113467] vb2: __vb2_wait_for_done_vb: nonblocking and no buffers to dequeue, will not wait
2017-06-02T14:34:36.793046-07:00 INFO kernel: [  276.113782] vb2: __vb2_wait_for_done_vb: nonblocking and no buffers to dequeue, will not wait
2017-06-02T14:34:36.793048-07:00 INFO kernel: [  276.113794] vb2: __vb2_wait_for_done_vb: nonblocking and no buffers to dequeue, will not wait
I upstreamed patch to linux kernel to lower such log levels.
The patch is under review.

Project Member

Comment 20 by bugdroid1@chromium.org, Jun 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b1e3a70d970d1adfe9e705d24e5139ead39910f8

commit b1e3a70d970d1adfe9e705d24e5139ead39910f8
Author: Hirokazu Honda <hiroh@chromium.org>
Date: Mon Jun 05 08:18:07 2017

Fix a typo in video_VDAPerf.py

BUG= chromium:697733 
TEST=None

Change-Id: If4ee004c5c5325285dbbd84c5a95510b63725575
Reviewed-on: https://chromium-review.googlesource.com/523504
Commit-Ready: Hirokazu Honda <hiroh@chromium.org>
Tested-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Wu-cheng Li <wuchengli@chromium.org>

[modify] https://crrev.com/b1e3a70d970d1adfe9e705d24e5139ead39910f8/client/site_tests/video_VDAPerf/video_VDAPerf.py

A patch I submitted to linux kernel project was accepted. Then, I submitted the same CL to ChromeOS today.

Comment 22 by kcwu@chromium.org, Jun 8 2017

Please merge the fix CL in comment 20 to R60.

Labels: Merge-Request-60
Request merge the CL in Comment 20.
Labels: OS-Chrome
Project Member

Comment 25 by sheriffbot@chromium.org, Jun 9 2017

Labels: -Merge-Request-60 Hotlist-Merge-Review Merge-Review-60
This bug requires manual review: M60 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: josa...@chromium.org
josafat@: may we please ask for a review? This is a typo fix in test script only, does not affect anything but the test.
Labels: -Merge-Review-60 M-60 Merge-Approved-60
ok, approved for M60 merge
Project Member

Comment 28 by bugdroid1@chromium.org, Jun 14 2017

Labels: merge-merged-release-R60-9592.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/2f5283a4498f8c4ac91fd195b422bf3613181e59

commit 2f5283a4498f8c4ac91fd195b422bf3613181e59
Author: Hirokazu Honda <hiroh@chromium.org>
Date: Wed Jun 14 01:31:01 2017

Fix a typo in video_VDAPerf.py

BUG= chromium:697733 
TEST=None

Change-Id: If4ee004c5c5325285dbbd84c5a95510b63725575
Reviewed-on: https://chromium-review.googlesource.com/523504
Commit-Ready: Hirokazu Honda <hiroh@chromium.org>
Tested-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Wu-cheng Li <wuchengli@chromium.org>
(cherry picked from commit b1e3a70d970d1adfe9e705d24e5139ead39910f8)
Reviewed-on: https://chromium-review.googlesource.com/535173
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Trybot-Ready: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>

[modify] https://crrev.com/2f5283a4498f8c4ac91fd195b422bf3613181e59/client/site_tests/video_VDAPerf/video_VDAPerf.py

Project Member

Comment 29 by sheriffbot@chromium.org, Jun 19 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-60
Project Member

Comment 31 by bugdroid1@chromium.org, Jun 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/802907cf0e9a41e62513ce529c76f2998d61eb69

commit 802907cf0e9a41e62513ce529c76f2998d61eb69
Author: Hirokazu Honda <hiroh@chromium.org>
Date: Wed Jun 21 08:03:00 2017

Decrease the debug level for driver log on exynos

The level is set 1, which is previously 2, so that less log messages
would be shown.

BUG= chromium:697733 
TEST=video_ChromeHWDecodeUsed

Change-Id: I8dac1354984e2ed44113d82f3539e07b2bdd0f9a
Reviewed-on: https://chromium-review.googlesource.com/539355
Commit-Ready: Hirokazu Honda <hiroh@chromium.org>
Tested-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Wu-cheng Li <wuchengli@chromium.org>

[modify] https://crrev.com/802907cf0e9a41e62513ce529c76f2998d61eb69/client/cros/video/helper_logger.py

Hiro. Can you also enable the debug logs for rk3288, rk3399, and go2001 drivers? See the following files for references.

third_party/kernel/v3.14/drivers/media/platform/rk3288-vpu/rk3288_vpu.c
third_party/kernel/v4.4/drivers/media/platform/rockchip-vpu/rockchip_vpu_common.h
third_party/kernel/v3.14/drivers/media/pci/go2001/go2001_driver.c

Comment 33 by hiroh@chromium.org, Jul 12 2017

A patch for #c32 was merged, although that wasn't shown here, because I typo the bug number in a commit message. https://chromium-review.googlesource.com/c/557779/
Project Member

Comment 34 by bugdroid1@chromium.org, Jul 12 2017

Labels: merge-merged-chromeos-4.4
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/01c1cbb50e500e1333f815058a135c9259fb592d

commit 01c1cbb50e500e1333f815058a135c9259fb592d
Author: Hirokazu Honda <hiroh@chromium.org>
Date: Wed Jul 12 10:16:18 2017

FROMLIST: vb2: core: Lower the log level of debug

Some debug output whose log level is set 1 flooded the log.
Their log level is lowered to find the important log easily.

BUG= chromium:697733 
TEST=run VDA unittest, echo 1 > sys/module/videobuf2_*/parameters/debug
     and check messages in /var/log/messages

Change-Id: I1be9302658715662212fba4233357b286c61d757
Reviewed-on: https://chromium-review.googlesource.com/558859
Commit-Ready: Hirokazu Honda <hiroh@chromium.org>
Tested-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>

[modify] https://crrev.com/01c1cbb50e500e1333f815058a135c9259fb592d/drivers/media/v4l2-core/videobuf2-core.c

Project Member

Comment 35 by bugdroid1@chromium.org, Jul 14 2017

Labels: merge-merged-chromeos-3.18
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/1c426b9e777429b6253375a6176676ffa86c3476

commit 1c426b9e777429b6253375a6176676ffa86c3476
Author: Hirokazu Honda <hiroh@chromium.org>
Date: Fri Jul 14 05:03:36 2017

FROMLIST: [media] mtk-vcodec: Show mtk driver error without DEBUG definition

Currently the driver does not print error messages if DEBUG is not defined.
It makes it much more difficult to find failure reasons on systems
running kernels built without additional debugging.
Enable error messages regardless of the DEBUG symbol, which is okay,
because it affects only error paths.

BUG= chromium:697733 
TEST=Seeing actually log messages in playing the video

Change-Id: Ie66915e65d6430b426db6b73cc1c038c6226f173
Signed-off-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/527715
Reviewed-by: Pawel Osciak <posciak@chromium.org>

[modify] https://crrev.com/1c426b9e777429b6253375a6176676ffa86c3476/drivers/media/platform/mtk-vcodec/mtk_vcodec_util.h

Comment 36 by hiroh@chromium.org, Jul 14 2017

Status: Fixed (was: Started)
I created ENUM_FMT issue separating from this issue ( crbug.com/742688 ).
The issue "1) Change a small number of DVLOGs in VDAs/VEAs/JDAs/V4L2IP and key video code to VLOGs" had been already branched to  crbug.com/718334  and owenlin@ is working on that issue.

All the issues except them were merged for now.
So I close this issue.
Status: Verified (was: Fixed)

Sign in to add a comment