Include task scheduler name in all histograms recorded by task scheduler. |
|||
Issue descriptionTaskScheduler.BlockShutdownTasksPostedDuringShutdown shouldn't be shared between all process types. Other histograms shouldn't per shared between browser and non-renderer process types. (e.g. TaskScheduler.DetachDuration.RendererBackgroundBlockingPool is recorded by renderers and TaskScheduler.DetachDuration.BackgroundBlockingPool is recorded by all other process types). All histograms should probably be prefixed by: TaskScheduler.[process type].*
,
Mar 29 2017
,
Jan 22 2018
Almost there with recent changes, will complete.
,
Oct 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/37e26ab9b4d327608864e896ade976ec3ac9211b commit 37e26ab9b4d327608864e896ade976ec3ac9211b Author: Francois Doray <fdoray@chromium.org> Date: Thu Oct 18 20:39:08 2018 TaskScheduler: Remove TaskScheduler.BlockShutdownTasksPostedDuringShutdown. The histogram shows that 99.9% of the time, less than 1000 BLOCK_SHUTDOWN tasks are posted during shutdown. This CL replaces the histogram with a crash when the number is to high, which will be more actionnable. Note: Current histogram data shows that this crash will happen less than 0.1% of the time. Bug: 697731 Change-Id: I553caf93b0109a1bd44c5c841d0f557e6cad16cd Reviewed-on: https://chromium-review.googlesource.com/c/1280670 Reviewed-by: Gabriel Charette <gab@chromium.org> Reviewed-by: Brian White <bcwhite@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#600892} [modify] https://crrev.com/37e26ab9b4d327608864e896ade976ec3ac9211b/base/task/task_scheduler/task_tracker.cc [modify] https://crrev.com/37e26ab9b4d327608864e896ade976ec3ac9211b/tools/metrics/histograms/histograms.xml |
|||
►
Sign in to add a comment |
|||
Comment 1 by fdoray@chromium.org
, Mar 2 2017Blocking: 553459