VisibleUnit::startOfWord/endOfWord should return Position rather than VisiblePosition. |
|||
Issue descriptionThe root cause is that though |previousBoundary| in |startOfWord| finds correct position of " |bar", |mostBackWordPosition| of canonicalization moves to "| bar". We can fix it changing function signature from VisiblePosition to Position.
,
Mar 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/02c4e35bd076d9f12d7f42947d21078a244caa14 commit 02c4e35bd076d9f12d7f42947d21078a244caa14 Author: yoichio <yoichio@chromium.org> Date: Mon Mar 06 03:49:59 2017 Change VisibleUnits::previousBoundary to return Position rather than VisiblePosition This is preparation for letting |startOfWord| and |endOfWord| return uncanonicalized Position. BUG= 697725 Review-Url: https://codereview.chromium.org/2725053006 Cr-Commit-Position: refs/heads/master@{#454820} [modify] https://crrev.com/02c4e35bd076d9f12d7f42947d21078a244caa14/third_party/WebKit/Source/core/editing/VisibleUnits.cpp
,
Mar 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/64a4419d59615578571e7cfd50237f489a7ec7bd commit 64a4419d59615578571e7cfd50237f489a7ec7bd Author: yoichio <yoichio@chromium.org> Date: Mon Mar 06 06:55:04 2017 Add VisibleUnits::endfWordPosition This is Position version of |endOfWord| which returns VisiblePosition. Since returned Position should be already canonicalized with |nextBoundary()|, we can replace them. TEST=No change in behavior. BUG= 697725 Review-Url: https://codereview.chromium.org/2734763002 Cr-Commit-Position: refs/heads/master@{#454836} [modify] https://crrev.com/64a4419d59615578571e7cfd50237f489a7ec7bd/third_party/WebKit/Source/core/editing/VisibleUnits.cpp [modify] https://crrev.com/64a4419d59615578571e7cfd50237f489a7ec7bd/third_party/WebKit/Source/core/editing/VisibleUnits.h
,
Mar 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f47de6fa1c432e87dc270ff96b1089e5983c2cf1 commit f47de6fa1c432e87dc270ff96b1089e5983c2cf1 Author: yoichio <yoichio@chromium.org> Date: Tue Mar 07 18:28:34 2017 Add VisibleUnits::startOfWordPosition This is Position version of |startOfWord| which returns VisiblePosition. Since returned Position should be already canonicalized with |previousBoundary()|, we can replace them. This is preparation for letting |startOfWord| and |endOfWord| return uncanonicalized Position. BUG=657237, 697725 TEST=No change in behavior. Review-Url: https://codereview.chromium.org/2732863004 Cr-Commit-Position: refs/heads/master@{#455146} [modify] https://crrev.com/f47de6fa1c432e87dc270ff96b1089e5983c2cf1/third_party/WebKit/Source/core/editing/VisibleUnits.cpp [modify] https://crrev.com/f47de6fa1c432e87dc270ff96b1089e5983c2cf1/third_party/WebKit/Source/core/editing/VisibleUnits.h
,
Jul 12 2017
,
Jan 30 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Mar 3 2017