New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 697719 link

Starred by 1 user
Status: Fixed
Owner:
█ zhaobin@chromium.org
Last visit > 30 days ago
Closed: Mar 2017
Cc:
mfo...@chromium.org
btolsch@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Presentation API] Add layout test for controller connection.close() and receiver connection.close()

Project Member Reported by zhaobin@chromium.org, Mar 2 2017 
https://codereview.chromium.org/2714693002/ implements transitioning connection state to 'closed' with PresentationConnectionProxy. It would be good to add a layout test for controller <--> receiver.

https://codereview.chromium.org/2484273003/ adds some receiver layout tests. Wait for it to land first.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c08ed56a3e5089b3cc4094e83daae196a6300c4

commit 0c08ed56a3e5089b3cc4094e83daae196a6300c4
Author: zhaobin <zhaobin@chromium.org>
Date: Tue Mar 07 21:19:16 2017

[Presentation API] Add layout test for connection.close() and fix test failures

Add layout test.

1-UA connection.close() hits NOTREACHED() in PresentationConnection::didChangeState(). Use PresentationConnection::didClose() instead.

BUG= 697719 

Review-Url: https://codereview.chromium.org/2730123003
Cr-Commit-Position: refs/heads/master@{#455225}

[modify] https://crrev.com/0c08ed56a3e5089b3cc4094e83daae196a6300c4/content/renderer/presentation/presentation_connection_proxy.cc
[modify] https://crrev.com/0c08ed56a3e5089b3cc4094e83daae196a6300c4/content/renderer/presentation/presentation_connection_proxy_unittest.cc
[modify] https://crrev.com/0c08ed56a3e5089b3cc4094e83daae196a6300c4/content/renderer/presentation/test_presentation_connection.h
[add] https://crrev.com/0c08ed56a3e5089b3cc4094e83daae196a6300c4/third_party/WebKit/LayoutTests/presentation/presentation-controller-close-connection.html
[add] https://crrev.com/0c08ed56a3e5089b3cc4094e83daae196a6300c4/third_party/WebKit/LayoutTests/presentation/presentation-controller-connection-closed-by-receiver.html
[add] https://crrev.com/0c08ed56a3e5089b3cc4094e83daae196a6300c4/third_party/WebKit/LayoutTests/presentation/resources/presentation-receiver-close-connection.html
[modify] https://crrev.com/0c08ed56a3e5089b3cc4094e83daae196a6300c4/third_party/WebKit/LayoutTests/presentation/resources/presentation-service-mock.js
[modify] https://crrev.com/0c08ed56a3e5089b3cc4094e83daae196a6300c4/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp
[modify] https://crrev.com/0c08ed56a3e5089b3cc4094e83daae196a6300c4/third_party/WebKit/Source/modules/presentation/PresentationConnection.h
[modify] https://crrev.com/0c08ed56a3e5089b3cc4094e83daae196a6300c4/third_party/WebKit/public/platform/modules/presentation/WebPresentationConnection.h

Comment 2 by sko...@chromium.org, Mar 9 2017

Status: Fixed (was: Untriaged)
Please re-open if there's more to do here.
►

Sign in to add a comment