[UI string] "JavaScript" is misspelled |
|||||
Issue description
MD Settings UI refers to "Javascript"
The correct spelling is "JavaScript"
<message name="IDS_SETTINGS_SITE_SETTINGS_JAVASCRIPT" desc="Label for the javascript site settings.">
Javascript
</message>
This is a regression, as the spelling was correct in chrome://settings.
,
Mar 2 2017
I can see where the issue is ocourring: https://cs.chromium.org/chromium/src/chrome/app/settings_strings.grdp?type=cs&q=Label+for+the+javascript+site+settings.+package:%5Echromium$&l=1768 Should be a straightforward fix!
,
Mar 3 2017
I have raised a pull request for review here: https://codereview.chromium.org/2724253005/ Thanks
,
Mar 3 2017
tbuckley@ - please confirm spelling
,
Mar 6 2017
,
Mar 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5fda4e9a4c9fc1a0f0a061506f41c47c78b3961 commit d5fda4e9a4c9fc1a0f0a061506f41c47c78b3961 Author: jacob.jh.clark <jacob.jh.clark@googlemail.com> Date: Mon Mar 06 23:45:34 2017 Issue 697712 - JavaScript misspelled fix BUG= 697712 This is my first patch so will require automated tests running for me. Review-Url: https://codereview.chromium.org/2724253005 Cr-Commit-Position: refs/heads/master@{#455001} [modify] https://crrev.com/d5fda4e9a4c9fc1a0f0a061506f41c47c78b3961/AUTHORS [modify] https://crrev.com/d5fda4e9a4c9fc1a0f0a061506f41c47c78b3961/chrome/app/settings_strings.grdp
,
Mar 6 2017
,
May 8 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by jacob.jh...@googlemail.com
, Mar 2 2017