Design doc: https://docs.google.com/a/chromium.org/document/d/1deh7jm-x95d_nWfvWqZAwwgzR6q_1SXIuRoNnQlqCqA/edit?usp=sharing Proof-of-concept CL: https://codereview.chromium.org/2704983002/
Design doc: https://docs.google.com/a/chromium.org/document/d/1deh7jm-x95d_nWfvWqZAwwgzR6q_1SXIuRoNnQlqCqA/edit?usp=sharing Proof-of-concept CL: https://codereview.chromium.org/2704983002/ Part 0: Grit resource ID tweak https://codereview.chromium.org/2725783006/ Part 1: Store and StoreClient https://codereview.chromium.org/2731473002/ Part 2: Reducers/Actions/util, excluding selection and search TODO Part 3: Integrate basic actions into UI (breaks search, item selection and routing) TODO Part 4: Actions/Reducers for item selection and search TODO Part 5: Reimplement routing TODO Part 6: Remove old store TODO
Design doc: https://docs.google.com/a/chromium.org/document/d/1deh7jm-x95d_nWfvWqZAwwgzR6q_1SXIuRoNnQlqCqA/edit?usp=sharing Proof-of-concept CL: https://codereview.chromium.org/2704983002/ Part 1: Store and StoreClient https://codereview.chromium.org/2731473002/ Part 2: Reducers/Actions/util, excluding selection and search https://codereview.chromium.org/2733463002/ Part 3: Integrate basic actions into UI (breaks search, item selection and routing) TODO Part 4: Actions/Reducers for item selection and search TODO Part 5: Reimplement routing TODO Part 6: Remove old store TODO
Design doc: https://docs.google.com/a/chromium.org/document/d/1deh7jm-x95d_nWfvWqZAwwgzR6q_1SXIuRoNnQlqCqA/edit?usp=sharing Proof-of-concept CL: https://codereview.chromium.org/2704983002/ Part 1: Store and StoreClient https://codereview.chromium.org/2731473002/ Part 2: Reducers/Actions/util, excluding selection and search https://codereview.chromium.org/2733463002/ Part 3: Integrate basic actions into UI (breaks search, item selection and routing) https://codereview.chromium.org/2735953002/ Part 4: Actions/Reducers for item selection and search TODO Part 5: Reimplement routing TODO Part 6: Remove old store TODO
Design doc: https://docs.google.com/a/chromium.org/document/d/1deh7jm-x95d_nWfvWqZAwwgzR6q_1SXIuRoNnQlqCqA/edit?usp=sharing Proof-of-concept CL: https://codereview.chromium.org/2704983002/ Part 1: Store and StoreClient https://codereview.chromium.org/2731473002/ Part 2: Reducers/Actions/util, excluding selection and search https://codereview.chromium.org/2733463002/ Part 3: Integrate basic actions into UI (breaks search, item selection and routing) https://codereview.chromium.org/2735953002/ Part 4: Actions/Reducers for item selection and search Search: https://codereview.chromium.org/2740863003/ Selection: https://codereview.chromium.org/2741393002/ Part 5: Reimplement routing TODO Part 6: Remove old store TODO
Design doc: https://docs.google.com/a/chromium.org/document/d/1deh7jm-x95d_nWfvWqZAwwgzR6q_1SXIuRoNnQlqCqA/edit?usp=sharing Proof-of-concept CL: https://codereview.chromium.org/2704983002/ Part 1: Store and StoreClient https://codereview.chromium.org/2731473002/ Part 2: Reducers/Actions/util, excluding selection and search https://codereview.chromium.org/2733463002/ Part 3: Integrate basic actions into UI (breaks search, item selection and routing) https://codereview.chromium.org/2735953002/ Part 4: Actions/Reducers for item selection and search Search: https://codereview.chromium.org/2740863003/ Selection: https://codereview.chromium.org/2741393002/ Part 5: Reimplement routing https://codereview.chromium.org/2745993002 Part 6: Remove old store https://codereview.chromium.org/2752173002/
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d39f556a09046fb8fd2c11f7c5b9d6b821c5e9ab commit d39f556a09046fb8fd2c11f7c5b9d6b821c5e9ab Author: tsergeant <tsergeant@chromium.org> Date: Thu Mar 02 22:08:11 2017 Grit: Reserve 30 resource IDs for includes in chrome/browser/browser_resources.grd BUG= 697706 Review-Url: https://codereview.chromium.org/2725783006 Cr-Commit-Position: refs/heads/master@{#454397} [modify] https://crrev.com/d39f556a09046fb8fd2c11f7c5b9d6b821c5e9ab/tools/gritsettings/resource_ids
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0d9346b1e64f41e97cd44a291ae43343bc0edcc7 commit 0d9346b1e64f41e97cd44a291ae43343bc0edcc7 Author: tsergeant <tsergeant@chromium.org> Date: Wed Mar 08 03:29:10 2017 MD Bookmarks: Implement basis for new data-binding system This CL adds two new classes to MD Bookmarks: - bookmarks.Store, a globally readable datastore which can only be modified through predefined actions. - bookmarks.StoreClient, a Polymer behavior for binding front-end Polymer elements to the global Store. These two classes form the basis for a new one-way dataflow system which we are building for MD Bookmarks. They are currently unused, but follow-up CLs will build up the remainder of the functionality (see bug for details). BUG= 697706 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2731473002 Cr-Commit-Position: refs/heads/master@{#455373} [modify] https://crrev.com/0d9346b1e64f41e97cd44a291ae43343bc0edcc7/chrome/browser/browser_resources.grd [add] https://crrev.com/0d9346b1e64f41e97cd44a291ae43343bc0edcc7/chrome/browser/resources/md_bookmarks/bookmarks_store.js [modify] https://crrev.com/0d9346b1e64f41e97cd44a291ae43343bc0edcc7/chrome/browser/resources/md_bookmarks/compiled_resources2.gyp [add] https://crrev.com/0d9346b1e64f41e97cd44a291ae43343bc0edcc7/chrome/browser/resources/md_bookmarks/reducers.html [add] https://crrev.com/0d9346b1e64f41e97cd44a291ae43343bc0edcc7/chrome/browser/resources/md_bookmarks/reducers.js [modify] https://crrev.com/0d9346b1e64f41e97cd44a291ae43343bc0edcc7/chrome/browser/resources/md_bookmarks/store.html [add] https://crrev.com/0d9346b1e64f41e97cd44a291ae43343bc0edcc7/chrome/browser/resources/md_bookmarks/store_client.html [add] https://crrev.com/0d9346b1e64f41e97cd44a291ae43343bc0edcc7/chrome/browser/resources/md_bookmarks/store_client.js [add] https://crrev.com/0d9346b1e64f41e97cd44a291ae43343bc0edcc7/chrome/browser/resources/md_bookmarks/types.js [modify] https://crrev.com/0d9346b1e64f41e97cd44a291ae43343bc0edcc7/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc [modify] https://crrev.com/0d9346b1e64f41e97cd44a291ae43343bc0edcc7/chrome/test/data/webui/md_bookmarks/md_bookmarks_browsertest.js [add] https://crrev.com/0d9346b1e64f41e97cd44a291ae43343bc0edcc7/chrome/test/data/webui/md_bookmarks/store_client_test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e522424f710ebb5378f17a1e55ce22b262e0433 commit 3e522424f710ebb5378f17a1e55ce22b262e0433 Author: tsergeant <tsergeant@chromium.org> Date: Thu Mar 09 03:33:21 2017 MD Bookmarks: Add basic page features to new data-flow system This adds the backend Action/Reducer functions required to support: - Showing/editing/removing bookmarks - Selecting which folder is displayed - Opening/closing folders in the sidebar Notable missing features are search and selection. This code is part of the new data-flow system and is currently only used by tests. It will be tied into UI elements in a follow-up CL; see bug for further details. BUG= 697706 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2733463002 Cr-Commit-Position: refs/heads/master@{#455655} [modify] https://crrev.com/3e522424f710ebb5378f17a1e55ce22b262e0433/chrome/browser/browser_resources.grd [add] https://crrev.com/3e522424f710ebb5378f17a1e55ce22b262e0433/chrome/browser/resources/md_bookmarks/actions.html [add] https://crrev.com/3e522424f710ebb5378f17a1e55ce22b262e0433/chrome/browser/resources/md_bookmarks/actions.js [modify] https://crrev.com/3e522424f710ebb5378f17a1e55ce22b262e0433/chrome/browser/resources/md_bookmarks/bookmarks_store.js [modify] https://crrev.com/3e522424f710ebb5378f17a1e55ce22b262e0433/chrome/browser/resources/md_bookmarks/compiled_resources2.gyp [modify] https://crrev.com/3e522424f710ebb5378f17a1e55ce22b262e0433/chrome/browser/resources/md_bookmarks/reducers.html [modify] https://crrev.com/3e522424f710ebb5378f17a1e55ce22b262e0433/chrome/browser/resources/md_bookmarks/reducers.js [modify] https://crrev.com/3e522424f710ebb5378f17a1e55ce22b262e0433/chrome/browser/resources/md_bookmarks/store.html [modify] https://crrev.com/3e522424f710ebb5378f17a1e55ce22b262e0433/chrome/browser/resources/md_bookmarks/types.js [add] https://crrev.com/3e522424f710ebb5378f17a1e55ce22b262e0433/chrome/browser/resources/md_bookmarks/util.html [add] https://crrev.com/3e522424f710ebb5378f17a1e55ce22b262e0433/chrome/browser/resources/md_bookmarks/util.js [modify] https://crrev.com/3e522424f710ebb5378f17a1e55ce22b262e0433/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc [modify] https://crrev.com/3e522424f710ebb5378f17a1e55ce22b262e0433/chrome/test/data/webui/md_bookmarks/md_bookmarks_browsertest.js [add] https://crrev.com/3e522424f710ebb5378f17a1e55ce22b262e0433/chrome/test/data/webui/md_bookmarks/reducers_test.js [modify] https://crrev.com/3e522424f710ebb5378f17a1e55ce22b262e0433/chrome/test/data/webui/md_bookmarks/test_util.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a958e2950a29ba6f293d95e3a93c3c0235db2b94 commit a958e2950a29ba6f293d95e3a93c3c0235db2b94 Author: tsergeant <tsergeant@chromium.org> Date: Fri Mar 10 03:54:14 2017 MD Bookmarks: Integrate new data store with UI elements MD Bookmarks is switching to a new data store layer to help with binding data changes to UI elements. This CL ties the new data store to the existing UI elements. Note that the new data store is currently missing a few features: * Item selection * Search * URL routing These features are broken by this CL (there are no user-visible feature regressions, since this is all behind a runtime flag), but will be added back in soon. BUG= 697706 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2735953002 Cr-Commit-Position: refs/heads/master@{#455981} [modify] https://crrev.com/a958e2950a29ba6f293d95e3a93c3c0235db2b94/chrome/browser/browser_resources.grd [add] https://crrev.com/a958e2950a29ba6f293d95e3a93c3c0235db2b94/chrome/browser/resources/md_bookmarks/api_listener.html [add] https://crrev.com/a958e2950a29ba6f293d95e3a93c3c0235db2b94/chrome/browser/resources/md_bookmarks/api_listener.js [modify] https://crrev.com/a958e2950a29ba6f293d95e3a93c3c0235db2b94/chrome/browser/resources/md_bookmarks/app.html [modify] https://crrev.com/a958e2950a29ba6f293d95e3a93c3c0235db2b94/chrome/browser/resources/md_bookmarks/app.js [modify] https://crrev.com/a958e2950a29ba6f293d95e3a93c3c0235db2b94/chrome/browser/resources/md_bookmarks/compiled_resources2.gyp [modify] https://crrev.com/a958e2950a29ba6f293d95e3a93c3c0235db2b94/chrome/browser/resources/md_bookmarks/folder_node.html [modify] https://crrev.com/a958e2950a29ba6f293d95e3a93c3c0235db2b94/chrome/browser/resources/md_bookmarks/folder_node.js [modify] https://crrev.com/a958e2950a29ba6f293d95e3a93c3c0235db2b94/chrome/browser/resources/md_bookmarks/item.html [modify] https://crrev.com/a958e2950a29ba6f293d95e3a93c3c0235db2b94/chrome/browser/resources/md_bookmarks/item.js [modify] https://crrev.com/a958e2950a29ba6f293d95e3a93c3c0235db2b94/chrome/browser/resources/md_bookmarks/list.html [modify] https://crrev.com/a958e2950a29ba6f293d95e3a93c3c0235db2b94/chrome/browser/resources/md_bookmarks/list.js [modify] https://crrev.com/a958e2950a29ba6f293d95e3a93c3c0235db2b94/chrome/browser/resources/md_bookmarks/reducers.html [modify] https://crrev.com/a958e2950a29ba6f293d95e3a93c3c0235db2b94/chrome/browser/resources/md_bookmarks/sidebar.html [modify] https://crrev.com/a958e2950a29ba6f293d95e3a93c3c0235db2b94/chrome/browser/resources/md_bookmarks/sidebar.js [modify] https://crrev.com/a958e2950a29ba6f293d95e3a93c3c0235db2b94/chrome/browser/resources/md_bookmarks/store_client.js [modify] https://crrev.com/a958e2950a29ba6f293d95e3a93c3c0235db2b94/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc [modify] https://crrev.com/a958e2950a29ba6f293d95e3a93c3c0235db2b94/chrome/test/data/webui/md_bookmarks/item_test.js [modify] https://crrev.com/a958e2950a29ba6f293d95e3a93c3c0235db2b94/chrome/test/data/webui/md_bookmarks/list_test.js [modify] https://crrev.com/a958e2950a29ba6f293d95e3a93c3c0235db2b94/chrome/test/data/webui/md_bookmarks/md_bookmarks_browsertest.js [modify] https://crrev.com/a958e2950a29ba6f293d95e3a93c3c0235db2b94/chrome/test/data/webui/md_bookmarks/sidebar_test.js [add] https://crrev.com/a958e2950a29ba6f293d95e3a93c3c0235db2b94/chrome/test/data/webui/md_bookmarks/test_store.js [modify] https://crrev.com/a958e2950a29ba6f293d95e3a93c3c0235db2b94/chrome/test/data/webui/md_bookmarks/test_util.js
End-of-week update: The core of the new system has landed and is in use. Some features are missing, but they'll be in code review next week. In the meantime, the core is stable enough to build new things on top of.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb410f3b8a762cc37f641494e308aec6919d0c60 commit bb410f3b8a762cc37f641494e308aec6919d0c60 Author: tsergeant <tsergeant@chromium.org> Date: Tue Mar 14 22:40:31 2017 MD Bookmarks: Implement search in new data flow system MD Bookmarks has switched to a new data flow system which makes it easier to bind and modify backend data from the UI. This CL implements search in this new system. BUG= 697706 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2740863003 Cr-Commit-Position: refs/heads/master@{#456870} [modify] https://crrev.com/bb410f3b8a762cc37f641494e308aec6919d0c60/chrome/browser/resources/md_bookmarks/actions.js [modify] https://crrev.com/bb410f3b8a762cc37f641494e308aec6919d0c60/chrome/browser/resources/md_bookmarks/app.js [modify] https://crrev.com/bb410f3b8a762cc37f641494e308aec6919d0c60/chrome/browser/resources/md_bookmarks/compiled_resources2.gyp [modify] https://crrev.com/bb410f3b8a762cc37f641494e308aec6919d0c60/chrome/browser/resources/md_bookmarks/item.js [modify] https://crrev.com/bb410f3b8a762cc37f641494e308aec6919d0c60/chrome/browser/resources/md_bookmarks/list.html [modify] https://crrev.com/bb410f3b8a762cc37f641494e308aec6919d0c60/chrome/browser/resources/md_bookmarks/list.js [modify] https://crrev.com/bb410f3b8a762cc37f641494e308aec6919d0c60/chrome/browser/resources/md_bookmarks/reducers.js [modify] https://crrev.com/bb410f3b8a762cc37f641494e308aec6919d0c60/chrome/browser/resources/md_bookmarks/toolbar.js [modify] https://crrev.com/bb410f3b8a762cc37f641494e308aec6919d0c60/chrome/browser/resources/md_bookmarks/types.js [modify] https://crrev.com/bb410f3b8a762cc37f641494e308aec6919d0c60/chrome/browser/resources/md_bookmarks/util.js [modify] https://crrev.com/bb410f3b8a762cc37f641494e308aec6919d0c60/chrome/test/data/webui/md_bookmarks/item_test.js [modify] https://crrev.com/bb410f3b8a762cc37f641494e308aec6919d0c60/chrome/test/data/webui/md_bookmarks/reducers_test.js [modify] https://crrev.com/bb410f3b8a762cc37f641494e308aec6919d0c60/chrome/test/data/webui/md_bookmarks/sidebar_test.js [modify] https://crrev.com/bb410f3b8a762cc37f641494e308aec6919d0c60/chrome/test/data/webui/md_bookmarks/test_util.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f32efd59c35df91f5f63866666702c139afcac4b commit f32efd59c35df91f5f63866666702c139afcac4b Author: tsergeant <tsergeant@chromium.org> Date: Wed Mar 15 04:41:04 2017 MD Bookmarks: Implement item selection in new data flow system MD Bookmarks has switched to a new data flow system which makes it easier to bind and modify backend data from the UI. This CL implements item selection in this new system, making it possible to select individual items and ctrl/shift select groups of items. BUG= 697706 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2741393002 Cr-Commit-Position: refs/heads/master@{#456996} [modify] https://crrev.com/f32efd59c35df91f5f63866666702c139afcac4b/chrome/browser/resources/md_bookmarks/actions.js [modify] https://crrev.com/f32efd59c35df91f5f63866666702c139afcac4b/chrome/browser/resources/md_bookmarks/item.js [modify] https://crrev.com/f32efd59c35df91f5f63866666702c139afcac4b/chrome/browser/resources/md_bookmarks/reducers.js [modify] https://crrev.com/f32efd59c35df91f5f63866666702c139afcac4b/chrome/browser/resources/md_bookmarks/types.js [modify] https://crrev.com/f32efd59c35df91f5f63866666702c139afcac4b/chrome/browser/resources/md_bookmarks/util.js [modify] https://crrev.com/f32efd59c35df91f5f63866666702c139afcac4b/chrome/test/data/webui/md_bookmarks/list_test.js [modify] https://crrev.com/f32efd59c35df91f5f63866666702c139afcac4b/chrome/test/data/webui/md_bookmarks/reducers_test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ea824c6614b1cc7f3e8b725fc138ba23518fb4b commit 0ea824c6614b1cc7f3e8b725fc138ba23518fb4b Author: tsergeant <tsergeant@chromium.org> Date: Thu Mar 16 04:45:36 2017 MD Bookmarks: Use consistent 'state' variable in reducers_test.js This eliminates the unnecessary distinction between 'initialState' and 'nextState'. BUG= 697706 Review-Url: https://codereview.chromium.org/2751543005 Cr-Commit-Position: refs/heads/master@{#457352} [modify] https://crrev.com/0ea824c6614b1cc7f3e8b725fc138ba23518fb4b/chrome/test/data/webui/md_bookmarks/reducers_test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/39932ca301fa70758c85d4b24c0e634fe693bd9a commit 39932ca301fa70758c85d4b24c0e634fe693bd9a Author: tsergeant <tsergeant@chromium.org> Date: Tue Mar 21 02:12:46 2017 MD Bookmarks: Update URL router to work in new data binding system BUG= 697706 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2745993002 Cr-Commit-Position: refs/heads/master@{#458279} [modify] https://crrev.com/39932ca301fa70758c85d4b24c0e634fe693bd9a/chrome/browser/resources/md_bookmarks/app.html [modify] https://crrev.com/39932ca301fa70758c85d4b24c0e634fe693bd9a/chrome/browser/resources/md_bookmarks/bookmarks_store.js [modify] https://crrev.com/39932ca301fa70758c85d4b24c0e634fe693bd9a/chrome/browser/resources/md_bookmarks/compiled_resources2.gyp [modify] https://crrev.com/39932ca301fa70758c85d4b24c0e634fe693bd9a/chrome/browser/resources/md_bookmarks/reducers.js [modify] https://crrev.com/39932ca301fa70758c85d4b24c0e634fe693bd9a/chrome/browser/resources/md_bookmarks/router.html [modify] https://crrev.com/39932ca301fa70758c85d4b24c0e634fe693bd9a/chrome/browser/resources/md_bookmarks/router.js [modify] https://crrev.com/39932ca301fa70758c85d4b24c0e634fe693bd9a/chrome/browser/resources/md_bookmarks/toolbar.js [modify] https://crrev.com/39932ca301fa70758c85d4b24c0e634fe693bd9a/chrome/test/data/webui/md_bookmarks/md_bookmarks_browsertest.js [add] https://crrev.com/39932ca301fa70758c85d4b24c0e634fe693bd9a/chrome/test/data/webui/md_bookmarks/router_test.js [modify] https://crrev.com/39932ca301fa70758c85d4b24c0e634fe693bd9a/chrome/test/data/webui/md_bookmarks/store_test.js [modify] https://crrev.com/39932ca301fa70758c85d4b24c0e634fe693bd9a/chrome/test/data/webui/md_bookmarks/test_util.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/75cea57aed3c1d1fa6c43d60f33a48501f62df4f commit 75cea57aed3c1d1fa6c43d60f33a48501f62df4f Author: tsergeant <tsergeant@chromium.org> Date: Wed Mar 22 11:11:35 2017 MD Bookmarks: Remove old bookmark data store MD Bookmarks has transitioned to a new data store and data flow method (see bug for context). This removes the old store (store.js), and moves the new store to take its place (from bookmarks_store.js to store.js). BUG= 697706 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2752173002 Cr-Commit-Position: refs/heads/master@{#458713} [modify] https://crrev.com/75cea57aed3c1d1fa6c43d60f33a48501f62df4f/chrome/browser/browser_resources.grd [delete] https://crrev.com/4e2b55c5fa7a354b3ae2f14e2f6d8201190a36a0/chrome/browser/resources/md_bookmarks/bookmarks_store.js [modify] https://crrev.com/75cea57aed3c1d1fa6c43d60f33a48501f62df4f/chrome/browser/resources/md_bookmarks/compiled_resources2.gyp [modify] https://crrev.com/75cea57aed3c1d1fa6c43d60f33a48501f62df4f/chrome/browser/resources/md_bookmarks/store.html [modify] https://crrev.com/75cea57aed3c1d1fa6c43d60f33a48501f62df4f/chrome/browser/resources/md_bookmarks/store.js [modify] https://crrev.com/75cea57aed3c1d1fa6c43d60f33a48501f62df4f/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc [modify] https://crrev.com/75cea57aed3c1d1fa6c43d60f33a48501f62df4f/chrome/test/data/webui/md_bookmarks/md_bookmarks_browsertest.js [delete] https://crrev.com/4e2b55c5fa7a354b3ae2f14e2f6d8201190a36a0/chrome/test/data/webui/md_bookmarks/store_test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65d1e47c314fee42363b652ddbccf0dbea9a73c7 commit 65d1e47c314fee42363b652ddbccf0dbea9a73c7 Author: calamity <calamity@chromium.org> Date: Tue Apr 04 07:53:00 2017 [MD Bookmarks] Change selection items from Map to Set. This CL changes the type of the selection items to a Set to accurately reflect the data being stored. BUG= 697706 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2774233006 Cr-Commit-Position: refs/heads/master@{#461655} [modify] https://crrev.com/65d1e47c314fee42363b652ddbccf0dbea9a73c7/chrome/browser/resources/md_bookmarks/app.js [modify] https://crrev.com/65d1e47c314fee42363b652ddbccf0dbea9a73c7/chrome/browser/resources/md_bookmarks/dnd_manager.js [modify] https://crrev.com/65d1e47c314fee42363b652ddbccf0dbea9a73c7/chrome/browser/resources/md_bookmarks/folder_node.js [modify] https://crrev.com/65d1e47c314fee42363b652ddbccf0dbea9a73c7/chrome/browser/resources/md_bookmarks/item.js [modify] https://crrev.com/65d1e47c314fee42363b652ddbccf0dbea9a73c7/chrome/browser/resources/md_bookmarks/reducers.js [modify] https://crrev.com/65d1e47c314fee42363b652ddbccf0dbea9a73c7/chrome/browser/resources/md_bookmarks/types.js [modify] https://crrev.com/65d1e47c314fee42363b652ddbccf0dbea9a73c7/chrome/browser/resources/md_bookmarks/util.js [modify] https://crrev.com/65d1e47c314fee42363b652ddbccf0dbea9a73c7/chrome/test/data/webui/md_bookmarks/app_test.js [modify] https://crrev.com/65d1e47c314fee42363b652ddbccf0dbea9a73c7/chrome/test/data/webui/md_bookmarks/dnd_manager_test.js [modify] https://crrev.com/65d1e47c314fee42363b652ddbccf0dbea9a73c7/chrome/test/data/webui/md_bookmarks/reducers_test.js [modify] https://crrev.com/65d1e47c314fee42363b652ddbccf0dbea9a73c7/chrome/test/data/webui/md_bookmarks/test_util.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ff66de077810f11a905d267687e29a644902fd87 commit ff66de077810f11a905d267687e29a644902fd87 Author: tsergeant <tsergeant@chromium.org> Date: Wed Apr 05 02:48:20 2017 MD Bookmarks: Remove deleted nodes from state tree This clears out deleted nodes (and their descendants) from all areas of the state tree: - The node data is removed from the core node map - The nodes are unselected - If the selected folder was deleted, show the parent - Remove any deleted nodes from search results BUG= 697706 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2752223004 Cr-Commit-Position: refs/heads/master@{#461953} [modify] https://crrev.com/ff66de077810f11a905d267687e29a644902fd87/chrome/browser/resources/md_bookmarks/actions.js [modify] https://crrev.com/ff66de077810f11a905d267687e29a644902fd87/chrome/browser/resources/md_bookmarks/api_listener.js [modify] https://crrev.com/ff66de077810f11a905d267687e29a644902fd87/chrome/browser/resources/md_bookmarks/reducers.js [modify] https://crrev.com/ff66de077810f11a905d267687e29a644902fd87/chrome/browser/resources/md_bookmarks/store_client.js [modify] https://crrev.com/ff66de077810f11a905d267687e29a644902fd87/chrome/browser/resources/md_bookmarks/util.js [modify] https://crrev.com/ff66de077810f11a905d267687e29a644902fd87/chrome/test/data/webui/md_bookmarks/md_bookmarks_browsertest.js [modify] https://crrev.com/ff66de077810f11a905d267687e29a644902fd87/chrome/test/data/webui/md_bookmarks/reducers_test.js [add] https://crrev.com/ff66de077810f11a905d267687e29a644902fd87/chrome/test/data/webui/md_bookmarks/util_test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b466a02f6480a6f2823b823fc69f4f693377863e commit b466a02f6480a6f2823b823fc69f4f693377863e Author: tsergeant <tsergeant@chromium.org> Date: Tue Apr 11 06:29:09 2017 MD Bookmarks: Restore any previously selected folder when clearing search With this change, clearing a search in the MD Bookmarks manager will restore the folder that was selected before the search was started. There is no other change to URL routing or page UI while a search is active. To achieve this, the |state.selectedFolder| variable is never set to null -- it is now always set to the most recently selected folder. BUG= 697706 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2812493002 Cr-Commit-Position: refs/heads/master@{#463553} [modify] https://crrev.com/b466a02f6480a6f2823b823fc69f4f693377863e/chrome/browser/resources/md_bookmarks/folder_node.js [modify] https://crrev.com/b466a02f6480a6f2823b823fc69f4f693377863e/chrome/browser/resources/md_bookmarks/reducers.js [modify] https://crrev.com/b466a02f6480a6f2823b823fc69f4f693377863e/chrome/browser/resources/md_bookmarks/types.js [modify] https://crrev.com/b466a02f6480a6f2823b823fc69f4f693377863e/chrome/browser/resources/md_bookmarks/util.js [modify] https://crrev.com/b466a02f6480a6f2823b823fc69f4f693377863e/chrome/test/data/webui/md_bookmarks/reducers_test.js [modify] https://crrev.com/b466a02f6480a6f2823b823fc69f4f693377863e/chrome/test/data/webui/md_bookmarks/router_test.js [modify] https://crrev.com/b466a02f6480a6f2823b823fc69f4f693377863e/chrome/test/data/webui/md_bookmarks/sidebar_test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/43e3e93c7545059876bb72db535115a32299689d commit 43e3e93c7545059876bb72db535115a32299689d Author: calamity <calamity@chromium.org> Date: Tue Apr 11 08:07:07 2017 [MD Bookmarks] Rename reducer test states. BUG= 697706 Review-Url: https://codereview.chromium.org/2791403006 Cr-Commit-Position: refs/heads/master@{#463572} [modify] https://crrev.com/43e3e93c7545059876bb72db535115a32299689d/chrome/test/data/webui/md_bookmarks/reducers_test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d328a8fc03fdbdf4fbe0c74652108f2c28436cff commit d328a8fc03fdbdf4fbe0c74652108f2c28436cff Author: tsergeant <tsergeant@chromium.org> Date: Wed Apr 12 07:46:07 2017 MD Bookmarks: Improve test coverage for Actions and Routing This adds a new test file for tests of actions, and changes how routing tests are run so that it is possible to add new tests for routing initialization without adding a new browser test for each URL to be tested. BUG= 697706 Review-Url: https://codereview.chromium.org/2808333004 Cr-Commit-Position: refs/heads/master@{#463946} [add] https://crrev.com/d328a8fc03fdbdf4fbe0c74652108f2c28436cff/chrome/test/data/webui/md_bookmarks/actions_test.js [modify] https://crrev.com/d328a8fc03fdbdf4fbe0c74652108f2c28436cff/chrome/test/data/webui/md_bookmarks/list_test.js [modify] https://crrev.com/d328a8fc03fdbdf4fbe0c74652108f2c28436cff/chrome/test/data/webui/md_bookmarks/md_bookmarks_browsertest.js [modify] https://crrev.com/d328a8fc03fdbdf4fbe0c74652108f2c28436cff/chrome/test/data/webui/md_bookmarks/router_test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5cdc120ce13ae37a6019159936d54920556f9b54 commit 5cdc120ce13ae37a6019159936d54920556f9b54 Author: tsergeant <tsergeant@chromium.org> Date: Thu Apr 27 06:40:34 2017 MD Bookmarks: Update TestStore API This changes TestStore to inherit from Store, allowing tests to use more production code paths. It also adds a new flag to TestStore which allows page actions to be handled normally (rather than preventing them from executing), which is useful for integration testing. BUG= 697706 Review-Url: https://codereview.chromium.org/2839393002 Cr-Commit-Position: refs/heads/master@{#467607} [modify] https://crrev.com/5cdc120ce13ae37a6019159936d54920556f9b54/chrome/test/data/webui/md_bookmarks/test_store.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2458d402ef27e41616c41e17e3e41d7bc683c196 commit 2458d402ef27e41616c41e17e3e41d7bc683c196 Author: tsergeant <tsergeant@chromium.org> Date: Tue May 02 06:49:49 2017 MD Bookmarks: Update a couple of TODOs This completes one TODO (adding an error message to StoreClient), and removes another obsolete TODO. BUG= 697706 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2858483002 Cr-Commit-Position: refs/heads/master@{#468574} [modify] https://crrev.com/2458d402ef27e41616c41e17e3e41d7bc683c196/chrome/browser/resources/md_bookmarks/store_client.js [modify] https://crrev.com/2458d402ef27e41616c41e17e3e41d7bc683c196/chrome/test/data/webui/md_bookmarks/test_store.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c17b37ab36a216c3923da51e382d531efc61c35e commit c17b37ab36a216c3923da51e382d531efc61c35e Author: tsergeant <tsergeant@chromium.org> Date: Thu May 04 07:31:11 2017 MD Bookmarks: Prevent navigating to invalid folders This CL prevents items or non-existent IDs from being navigated to. In order to achieve this, we add support for 'deferred actions', which allow actions to be created asynchronously. Deferred actions are currently only used for selecting folders from the Router, but will be used to simplify search in a follow-up CL. BUG= 697706 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2813503002 Cr-Commit-Position: refs/heads/master@{#469290} [modify] https://crrev.com/c17b37ab36a216c3923da51e382d531efc61c35e/chrome/browser/resources/md_bookmarks/actions.js [modify] https://crrev.com/c17b37ab36a216c3923da51e382d531efc61c35e/chrome/browser/resources/md_bookmarks/api_listener.js [modify] https://crrev.com/c17b37ab36a216c3923da51e382d531efc61c35e/chrome/browser/resources/md_bookmarks/dnd_manager.js [modify] https://crrev.com/c17b37ab36a216c3923da51e382d531efc61c35e/chrome/browser/resources/md_bookmarks/folder_node.js [modify] https://crrev.com/c17b37ab36a216c3923da51e382d531efc61c35e/chrome/browser/resources/md_bookmarks/item.js [modify] https://crrev.com/c17b37ab36a216c3923da51e382d531efc61c35e/chrome/browser/resources/md_bookmarks/reducers.js [modify] https://crrev.com/c17b37ab36a216c3923da51e382d531efc61c35e/chrome/browser/resources/md_bookmarks/router.js [modify] https://crrev.com/c17b37ab36a216c3923da51e382d531efc61c35e/chrome/browser/resources/md_bookmarks/store.js [modify] https://crrev.com/c17b37ab36a216c3923da51e382d531efc61c35e/chrome/browser/resources/md_bookmarks/store_client.js [modify] https://crrev.com/c17b37ab36a216c3923da51e382d531efc61c35e/chrome/browser/resources/md_bookmarks/types.js [modify] https://crrev.com/c17b37ab36a216c3923da51e382d531efc61c35e/chrome/test/data/webui/md_bookmarks/actions_test.js [modify] https://crrev.com/c17b37ab36a216c3923da51e382d531efc61c35e/chrome/test/data/webui/md_bookmarks/router_test.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bdcfd1d3fd877ff71ae43f45a73daa3e773b130f commit bdcfd1d3fd877ff71ae43f45a73daa3e773b130f Author: tsergeant <tsergeant@chromium.org> Date: Fri Jun 23 00:47:37 2017 MD Bookmarks: Deselect items when they are moved to a new folder This fixes an issue where the multi-select toolbar would still appear after the selected items had been moved to a different folder. BUG= 697706 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2946883002 Cr-Commit-Position: refs/heads/master@{#481749} [modify] https://crrev.com/bdcfd1d3fd877ff71ae43f45a73daa3e773b130f/chrome/browser/resources/md_bookmarks/reducers.js [modify] https://crrev.com/bdcfd1d3fd877ff71ae43f45a73daa3e773b130f/chrome/test/data/webui/md_bookmarks/reducers_test.js
Comment 1 by tsergeant@chromium.org
, Mar 2 2017