New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 697695 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit 22 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Background Loader should track network bytes loaded

Project Member Reported by chili@chromium.org, Mar 2 2017

Issue description

PrerendererLoader recently landed https://codereview.chromium.org/2697963002/, which allows loading progress to be tracked and reflected in UI.

This comes from prerender-based piece of code in https://cs.chromium.org/chromium/src/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc?rcl=6a23306766d02a480c7992f91b51e9691d6511b8&l=173

Justin suggested subscribing to ChromeDataUseAscriber

 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2fc623943d585acb44512ebafb626acd7b3f217

commit f2fc623943d585acb44512ebafb626acd7b3f217
Author: chili <chili@chromium.org>
Date: Wed Mar 15 19:21:52 2017

[Offline Pages] Allow BackgroundLoader to track network bytes using prerenderer hook-in.

While this hook-in is less than ideal, allow us to unblock while architecting a better solution that will account for bytes, does not block net moving OOP, and at a rate frequent enough to be suitable.

BUG= 697695 

Review-Url: https://codereview.chromium.org/2737343002
Cr-Commit-Position: refs/heads/master@{#457163}

[modify] https://crrev.com/f2fc623943d585acb44512ebafb626acd7b3f217/chrome/browser/android/offline_pages/background_loader_offliner.cc
[modify] https://crrev.com/f2fc623943d585acb44512ebafb626acd7b3f217/chrome/browser/android/offline_pages/background_loader_offliner.h
[modify] https://crrev.com/f2fc623943d585acb44512ebafb626acd7b3f217/chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc
[modify] https://crrev.com/f2fc623943d585acb44512ebafb626acd7b3f217/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc

Comment 2 by chili@chromium.org, Mar 15 2017

Labels: Merge-Request-58
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 15 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 15 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4aab820ad80af5963d9531184bb0cd24a5029c9a

commit 4aab820ad80af5963d9531184bb0cd24a5029c9a
Author: Justin DeWitt <dewittj@chromium.org>
Date: Wed Mar 15 21:06:35 2017

[Offline Pages] Allow BackgroundLoader to track network bytes using prerenderer hook-in.

While this hook-in is less than ideal, allow us to unblock while architecting a better solution that will account for bytes, does not block net moving OOP, and at a rate frequent enough to be suitable.

BUG= 697695 

Review-Url: https://codereview.chromium.org/2737343002
Cr-Commit-Position: refs/heads/master@{#457163}
(cherry picked from commit f2fc623943d585acb44512ebafb626acd7b3f217)

Review-Url: https://codereview.chromium.org/2748053004 .
Cr-Commit-Position: refs/branch-heads/3029@{#217}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/4aab820ad80af5963d9531184bb0cd24a5029c9a/chrome/browser/android/offline_pages/background_loader_offliner.cc
[modify] https://crrev.com/4aab820ad80af5963d9531184bb0cd24a5029c9a/chrome/browser/android/offline_pages/background_loader_offliner.h
[modify] https://crrev.com/4aab820ad80af5963d9531184bb0cd24a5029c9a/chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc
[modify] https://crrev.com/4aab820ad80af5963d9531184bb0cd24a5029c9a/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc

Comment 5 by chili@chromium.org, Mar 20 2017

Status: Fixed (was: Assigned)

Sign in to add a comment