New issue
Advanced search Search tips

Issue 697694 link

Starred by 2 users
Status: WontFix
Owner:
mthiesse@chromium.org
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Figure out how to stop the incognito profile from being destroyed while it's in use by VR.

Project Member Reported by mthiesse@chromium.org, Mar 2 2017 
CTA#onResumeWithNative calls Profile.getLastUsedProfile().getOffTheRecordProfile().destroyWhenAppropriate(), which destroys the incognito profile used by the VrShell UI WebContents if it has already been created.

This means we can't create the WebContents in ChromeActivity#onResumeWithNative, because CTA#onResumeWithNative runs after.

Comment 1 by mthiesse@chromium.org, Mar 22 2017

Summary: Figure out how to stop the incognito profile from being destroyed while it's in use by VR. (was: Figure out how to stop ChromeTabbedActivity from destroying VrShell UI incognito WebContents when it resumes.)
While I think CTA#onResumeWithNative is the only spot that could destroy our profile while in VR, when we add the ability to close tabs in VR we'll need to be careful that closing incognito tabs doesn't destroy our profile as well.

Comment 2 by mthiesse@chromium.org, Mar 22 2017

Labels: VR-DF

Comment 3 by mthiesse@chromium.org, Mar 24 2017

Blocking: -688611

Comment 4 by mthiesse@chromium.org, Apr 5 2017

Status: WontFix (was: Available)
►

Sign in to add a comment