New issue
Advanced search Search tips

Issue 697692 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 596760



Sign in to add a comment

Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/html/parser/

Project Member Reported by tkent@chromium.org, Mar 2 2017

Issue description

Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT with DCHECK_op, NOTREACHED, CHECK_op respectively.

 
Status: Started (was: Untriaged)
I will start working on this.
Owner: hs1217....@samsung.com
it is reviewing (https://codereview.chromium.org/2751483005/).
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93578226fe0366d00cf97b5e588e51ff1cd56885

commit 93578226fe0366d00cf97b5e588e51ff1cd56885
Author: hs1217.lee <hs1217.lee@samsung.com>
Date: Tue Mar 21 16:50:20 2017

Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/html/parser/

Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT with DCHECK_op,
NOTREACHED, CHECK_op respectively.

BUG= 697692 

Review-Url: https://codereview.chromium.org/2751483005
Cr-Commit-Position: refs/heads/master@{#458439}

[modify] https://crrev.com/93578226fe0366d00cf97b5e588e51ff1cd56885/third_party/WebKit/Source/core/html/parser/AtomicHTMLToken.h
[modify] https://crrev.com/93578226fe0366d00cf97b5e588e51ff1cd56885/third_party/WebKit/Source/core/html/parser/BackgroundHTMLInputStream.cpp
[modify] https://crrev.com/93578226fe0366d00cf97b5e588e51ff1cd56885/third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.cpp
[modify] https://crrev.com/93578226fe0366d00cf97b5e588e51ff1cd56885/third_party/WebKit/Source/core/html/parser/CSSPreloadScanner.cpp
[modify] https://crrev.com/93578226fe0366d00cf97b5e588e51ff1cd56885/third_party/WebKit/Source/core/html/parser/CompactHTMLToken.cpp
[modify] https://crrev.com/93578226fe0366d00cf97b5e588e51ff1cd56885/third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp
[modify] https://crrev.com/93578226fe0366d00cf97b5e588e51ff1cd56885/third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.h
[modify] https://crrev.com/93578226fe0366d00cf97b5e588e51ff1cd56885/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp
[modify] https://crrev.com/93578226fe0366d00cf97b5e588e51ff1cd56885/third_party/WebKit/Source/core/html/parser/HTMLElementStack.cpp
[modify] https://crrev.com/93578226fe0366d00cf97b5e588e51ff1cd56885/third_party/WebKit/Source/core/html/parser/HTMLElementStack.h
[modify] https://crrev.com/93578226fe0366d00cf97b5e588e51ff1cd56885/third_party/WebKit/Source/core/html/parser/HTMLEntityParser.cpp
[modify] https://crrev.com/93578226fe0366d00cf97b5e588e51ff1cd56885/third_party/WebKit/Source/core/html/parser/HTMLEntityParser.h
[modify] https://crrev.com/93578226fe0366d00cf97b5e588e51ff1cd56885/third_party/WebKit/Source/core/html/parser/HTMLEntitySearch.cpp
[modify] https://crrev.com/93578226fe0366d00cf97b5e588e51ff1cd56885/third_party/WebKit/Source/core/html/parser/HTMLFormattingElementList.cpp
[modify] https://crrev.com/93578226fe0366d00cf97b5e588e51ff1cd56885/third_party/WebKit/Source/core/html/parser/HTMLFormattingElementList.h
[modify] https://crrev.com/93578226fe0366d00cf97b5e588e51ff1cd56885/third_party/WebKit/Source/core/html/parser/HTMLMetaCharsetParser.cpp
[modify] https://crrev.com/93578226fe0366d00cf97b5e588e51ff1cd56885/third_party/WebKit/Source/core/html/parser/HTMLParserIdioms.cpp
[modify] https://crrev.com/93578226fe0366d00cf97b5e588e51ff1cd56885/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp
[modify] https://crrev.com/93578226fe0366d00cf97b5e588e51ff1cd56885/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp
[modify] https://crrev.com/93578226fe0366d00cf97b5e588e51ff1cd56885/third_party/WebKit/Source/core/html/parser/HTMLSourceTracker.cpp
[modify] https://crrev.com/93578226fe0366d00cf97b5e588e51ff1cd56885/third_party/WebKit/Source/core/html/parser/HTMLSrcsetParser.cpp
[modify] https://crrev.com/93578226fe0366d00cf97b5e588e51ff1cd56885/third_party/WebKit/Source/core/html/parser/HTMLSrcsetParser.h
[modify] https://crrev.com/93578226fe0366d00cf97b5e588e51ff1cd56885/third_party/WebKit/Source/core/html/parser/HTMLStackItem.h
[modify] https://crrev.com/93578226fe0366d00cf97b5e588e51ff1cd56885/third_party/WebKit/Source/core/html/parser/HTMLToken.h
[modify] https://crrev.com/93578226fe0366d00cf97b5e588e51ff1cd56885/third_party/WebKit/Source/core/html/parser/HTMLTokenizer.cpp
[modify] https://crrev.com/93578226fe0366d00cf97b5e588e51ff1cd56885/third_party/WebKit/Source/core/html/parser/HTMLTokenizer.h
[modify] https://crrev.com/93578226fe0366d00cf97b5e588e51ff1cd56885/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp
[modify] https://crrev.com/93578226fe0366d00cf97b5e588e51ff1cd56885/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.h
[modify] https://crrev.com/93578226fe0366d00cf97b5e588e51ff1cd56885/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp
[modify] https://crrev.com/93578226fe0366d00cf97b5e588e51ff1cd56885/third_party/WebKit/Source/core/html/parser/HTMLViewSourceParser.h
[modify] https://crrev.com/93578226fe0366d00cf97b5e588e51ff1cd56885/third_party/WebKit/Source/core/html/parser/InputStreamPreprocessor.h
[modify] https://crrev.com/93578226fe0366d00cf97b5e588e51ff1cd56885/third_party/WebKit/Source/core/html/parser/PreloadRequest.cpp
[modify] https://crrev.com/93578226fe0366d00cf97b5e588e51ff1cd56885/third_party/WebKit/Source/core/html/parser/TextResourceDecoder.cpp
[modify] https://crrev.com/93578226fe0366d00cf97b5e588e51ff1cd56885/third_party/WebKit/Source/core/html/parser/XSSAuditor.cpp
[modify] https://crrev.com/93578226fe0366d00cf97b5e588e51ff1cd56885/third_party/WebKit/Source/core/html/parser/XSSAuditorDelegate.cpp

Cc: tkent@chromium.org
Status: Fixed (was: Started)

Sign in to add a comment