Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT with DCHECK_op, NOTREACHED, CHECK_op respectively.
Maybe we can do this with a burndown-style day & spreadsheet.
I'll work on this.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ef33b2cfea95309080e9d7f452233e0e780d5d8 commit 8ef33b2cfea95309080e9d7f452233e0e780d5d8 Author: nikhil.sahni <nikhil.sahni@samsung.com> Date: Thu Mar 16 15:12:20 2017 Replace ASSERT and ASSERT_NOT_REACHED in core/style/ Replacing ASSERT and ASSERT_NOT_REACHED in core/style/ with DCHECK_op, NOTREACHED respectively. BUG= 697688 Review-Url: https://codereview.chromium.org/2751653003 Cr-Commit-Position: refs/heads/master@{#457437} [modify] https://crrev.com/8ef33b2cfea95309080e9d7f452233e0e780d5d8/AUTHORS [modify] https://crrev.com/8ef33b2cfea95309080e9d7f452233e0e780d5d8/third_party/WebKit/Source/core/style/BasicShapes.cpp [modify] https://crrev.com/8ef33b2cfea95309080e9d7f452233e0e780d5d8/third_party/WebKit/Source/core/style/BorderEdge.cpp [modify] https://crrev.com/8ef33b2cfea95309080e9d7f452233e0e780d5d8/third_party/WebKit/Source/core/style/BorderImageLength.h [modify] https://crrev.com/8ef33b2cfea95309080e9d7f452233e0e780d5d8/third_party/WebKit/Source/core/style/ClipPathOperation.h [modify] https://crrev.com/8ef33b2cfea95309080e9d7f452233e0e780d5d8/third_party/WebKit/Source/core/style/ComputedStyle.cpp [modify] https://crrev.com/8ef33b2cfea95309080e9d7f452233e0e780d5d8/third_party/WebKit/Source/core/style/ContentData.h [modify] https://crrev.com/8ef33b2cfea95309080e9d7f452233e0e780d5d8/third_party/WebKit/Source/core/style/CounterDirectives.h [modify] https://crrev.com/8ef33b2cfea95309080e9d7f452233e0e780d5d8/third_party/WebKit/Source/core/style/DataPersistent.h [modify] https://crrev.com/8ef33b2cfea95309080e9d7f452233e0e780d5d8/third_party/WebKit/Source/core/style/DataRef.h [modify] https://crrev.com/8ef33b2cfea95309080e9d7f452233e0e780d5d8/third_party/WebKit/Source/core/style/FillLayer.h [modify] https://crrev.com/8ef33b2cfea95309080e9d7f452233e0e780d5d8/third_party/WebKit/Source/core/style/GridArea.h [modify] https://crrev.com/8ef33b2cfea95309080e9d7f452233e0e780d5d8/third_party/WebKit/Source/core/style/GridLength.h [modify] https://crrev.com/8ef33b2cfea95309080e9d7f452233e0e780d5d8/third_party/WebKit/Source/core/style/GridPosition.h [modify] https://crrev.com/8ef33b2cfea95309080e9d7f452233e0e780d5d8/third_party/WebKit/Source/core/style/GridPositionsResolver.cpp [modify] https://crrev.com/8ef33b2cfea95309080e9d7f452233e0e780d5d8/third_party/WebKit/Source/core/style/QuotesData.cpp [modify] https://crrev.com/8ef33b2cfea95309080e9d7f452233e0e780d5d8/third_party/WebKit/Source/core/style/SVGComputedStyle.cpp [modify] https://crrev.com/8ef33b2cfea95309080e9d7f452233e0e780d5d8/third_party/WebKit/Source/core/style/ShadowData.cpp [modify] https://crrev.com/8ef33b2cfea95309080e9d7f452233e0e780d5d8/third_party/WebKit/Source/core/style/ShadowList.h [modify] https://crrev.com/8ef33b2cfea95309080e9d7f452233e0e780d5d8/third_party/WebKit/Source/core/style/ShapeValue.h [modify] https://crrev.com/8ef33b2cfea95309080e9d7f452233e0e780d5d8/third_party/WebKit/Source/core/style/StyleDifference.h [modify] https://crrev.com/8ef33b2cfea95309080e9d7f452233e0e780d5d8/third_party/WebKit/Source/core/style/StylePath.cpp [modify] https://crrev.com/8ef33b2cfea95309080e9d7f452233e0e780d5d8/third_party/WebKit/Source/core/style/StylePendingImage.h
Thanks for working on this Nikhil!
Welcome Meade !!! , working on CSS folder now !!!
Submitted https://codereview.chromium.org/2755493004/ for consideration.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c commit 40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c Author: nikhil.sahni <nikhil.sahni@samsung.com> Date: Mon Apr 03 14:15:24 2017 Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/ Replacing ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/css/ with DCHECK_op, NOTREACHED,CHECK_op respectively BUG= 697688 Review-Url: https://codereview.chromium.org/2755493004 Cr-Commit-Position: refs/heads/master@{#461424} [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/ActiveStyleSheets.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/AffectedByFocusTest.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/BasicShapeFunctions.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/CSSBorderImageSliceValue.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/CSSCalculationValue.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/CSSCalculationValue.h [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/CSSCrossfadeValue.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/CSSCustomIdentValue.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/CSSCustomPropertyDeclaration.h [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/CSSFontFace.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/CSSFontFace.h [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/CSSFontFaceRule.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/CSSFontFaceSrcValue.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/CSSFontSelector.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/CSSGlobalRuleSet.h [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/CSSGradientValue.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/CSSGridAutoRepeatValue.h [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/CSSGridTemplateAreasValue.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/CSSGroupingRule.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/CSSImageGeneratorValue.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/CSSImageSetValue.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/CSSImageValue.h [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/CSSImportRule.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/CSSKeyframeRule.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/CSSKeyframesRule.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/CSSPageRule.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/CSSPageRuleTest.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/CSSPaintImageGenerator.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/CSSPathValue.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/CSSPrimitiveValue.h [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/CSSProperty.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/CSSSegmentedFontFace.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/CSSSelector.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/CSSSelector.h [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/CSSSelectorList.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/CSSStyleRule.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/CSSToLengthConversionData.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/CSSToLengthConversionData.h [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/CSSValue.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/CSSValueList.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/CSSValuePair.h [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/CSSViewportRule.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/DOMWindowCSS.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/ElementRuleCollector.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/ElementRuleCollector.h [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/FontFace.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/FontFaceSet.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/FontSize.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/FontSize.h [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/MediaQueryEvaluator.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/MediaQueryExp.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/MediaQueryMatcher.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/MediaValues.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/MediaValuesCached.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/MediaValuesDynamic.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/PageRuleCollector.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.h [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/RuleFeature.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/RuleSet.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/RuleSet.h [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/SelectorChecker.h [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/SelectorFilter.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/SelectorFilter.h [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/StyleColor.h [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/StyleMedia.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/StylePropertySet.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/StylePropertyShorthandCustom.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/StyleRule.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/StyleRuleImport.h [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/StyleRuleKeyframe.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/StyleSheetContents.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/StyleSheetContents.h [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/invalidation/InvalidationSet.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/invalidation/InvalidationSet.h [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/parser/CSSAtRuleID.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/parser/CSSParserToken.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/parser/CSSParserToken.h [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/parser/CSSParserTokenRange.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/parser/CSSSupportsParser.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/parser/CSSTokenizer.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/parser/CSSVariableParser.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/parser/MediaQueryBlockWatcher.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/parser/SizesAttributeParser.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/parser/SizesCalcParser.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/resolver/AnimatedStyleBuilder.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/resolver/CSSToStyleMap.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/resolver/ElementStyleResources.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/resolver/FontBuilder.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/resolver/MatchedPropertiesCache.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/resolver/MatchedPropertiesCache.h [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/resolver/SelectorFilterParentScope.h [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/resolver/SharedStyleFinder.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/resolver/TransformBuilder.cpp [modify] https://crrev.com/40d2d3bce2cb1a8cb77c460866f818d1a0a3c75c/third_party/WebKit/Source/core/css/resolver/ViewportStyleResolver.cpp
Comment 1 by tkent@chromium.org
, Mar 2 2017