Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT with DCHECK_op, NOTREACHED, CHECK_op respectively.
I will start working on this.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf49c415e86cf6b784a003426f2a5556eba950d5 commit cf49c415e86cf6b784a003426f2a5556eba950d5 Author: mrunal.kapade <mrunal.kapade@intel.com> Date: Wed Mar 15 00:00:54 2017 Replace ASSERT_NOT_REACHED with NOTREACHED in core/svg/ BUG= 697687 Review-Url: https://codereview.chromium.org/2748223002 Cr-Commit-Position: refs/heads/master@{#456901} [modify] https://crrev.com/cf49c415e86cf6b784a003426f2a5556eba950d5/third_party/WebKit/Source/core/svg/SVGAngle.cpp [modify] https://crrev.com/cf49c415e86cf6b784a003426f2a5556eba950d5/third_party/WebKit/Source/core/svg/SVGAnimatedColor.cpp [modify] https://crrev.com/cf49c415e86cf6b784a003426f2a5556eba950d5/third_party/WebKit/Source/core/svg/SVGBoolean.cpp [modify] https://crrev.com/cf49c415e86cf6b784a003426f2a5556eba950d5/third_party/WebKit/Source/core/svg/SVGEnumeration.cpp [modify] https://crrev.com/cf49c415e86cf6b784a003426f2a5556eba950d5/third_party/WebKit/Source/core/svg/SVGFEBlendElement.cpp [modify] https://crrev.com/cf49c415e86cf6b784a003426f2a5556eba950d5/third_party/WebKit/Source/core/svg/SVGLengthContext.cpp [modify] https://crrev.com/cf49c415e86cf6b784a003426f2a5556eba950d5/third_party/WebKit/Source/core/svg/SVGParsingError.cpp [modify] https://crrev.com/cf49c415e86cf6b784a003426f2a5556eba950d5/third_party/WebKit/Source/core/svg/SVGPathBlender.cpp [modify] https://crrev.com/cf49c415e86cf6b784a003426f2a5556eba950d5/third_party/WebKit/Source/core/svg/SVGPathBuilder.cpp [modify] https://crrev.com/cf49c415e86cf6b784a003426f2a5556eba950d5/third_party/WebKit/Source/core/svg/SVGPathByteStreamBuilder.cpp [modify] https://crrev.com/cf49c415e86cf6b784a003426f2a5556eba950d5/third_party/WebKit/Source/core/svg/SVGPathByteStreamSource.cpp [modify] https://crrev.com/cf49c415e86cf6b784a003426f2a5556eba950d5/third_party/WebKit/Source/core/svg/SVGPathParser.cpp [modify] https://crrev.com/cf49c415e86cf6b784a003426f2a5556eba950d5/third_party/WebKit/Source/core/svg/SVGPathQuery.cpp [modify] https://crrev.com/cf49c415e86cf6b784a003426f2a5556eba950d5/third_party/WebKit/Source/core/svg/SVGPathStringBuilder.cpp [modify] https://crrev.com/cf49c415e86cf6b784a003426f2a5556eba950d5/third_party/WebKit/Source/core/svg/SVGPathStringSource.cpp [modify] https://crrev.com/cf49c415e86cf6b784a003426f2a5556eba950d5/third_party/WebKit/Source/core/svg/SVGPreserveAspectRatio.cpp [modify] https://crrev.com/cf49c415e86cf6b784a003426f2a5556eba950d5/third_party/WebKit/Source/core/svg/SVGSVGElement.cpp [modify] https://crrev.com/cf49c415e86cf6b784a003426f2a5556eba950d5/third_party/WebKit/Source/core/svg/SVGStaticStringList.cpp [modify] https://crrev.com/cf49c415e86cf6b784a003426f2a5556eba950d5/third_party/WebKit/Source/core/svg/SVGStringList.cpp [modify] https://crrev.com/cf49c415e86cf6b784a003426f2a5556eba950d5/third_party/WebKit/Source/core/svg/SVGTransform.cpp [modify] https://crrev.com/cf49c415e86cf6b784a003426f2a5556eba950d5/third_party/WebKit/Source/core/svg/SVGTransformDistance.cpp [modify] https://crrev.com/cf49c415e86cf6b784a003426f2a5556eba950d5/third_party/WebKit/Source/core/svg/SVGTransformList.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf7da999a0c77771e582ed3e29e56c79027655a7 commit cf7da999a0c77771e582ed3e29e56c79027655a7 Author: mrunal.kapade <mrunal.kapade@intel.com> Date: Wed Mar 15 01:05:29 2017 Replace RELEASE_ASSERT with CHECK in core/svg/ BUG= 697687 Review-Url: https://codereview.chromium.org/2736773004 Cr-Commit-Position: refs/heads/master@{#456931} [modify] https://crrev.com/cf7da999a0c77771e582ed3e29e56c79027655a7/third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp [modify] https://crrev.com/cf7da999a0c77771e582ed3e29e56c79027655a7/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/24cf3269c241270f97890a977a3989577b2c4d31 commit 24cf3269c241270f97890a977a3989577b2c4d31 Author: mrunal.kapade <mrunal.kapade@intel.com> Date: Wed Mar 15 02:05:06 2017 Replace ASSERT with DCHECK in core/svg/ BUG= 697687 Review-Url: https://codereview.chromium.org/2738863002 Cr-Commit-Position: refs/heads/master@{#456946} [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGAngle.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGAnimateMotionElement.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGAnimatedColor.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGBoolean.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGCircleElement.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGDiscardElement.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGDocumentExtensions.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGElement.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGElement.h [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGElementRareData.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGEllipseElement.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGEnumeration.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGEnumeration.h [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGFEBlendElement.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGFEColorMatrixElement.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGFEComponentTransferElement.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGFECompositeElement.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGFEConvolveMatrixElement.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGFEDiffuseLightingElement.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGFEDisplacementMapElement.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGFEDropShadowElement.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGFEFloodElement.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGFEGaussianBlurElement.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGFEMergeElement.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGFEOffsetElement.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGFESpecularLightingElement.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGFETileElement.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGGeometryElement.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGInteger.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGIntegerOptionalInteger.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGLength.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGLengthContext.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGLengthList.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGLengthTearOff.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGMPathElement.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGMarkerElement.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGMatrixTearOff.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGNumber.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGNumberOptionalNumber.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGParsingError.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGParsingError.h [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGPath.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGPathBlender.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGPathByteStreamBuilder.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGPathByteStreamSource.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGPathByteStreamSource.h [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGPathParser.h [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGPathQuery.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGPathStringBuilder.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGPathStringSource.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGPolyElement.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGPreserveAspectRatio.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGRect.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGRectElement.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGSVGElement.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGStaticStringList.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGString.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGTests.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGTextContentElement.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGTransform.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGTransformDistance.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGTransformList.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGURIReference.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/SVGUseElement.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.cpp [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/graphics/filters/SVGFilterBuilder.h [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/properties/SVGAnimatedProperty.h [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/properties/SVGListPropertyHelper.h [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/properties/SVGProperty.h [modify] https://crrev.com/24cf3269c241270f97890a977a3989577b2c4d31/third_party/WebKit/Source/core/svg/properties/SVGPropertyTearOff.h
Comment 1 by tkent@chromium.org
, Mar 2 2017